Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting log level through environment variables #4755

Merged

Conversation

ttzn
Copy link
Contributor

@ttzn ttzn commented Dec 27, 2020

Fixes #4580

For some reason PropertiesLoggingLevelsConfigurer was only loading raw keys.

@ttzn ttzn force-pushed the fix-log-levels-environment-4580 branch from 55cc83d to c9f7418 Compare December 27, 2020 17:50
@jameskleeh
Copy link
Contributor

This could have implications if the intent is to configure the log level of a non conventional package name. For example if someone had com.myApp as a package name, the resulting value would now be com.my-app.

@graemerocher
Copy link
Contributor

@jameskleeh Java package names should be lower case so I think that is non-issue

@ttzn
Copy link
Contributor Author

ttzn commented Dec 29, 2020

@jameskleeh good catch, this MR introduces a regression for those kinds of package names. Maybe we can load both raw keys for compatibility and generated keys to allow environment variables, with a little warning in the doc.

@ttzn ttzn force-pushed the fix-log-levels-environment-4580 branch from 991bb76 to 1787198 Compare December 29, 2020 17:52
@ttzn ttzn requested a review from jameskleeh December 29, 2020 17:55
@graemerocher graemerocher merged commit 0ff869e into micronaut-projects:2.2.x Jan 13, 2021
@graemerocher
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log level using an environment variable ignored
3 participants