Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make Authorization header prefix check case insensitive #257

Merged
merged 5 commits into from May 30, 2020

Conversation

jcassee
Copy link
Contributor

@jcassee jcassee commented May 26, 2020

See #252

According to RFC 7235 section 2.1, the Authorization header value prefix
is a case-insensitive token.
@CLAassistant
Copy link

CLAassistant commented May 26, 2020

CLA assistant check
All committers have signed the CLA.

@graemerocher
Copy link
Contributor

Maybe the change should include toLowerCase(Locale.ENGLISH) as it could break depending on the system locale?

@jcassee
Copy link
Contributor Author

jcassee commented May 26, 2020

Maybe the change should include toLowerCase(Locale.ENGLISH) as it could break depending on the system locale?

Or Locale.ROOT? A quick "find usages" in my IDE finds many similar case-insensitive checks around HTTP are using it.

@jcassee
Copy link
Contributor Author

jcassee commented May 26, 2020

Question: is using a stub the preferred way of testing an abstract class? The Spock docs mention using a partial mock using Spy, but from a quick search through the project code, I don't see Spy used anywhere.

@sdelamo sdelamo merged commit 4e46516 into micronaut-projects:master May 30, 2020
2 checks passed
@sdelamo
Copy link
Contributor

sdelamo commented May 30, 2020

Thanks for the PR @jcassee

Question: is using a stub the preferred way of testing an abstract class? The Spock docs mention using a partial mock using Spy, but from a quick search through the project code, I don't see Spy used anywhere.

Yes, in general we don't use Spy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants