This repository was archived by the owner on Sep 6, 2023. It is now read-only.
esp32/README: Update toolchain setup. #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Right, it should be ok to use the pre-compiled toolchain. I'm using it without any issue. |
dpgeorge
reviewed
Dec 13, 2017
|
|
||
| * [Linux installation](https://esp-idf.readthedocs.io/en/latest/get-started/linux-setup-scratch.html) | ||
| * [MacOS installation](https://esp-idf.readthedocs.io/en/latest/get-started/macos-setup-scratch.html) | ||
| * [Windows installation](https://esp-idf.readthedocs.io/en/latest/get-started/windows-setup-scratch.html) |
Member
There was a problem hiding this comment.
Since it's ok to use the precompiled binaries, please remove the -scratch part of the URL.
| is the most efficient way to install the ESP32 toolchain and build the project. | ||
| If you use WSL then follow the | ||
| [Linux guidelines](http://esp-idf.readthedocs.io/en/latest/get-started/linux-setup.html) | ||
| [Linux guidelines](https://esp-idf.readthedocs.io/en/latest/get-started/linux-setup-scratch.html) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the README expected the toolchain to be built from scratch while the upstream documentation describes a precompiled toolchain downloaded from the Espressif website. I hope the new instructions are correct, but I've just started working on the esp32 port so I don't really know.
edit: I think we should use the binary toolchain, that toolchain is probably better tested and it saves a lot of hassle and time to set up a build environment.
fixes #237