hashlib: Provide all built-in hash functions. #674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a port had md5 enabled, then it would no longer be available. Retain the existing logic of using the built-in preferentially. This work was funded through GitHub Sponsors. Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
KipCrossing
approved these changes
Jun 1, 2023
KipCrossing
left a comment
KipCrossing
left a comment
There was a problem hiding this comment.
LGTM - although there is no easy way for me to test this (that I know of yet)
Member
Author
|
Closing in favour of #675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a port had md5 enabled, then it would no longer be available.
Retain the existing logic of using the built-in preferentially.
This work was funded through GitHub Sponsors.