Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrepl on PICO_W #8961

Closed
villeneuve opened this issue Jul 26, 2022 · 3 comments
Closed

webrepl on PICO_W #8961

villeneuve opened this issue Jul 26, 2022 · 3 comments
Labels

Comments

@villeneuve
Copy link

First thanks guys for giving us this excellent micropython.
To be consistent with pull request #8931 I think the following change is needed:
must be added:
include("$(MPY_DIR)/extmod/webrepl/manifest.py")
to file: micropython/ports/rp2/boards/manifest.py (or maybe another file is more suitable?)
Because currently webrepl works well on ESP8266 but not on PICO_W (no module named 'webrepl')
Thanks
PS: Sorry for raising an issue instead of a pull request, I'm not familiar with that.

@villeneuve villeneuve added the bug label Jul 26, 2022
@jimmo
Copy link
Member

jimmo commented Jul 26, 2022

Duplicate of #8928

@jimmo jimmo marked this as a duplicate of #8928 Jul 26, 2022
@jimmo jimmo closed this as completed Jul 26, 2022
@villeneuve
Copy link
Author

Oh! Sorry I misunderstood. Because the last modification (PR #8931) is included in the ESP8266 port, I thought that the choice about the following point (issue #8928) had been done, in favor of the first option.

We need to decide:

- Should we freeze the webrepl Python files on all boards that include the webrepl C support
 (which is now controlled by MICROPY_PY_NETWORK)

- or. Make webrepl something that can be installed optionally (upip, etc) and document that, 
  and leave it to specific boards that want to freeze it.

@jimmo
Copy link
Member

jimmo commented Jul 28, 2022

#8931 is a separate issue and is a fix to webrepl itself, it just came up in the discussion of #8928 (I wanted to make sure that if we enabled webrepl that it was actually usable).

I don't think #8928 has been decided, except for the specific case of the PICO_W, although the PR still needs to be made to actually do that. In the meantime though you can just copy webrepl.py and webrepl_setup.py to your device.

tannewt added a commit to tannewt/circuitpython that referenced this issue Feb 29, 2024
Checking is_writable_from_python always follows USB policy even if
it is unplugged. Fixes micropython#8986

Also does bare minimum for micropython#8961.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants