Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers/display/ssd1306: add missing parameter for spi.init() #3385

Closed
wants to merge 1 commit into from

Conversation

@zgyarmati
Copy link

zgyarmati commented Oct 22, 2017

and also call spi.init() once instead of each cmd or data sendout, fixes #3384.

…so call spi.init() once instead of each cmd or data sendout, fixes  #3384
@dpgeorge

This comment has been minimized.

Copy link
Member

dpgeorge commented Oct 22, 2017

and also call spi.init() once instead of each cmd or data sendout

The idea behind calling init() each transfer is so that the SPI bus can be used by multiple peripherals, each with different baudrate/polarity/phase.

zgyarmati added a commit to zgyarmati/micropython that referenced this pull request Nov 3, 2017
@zgyarmati

This comment has been minimized.

Copy link
Author

zgyarmati commented Nov 3, 2017

I think it might make sense make this somehow optional, to avoid the performance penalty. I'll try to do some measurements and see it it makes sense, and re-send a similar patch if needed, so closing this for now.

@zgyarmati zgyarmati closed this Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.