Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf/Makefile: Update to match latest oofatfs version. #4657

Closed
wants to merge 1 commit into from

Conversation

@glennrub
Copy link
Contributor

commented Mar 29, 2019

See corresponding commit b5f33ac

See corresponding commit b5f33ac
@dpgeorge

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Looks good to me. I guess Travis didn't pick this up because nRF doesn't have FATFS enabled by default?

@glennrub

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Yep, that's correct. Because of the size it consumes it has been disabled. However, i'm thinking that it might make sense to enable it for the nrf52840 targets. I'll take look later on a split of mpconfigport.h for nrf51/nrf52832/nrf52840 to facilitate different options opt'ed in.

@glennrub

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

Merged in 1f5d945.

@glennrub glennrub closed this Apr 1, 2019
@glennrub glennrub deleted the glennrub:update_oofatfs_changes branch Apr 1, 2019
@dpgeorge

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

I'll take look later on a split of mpconfigport.h for nrf51/nrf52832/nrf52840 to facilitate different options opt'ed in.

In the stm32 port, there is a base stm32/mpconfigport.h file which is common to all boards, and then each board can provide additional options, and/or override defaults, via a stm32/boards/BOARD/mpconfigboard.h file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.