Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: Add/update my copyright. #4787

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@pfalcon
Copy link
Contributor

commented May 14, 2019

Based on the git history, for modules I initially created or made substantial contributions to.

@pfalcon

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

This PR also includes #4363 , which got ignored for more than a half-year now.

@pfalcon pfalcon referenced this pull request May 14, 2019

Open

Preparing for next release, v1.11 #4784

3 of 4 tasks complete
* Copyright (c) 2013, 2014 Damien P. George
* Copyright (c) 2014 Paul Sokolovsky

This comment has been minimized.

Copy link
@dpgeorge

dpgeorge May 15, 2019

Member

Why is the ordered changed here (and elsewhere)? Since 2013 is earlier than 2014 it makes sense to retain the order.

This comment has been minimized.

Copy link
@pfalcon

pfalcon May 15, 2019

Author Contributor

I changed order in files which were initially created by me. I hope you would agree that it makes sense if the original author were listed first.

Also, arguably, your copyright year would be adjusted to match the real history of a file, and if you remember, I did that once in a previous patchset on this matter, but refrained from doing this again, as ultimately, you're the best party to maintain your copyright notice.

(Finally, many copyright notices in files contributed by me in early period get your copyright mostly by cut-n-paste, with rationalization that while I create some module from scratch, the structure of it is governed (and copied) from your substantial effort. While later it became clear that it doesn't scale to have any MicroPython-related file ever written to include your copyright, I obviously don't try to revision notices added at that early time.)

This comment has been minimized.

Copy link
@dpgeorge

dpgeorge May 17, 2019

Member

Ok, you're right that this file looks to be completely fresh (or at least fresh enough) at its time of creation. So I should adjust my year to match the history.

@dpgeorge

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Is it intended to update axtls?

pfalcon added some commits Sep 4, 2018

LICENSE: Add my copyright, as the author of ~30% of commits to the pr…
…oject.

Change-Id: Id40cab51cc51048771ae0799e2a12ccae1d22eb5
various: Add/update my copyright.
Based on the git history, for modules I initially created or made
substantial contributions to.

Change-Id: Ic10a33c6b33f6210bb73ea3625d296f202fda906

@pfalcon pfalcon force-pushed the pfalcon:pfalcon-copyright2 branch from 102191d to 3fc3e37 May 15, 2019

@pfalcon

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Is it intended to update axtls?

Definitely not, rebased.

* Copyright (c) 2013, 2014 Damien P. George
* Copyright (c) 2014 Paul Sokolovsky

This comment has been minimized.

Copy link
@dpgeorge

dpgeorge May 17, 2019

Member

Ok, you're right that this file looks to be completely fresh (or at least fresh enough) at its time of creation. So I should adjust my year to match the history.

@@ -3,6 +3,7 @@
*
* The MIT License (MIT)
*
* Copyright (c) 2014-2017 Paul Sokolovsky

This comment has been minimized.

Copy link
@dpgeorge
@@ -3,8 +3,8 @@
*
* The MIT License (MIT)
*
* Copyright (c) 2014-2018 Paul Sokolovsky

This comment has been minimized.

Copy link
@dpgeorge
@@ -3,6 +3,7 @@
*
* The MIT License (MIT)
*
* Copyright (c) 2014-2017 Paul Sokolovsky

This comment has been minimized.

Copy link
@dpgeorge
@@ -3,6 +3,7 @@
*
* The MIT License (MIT)
*
* Copyright (c) 2014 Paul Sokolovsky

This comment has been minimized.

Copy link
@dpgeorge
@@ -3,6 +3,7 @@
*
* The MIT License (MIT)
*
* Copyright (c) 2015 Paul Sokolovsky

This comment has been minimized.

Copy link
@dpgeorge
@dpgeorge

This comment has been minimized.

Copy link
Member

commented May 17, 2019

I merged the main commit here in 016d9a4, and a follow up in 653e175

For the change to LICENSE, that was not merged and can be discussed further in #4363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.