Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Switch unix stackless build to use clang. #4904

Merged
merged 2 commits into from Jul 17, 2019

Conversation

Projects
None yet
3 participants
@dpgeorge
Copy link
Member

commented Jul 8, 2019

To test a different compiler, other than gcc.

Also might be worth adding circleci as an additional CI to test Mac explicitly.

@pfalcon

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

That doesn't look good. Stackless is quite a configuration on its own, and should be built with "standard" compiler. Clang should be a separate build target.

@dpgeorge

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

Stackless is quite a configuration on its own, and should be built with "standard" compiler.

The aim here is to keep the build time down. We can't check all compilers with all configs.

@pfalcon

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Builds happen in parallel. Stackless is not the best feature to correlate with another one. Try nanbox or something.

@dpgeorge

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

Builds happen in parallel.

Only up to a limit, beyond that they are sequential.

Stackless is not the best feature to correlate with another one. Try nanbox or something.

Stackless is pretty similar to non-stackless. nanbox is a lot different.

@dlech

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Also might be worth adding circleci as an additional CI to test Mac explicitly.

Why not use Travis for macOS? We should be able to add

os:
  - linux
  - osx

Then add if: os = linux to all of the jobs except the ones to build on Mac.

@dpgeorge

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

Why not use Travis for macOS?

Thanks for the hint, I just pushed a change with this to test it. Still, I would like to also try CircleCI, maybe it will be faster and can run in parallel with Travis CI.

@dpgeorge

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

I'm unable to get OSX working under Travis using the stages/jobs that are configured for this repo. I guess it's possible, I just don't know how to do it.

So at this stage I propose to just switch unix stackless build to clang, and investigate OSX CI later on (CircleCI does offer free OSX builds for open source projects).

@dpgeorge dpgeorge force-pushed the dpgeorge:travis-clang branch 2 times, most recently from 61897b2 to da5c878 Jul 12, 2019

dpgeorge added some commits Jul 8, 2019

travis: Switch unix stackless build to use clang.
To test a different compiler, other than gcc.
tests/stress/recursive_iternext.py: Increase large depth to 5000.
So it fails correctly on Linux with clang.

@dpgeorge dpgeorge force-pushed the dpgeorge:travis-clang branch from da5c878 to 3e55830 Jul 17, 2019

@dpgeorge dpgeorge merged commit 3e55830 into micropython:master Jul 17, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0001%) to 97.997%
Details

@dpgeorge dpgeorge deleted the dpgeorge:travis-clang branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.