Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32f405 feather files #5177

Closed
wants to merge 2 commits into from

Conversation

@ladyada
Copy link
Contributor

commented Oct 3, 2019

Tested all GPIO with machine twiddling, I2C with BMP280 library, SPI #1 with SPI Flash chip, SPI #2 with TFT FeatherWing, 2x DAC pins, and SD card.

Couldn't figure out where to stick USB VID/PID?

https://www.flickr.com/photos/adafruit/48833485193/

@hoihu

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

Couldn't figure out where to stick USB VID/PID?

you should be able to define it like:

pyb.usb_mode('VCP+HID', vid=0xf055, pid=0x9800) # specify VID and PID

within your boot.py. If that's what you mean?

Great btw to see adafruit making STM32 boards.

@ladyada

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

thanks :) its a fun chip!
i dont think we ought to submit the boot.py here, so i will provide that in the example code when the micropython documentation is up.

@chrismas9

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2019

within your boot.py

I think this may have unintended consequences. If boards ship with OEM VID & PID the VID & PID will change after a file system reset. I think Windows would assign a different COM port number when the VID changes.

I would like to see a way for OEMs to use their OEM VID. You can copy stm32/usb.h into your board folder, change the VID & PID and include it in mpconfigboard.h. This will build binaries with your VID & PID, however there may be licensing problems. The header file should probably be renamed to OEM_usb.h (eg adafruit_usb.h). The license would probably need to be changed to restrict its use to only that OEMs boards. Would that be acceptable under the MicroPython MIT license? Would it leave the OEM at risk of violatingt the USBIF license? If a clone maker copied your board and used your source code or binaries to distribute your VID would you be seen as facilitating illegal use of the VID by publishing the VID on an open source site?

One solution would be to host the board files outside of the MicroPython repository.

Currently this won't work for the SAMD port as the VID and PID can't be overridden.

@ladyada

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

hiya @chrismas9 that may be outside the scope of this PR, we're going to go with @hoihu's suggestion :)

@dpgeorge

This comment has been minimized.

Copy link
Member

commented Oct 10, 2019

Thanks!

One minor point: I think the board name should be prefixed with ADAFRUIT, to match the existing samd boards that we have in this repo.

How about ADAFRUIT_F405_EXPRESS?

@dpgeorge dpgeorge added the port-stm32 label Oct 10, 2019
@ladyada

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2019

comin' right up!

@ladyada

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2019

done :)

@dpgeorge

This comment has been minimized.

Copy link
Member

commented Oct 11, 2019

Thank you! Merged in 06ae818

@dpgeorge dpgeorge closed this Oct 11, 2019
@ladyada

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2019

:D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.