This repository has been archived by the owner on Dec 29, 2023. It is now read-only.
Explicitly configure the port for catalogue to be 80 in kubernetes/manifests #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marccarre
force-pushed
the
pass-port-to-catalogue
branch
from
5438db4
to
4529807
Compare
marccarre
added a commit
to microservices-demo/catalogue
that referenced
this pull request
Jun 8, 2018
- `Dockerfile` explicitly overrides `8081` with `80`, so might as well have it as the default: github.com/microservices-demo/catalogue/blob/master/docker/catalogue/Dockerfile#L45-L46 - Should one not realise this override is currently required (but no longer, after this change), issues like microservices-demo/microservices-demo/pull/767 could be experienced.
…nifests In case one was to fork this repository and pass arbitrary arguments without passing `-port=80`, `catalogue` would then suddenly no longer work, as: - `catalogue` defaults to `8081`: https://github.com/microservices-demo/catalogue/blob/0.3.5/cmd/cataloguesvc/main.go#L44 - the default override in `Dockerfile` would then be lost: https://github.com/microservices-demo/catalogue/blob/0.3.5/docker/catalogue/Dockerfile#L12 - `/health` therefore wouldn't be reachable on `80` (but `8081`) - Kubernetes therefore wouldn't route traffic to `catalogue`
marccarre
force-pushed
the
pass-port-to-catalogue
branch
from
4529807
to
23a7914
Compare
marccarre
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case one was to fork this repository and pass arbitrary arguments without passing
-port=80,cataloguewould then suddenly no longer work, as:cataloguedefaults to8081: https://github.com/microservices-demo/catalogue/blob/0.3.5/cmd/cataloguesvc/main.go#L44Dockerfilewould then be lost: https://github.com/microservices-demo/catalogue/blob/0.3.5/docker/catalogue/Dockerfile#L12/healththerefore wouldn't be reachable on80(but8081)catalogue