Created a pull request template file #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt at trying to standardize PR descriptions - both for maintainability/documentation purposes and also ensure consistency for some of the fabric bot policies that kick in for PRs specifically.
almedina-ms
added a commit
that referenced
this pull request
Nov 13, 2019
enforces type check on textrun type (#3321) Fixes AutoSize for Portrait Mode (#3318) * fixes auto for portrait mode * addressing review comments adds new file browser and remove direct references to files (#3329) * adds new file browser and remove direct references to files * adding missing file * revamped user interface for sample app * fixes review comment and updated UI * updated UI [UWP] Fix AdaptiveColumn width (#3340) With change fee0c03, pixel width and string width in the shared model are now last-writer-wins. Update `AdaptiveColumn::GetSharedModel()` to account for that. Fixes #3339. [UWP] Update test cert for UWPUnitTests package (#3346) [UWP] Fix issue with nested show cards (#3336) [UWP] Test file updates (#3345) * [UWP] Test file updates * Delete TextBlock.Underline.json [Shared][UWP] Markdown support for non-latin chars (>0x80) (#3342) * [Shared] Markdown support for non-latin chars (>0x80) Fixes #2992 Fixes #3337 * PR feedback * Add requested tests [UWP] Fix link underlining (#3347) Fixes #3341 Originally regressed by #3308 [JavaScript] Fix check in getStringValue (#3350) * [JavaScript] Fix check in getStringValue * revert package-lock change Update ISSUE_TEMPLATE.md Update issue templates to include a new Feature Request template (#3352) - New specific template for feature requests - Allows for adding default labels/assignees Create a new issue template for Bug Reports (#3351) - Follows the newer template workflow which allows for separate templates for bugs and tasks - Allows for automatically labeling the issues as "Bugs" to kick off the internal fabric bot github workflow to get this visible on our project boards Created a pull request template file (#3353) Attempt at trying to standardize PR descriptions - both for maintainability/documentation purposes and also ensure consistency for some of the fabric bot policies that kick in for PRs specifically. [UWP] Build unit tests without .NET Native (#3147) * [UWP] Build unit tests without .NET Native Saves on build times * Do the same with perfapp Fix some merge errors Fix ios build Fix more issues [Shared] Fix DateTimePreparser perf (#3379) Fixes #3378 [UWP] Fix bugs in custom warnings (#3375) * [UWP] Fix bugs in custom warnings * Swig * Update Warning and Error classes to require parameters to their constructors [UWP] Add implementations of factory classes for warnings and errors (#3385) [Android] Add validation for empty data in submit actions (#3193) * Add validation for empty data in submit actions * Change JSONObject initialization [Android] Fix fallback again in master (#3280) * Fix issue introduced by column fallback * Add test for feature registration Fixes compact ChoiceSet with wrap to dynamically update cell height (#3355) * fixes #3299 * update spacing Update layout as selected HostContainer changes (#3392) Add counter to auto hide buttons (#3359) [Security] Bump mixin-deep in /source/nodejs/adaptivecards-designer-app (#3395) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. **This update includes a security fix.** - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Change declaration of static readonly fields (#3407) [Security] Bump mixin-deep in /source/nodejs/adaptivecards-designer (#3397) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. **This update includes a security fix.** - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> [Security] Bump mixin-deep in /source/nodejs/adaptivecards-visualizer (#3396) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. **This update includes a security fix.** - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> [UWP] Use platform character conversion functions instead of codecvt (#3400) * [UWP] Use platform character conversion functions instead of codecvt Fixes #3398 * Use [w]string_view instead of [w]string * Move HRESULT-returning methods to noexcept More designer fixes (#3169) * Inject TS source from js/template-engine * Post build changes * Cleanup * Fix compilation issues (WIP) * Fixes packaging problems * Update README * Publish - adaptivecards-controls@0.3.0 - adaptivecards-data@0.1.0-alpha1 - adaptivecards-designer-app@0.2.1 - adaptivecards-designer@0.7.0 - adaptivecards-site@0.4.1 - hexo-theme-adaptivecards@0.1.1 - adaptivecards-visualizer@1.2.1 - adaptivecards@1.3.0-alpha1 * adaptivecards-data --> adaptivecards-templating * Update README for adaptivecards-templating * Fix a couple typos in README * Significant designer code simplification (WIP) Opportunistic small bug fixes * More designer code simplification * Finalize designer code simplification * Fix minHeight serialization regression * [Designer] Basic versioning support [Designer] Basic property categorization in property sheet * [JS] Hotfix bleed regression in ColumnSet * cleaning up sample payloads, fixing some site bugs * [Designer] Hide more preview features * Update package-lock.json * Publish - adaptivecards-controls@0.3.0 - adaptivecards-designer-app@0.2.1 - adaptivecards-designer@0.7.0 - adaptivecards-site@0.4.1 - hexo-theme-adaptivecards@0.1.2 - adaptivecards-templating@0.1.0-alpha.0 - adaptivecards-visualizer@1.2.2 - adaptivecards@1.3.0-alpha1 - spec-generator@0.5.1 - typed-schema@0.5.1 * dts not working, revert tnhis commit * Add comment * Update example.html * Turn off preview features * Comment update * site fixes, sample updates, and designer package fixes * remove unused files * fix script * updating packages and fixing a merge issue * add helper test scripts * Code review fixes into templating branch * readme fixes and package fix * Resolve merge from master problems * Fix double "Maximum value" mistake * [Designer] Fix inlineAction and selectAction * Fix Input.Number min/max serialized as strings Add missing maxLength property for Input.Text in designer * Remove duplicate valueOn in designer * Designer bug fixes * Fix incorrect action button size in IE11 * Address code review comments added support for inner show cards depth > 1 (#3390) * added support for inner show cards depth > 1 * adds null check * added warnings for null objects * add new row only if inlline is enabled * updated commnets * updated comments * addressed comments Wrap image views in an extra layout if stretch is needed (#3404) Fix first element changing place with background image (#3393) Implemented min and max value range test for Input.Date (#3403) * Implemented min and max value range test for Input.Date * update * enum update * updated android for enum changes adds tool for ios feed (#3291) * update * updated before creating PR * adds publishing tool adds framework in progress feed update adding the tool changed secure token pass from env variable to file updadted ios feed updated ios feed ios feedback update updated the feed iOSFeedBack updated feed ios feed update update complete * CR comment * addressed CR comments * addressing CR comments * CR comments * updated to address for review comments Adding Security.md per Microsoft OSS guidelines (#3417) [UWP] Fix leak in IsBackgroundImageValid (#3380) * [UWP] Fix leak in IsBackgroundImageValid Fixes #3372 * RETURN_IF_FAILED instead of THROW_IF_FAILED [UWP] Change MeetsRequirements method to Requirements property (#3421) * [UWP] Change MeetsRequirements method to Requirements property * Add missing sal Fixes TextInput InlineAction with show card crashes (#3354) * fixes #3295 * refactored target building prcess * Added UnitTest and updated Util.h header name to UtiliOS.h * minor update * fixed spelling * addressed review comments * CR comments addressed * project updated Added visual cue for rich text submit action (#3430) [UWP] Ensure correct parser registrations are passed to custom parsers (#3429) * [UWP] Ensure correct parser registrations are passed to custom parsers * Code Review Feedback * Remove unneeded warnings definition from test updated to apple style guideline (#3433) [.NET] Relax Newtonsoft.Json version requirements (#3438) Fix string/boolean parsing regression with null (#3437) * Fix string/boolean parsing regression with null * Add test card to samples folder * Remove new sample card as it breaks .NET [UWP] Test result updates (#3450) Add two events to designer (#3459) [UWP][.NET][Shared] Update to VS 2019 (#3426) fix xml serialization (#3455) * * update xml serialization tests to use all of the scenario folders * Fix XmlSerialization breaks which crept in because serialization test was pinned to v1.0 scenario files * Fixed xml serialization of nullable types * fix truly strange implementation of AdaptiveHeight "struct" * add copyright Added inner card support for ActionSet (#3449) * added inner card support for ActionSet * fixed for review comments Fixed the issue of image not being vertically stretched (#3446) [.NET] Add new OnDeserializingMissingVersion callback (#3462) * [.NET] Add new OnDeserializingMissingVersion callback Fixes #3376 * PR feedback fix UHF header CSS (#3469) The Microsoft standard header CSS link changed and is currently broken on adaptivecards.io this fixes it Accidentally removed file fix typo Jwoo/wpf showcard style (#3452) * implemented styles for showcard and set default style to be emphasis * clean-up [UWP] Clean up XamlBuilder (#3457) Add validation for properly rendered columns (#3471) [SharedModel] Make requirements case insensitive (#3434) * Remove case sensitiveness from the requirements * Update naming for structs Add ability to customize toolbox titles (#3488) updated exception handling (#3491) [Android] Fix image not growing (#3415) * Fix images not growing in Android * Fix height behaviour for images and add tests * Add test results Make changes for easy transition for .NETCore 3.0 [UWP] Fix cirucular reference in element tag (#3496) Updates to website and blog (#3261) * experiment with a separate hexo blog * fix bad merge * blog polished, added rss, styling, improved editing. had to rename `typed-schema` to `ac-typed-schema` since the pervious name conflicts with an already published npm package * remove unusued files, style tweaks, fixing highlighting * homepage coming together nicely * site mostly working in subdir, hashing cleanup, lots of home content * fixed blog relative links * designer fix and generate schema explorer * add build-model back to git * testing * fix env var * tweaking github author generator * fix images, links, favicon * fix filename * small tweaks * added copy to clipboard button * add Copy Code button, better feedback button, blog code snippets * lots of polish * changing blog to use subtitle instead of excerpt * added site footer and polished blog styling * blog and samples page fully working in desktop and mobile * schema explorer styled * added community call blog content * update package lock * made some of the site config driven, updated blog posts, cleanup * fixed blog videos, added footer link * fix designer open sample * update quote * update quotes * cant async load highlightjs * schema fix, blog fix, trying to fix fabric random build failures * Updated specs * fixed ac-typed-schema to return case-sensitive file names for examples * forgot a file * updated some docs and starting to bundle remote assets * Updated blogging docs, tweaking home page copy based on feedback Fixes #3432 * updated releases tags * copy and styling * update ufh header * designer cdn: added CSS and updated unpkg references to be less fragile * Bundling all third-party assets locally * addressing accessibility color contrast requirements * make homepage videos pause when not in viewport * fixing small compliance issues * remove old .net website hasn't been used in ages * make homepage video autoplay * visual tweaks to homepage * typo in aria attribute * accessibility fixes * september blog post * improving script load performance and improving accessibility - selectively loaded scripts based on the page to delay uneeded downloads - move scripts to the footer where possible to improve page load speed - minor accessibility improvements to the roles of elements * hardened script if other files couldn't load * small fixes * improving twitter share cards * twitter meta fixes [UWP] Update PerfApp cert (#3504) Aligned UWP showcard margin with the rest of renderers (#3494) Fix homepage videos in Safari (#3499) * fixing homepage videos in Safari * change video source markup [Android] Add GetRemoteResourceInformation API test (#3486) * Add API test file * Complete test implementation [iOS] allows default text renderers to be used in their custom versio… (#3498) * [iOS] allows default text renderers to be used in their custom versions of renderer * adding missing files * fixed project file removal by tools (xcode, git, and etc) * CR comments feedback reflection * CR comments fix [Designer] Bug fixes and minor enhancements (#3510) * Designer bug fixes and minor enhancements * Address review feedback [UWP] Fix circular reference in ImageOpened lambda for Auto sized image handling (#3507) Update website README to reflect the most recent changes [.NET] Port WPF renderer to work for .NETCore3.0 (#3156) * Add .net core project * Remove generated images * Add reference for handling fonts * Add global.json * Update global.json * Change globals location * Go back in time to use a previous 3.0 version * Change global.json version * Retry v 3.0.100 * Go gack in version before contacting support * Change version to last for 16.2 * Fix version * Try to fix test file * Try to not add extra file * Revert "Try to not add extra file" This reverts commit 456ee6a. * Fix tabs Create Community-Call-October.md (#3524) [Shared] Introduce clang-cl build support (#3520) * [Shared] Introduce clang-cl build support * Reswig with new changes Fix iOS builds Add more test cards Change Android namespaces and update general application Update Sample app Add iOS updates
almedina-ms
added a commit
that referenced
this pull request
Feb 5, 2020
* Updated Contributors.md entries (#3035) * Update package.json (#3036) * Update Web Chat hostconfig & designer css (#3040) * Update Web Chat hostconfig & designer css * formatting fix for .json file * [UWP][TestApp] Usability Improvements (#3046) * [UWP][TestApp] Usability Improvements * PR Feedback * [Samples] Sort the files under samples/Tests by version (#3019) * [UWP] Update test projects to use new locations * [Samples] Sort the files under samples/Tests by version * [UWP] Update test files to reflect new locations * Fix .NET * ios update * Update datauri test files * Schema and site updates for 1.2 (#3044) WOOT * [UWP][TestApp] Reliability fixes (#3069) * Add px to Column.width and some other schema description updates (#3080) * Add pixel widths to column * Describe the pixel format of minHeight * Update 1.2.0 schema descriptions There's no actual schema validation changes, just description changes, so no need to bump the version number * Spec tooling and specs (#3068) Added tooling so that we can generate specs from our schema, so that our spec'ing process starts with updating the schema first, leading to less errors and mistakes in the end :) In `schemas\src`, add your new properties/elements to the schema  ### 3. Generate the updated spec If you followed the setup instructions, simply save the file and the spec will be updated! Add any necessary rendering details to the spec.  ## Review spec Submit a pull request for your updated spec/schema. The proposed schema in the proposal becomes outdated and should be replaced with a link to the PR.  I'll share more details about this at Monday's meeting. Lots of details about the new proposed spec'ing process are captured here: https://github.com/microsoft/AdaptiveCards/wiki/Project-Management ###### Microsoft Reviewers: [Open in CodeFlow](http://wpcp.azurewebsites.net/CodeFlowProtocolProxy2.php?pullrequest=https://github.com/microsoft/AdaptiveCards/pull/3068) * [JS] Hotfix bleed regression in ColumnSet (#3082) * [TS] Fully disable input validation (#3091) * monacoEditorLoaded -> monacoModuleLoaded (#3093) * Fix missing feature registration issue (#3038) * Update README.md badges to point to master branch (#3017) * [UWP][UnitTests] Move sample resource resolver into shared test library (#3074) * [Shared] Fix error cases for array parsing (#3075) * fixes issue #3057 (#3059) * Fix site's explorer sidebar's scrolling (#3090) * Fix sidebar scrolling * Try/catch only the AC stuff * Fix website JS file cache issues (#3102) * Include version numbers on website's JS scripts * Fix root-relative path * Fix formatting * Also version css files on website (#3103) * Include version numbers on website's JS scripts * Fix root-relative path * Fix formatting * Version CSS files too * Added adaptivecards-fabric (#3106) * added adaptive cards fabric; added tests * updated build scripts * input validation * reverted unintended changes * moved jest config to package.json; moved tests into src directory * CR feedback. updated string parsing; updated number parsing * updated snapshots; minor cleanups * Removes object creation from passing itself in argument (#3100) * removed play icon from hostconfig (#3126) * Fix typo (#3108) * [Shared Model] [.NET] Allow images in image set to not specify element type (#3109) * [Shared Model] Allow images in image set to not specify element type * [.NET] Allow images in image set to not specify element type * Fix spacing * Fabric integration (#3124) * refactored fabric extension interface * added a readme * cleaning up fabric file names and package output structure * API polish, minor renames, webpack tweaks, example page * Made folders lowercase, matches the conventions in the rest of the repo * Renamed `usedFabricComponents` to `useFabricControls` * Changed README function call to `ACFabric.useFabricControls()` since it makes the use consistent when using either Browser/ESM usage. Devs who prefer to import just the function can do so if they choose * Added minified version with `npm run release` * Added example page that loads nicely! * renamed back to `useFabricComponents` after more research Fabric is still not externalized in webpack since I can't get the reference right. Will keep looking * bring fabric back into buncle * added styling to sample page * add gif to readme, make fabric external, update peer dependency version * site fixes, sample payload updates, and designer package fixes (#3122) * [JS] Hotfix bleed regression in ColumnSet * cleaning up sample payloads, fixing some site bugs * site fixes, sample updates, and designer package fixes * remove unused files * fix script * Removes extra pair of quotation marks (#3121) * [Shared] Add Serialize and DeserializeFromString methods to BackgroundImage (#3116) * Add Deserialize from string method to Background image * Fix formatting * Fix extra initializer * Remove extra qualification * [Samples] Update sample texts (#3118) * Update tests * Update test resukts * Fix wrapping in choiceSet compact and move test to correct folder (#3130) * Add null check to discern on element being an action (#3119) * fixes issue #3104 (#3105) * fixes issue #3104 * CR review update * Jwoo/ios fix (#3134) * Add base for unit tests * Add unit tests for TextBlock, Image, Media, Container and CollectionTypeElement * Add more tests * Adds all actions to tests * Add tests for base element properties * Add tests for almost all elements * Add missing readonly elements tests * Add warning for test that fails * [Android] Add unit tests for inpu elements (#3094) * Add text input tests * Add numberInputTests * Add Date and Time input tests * Add toggle visibility and choiceset input tests * Fix togggle input tests * fixing layout constraint issue * dev complete * ready * [TS] Update package versions (#3135) * [UWP] /w4 /wx, control guard and attendant fixes (#3120) Fixes #3061 * [TS] Templating/data binding support (renderer + designer) (#2995) * Inject TS source from js/template-engine * Post build changes * Cleanup * Fix compilation issues (WIP) * Fixes packaging problems * Update README * Publish - adaptivecards-controls@0.3.0 - adaptivecards-data@0.1.0-alpha1 - adaptivecards-designer-app@0.2.1 - adaptivecards-designer@0.7.0 - adaptivecards-site@0.4.1 - hexo-theme-adaptivecards@0.1.1 - adaptivecards-visualizer@1.2.1 - adaptivecards@1.3.0-alpha1 * adaptivecards-data --> adaptivecards-templating * Update README for adaptivecards-templating * Fix a couple typos in README * Significant designer code simplification (WIP) Opportunistic small bug fixes * More designer code simplification * Finalize designer code simplification * Fix minHeight serialization regression * [Designer] Basic versioning support [Designer] Basic property categorization in property sheet * [JS] Hotfix bleed regression in ColumnSet * cleaning up sample payloads, fixing some site bugs * [Designer] Hide more preview features * Update package-lock.json * Publish - adaptivecards-controls@0.3.0 - adaptivecards-designer-app@0.2.1 - adaptivecards-designer@0.7.0 - adaptivecards-site@0.4.1 - hexo-theme-adaptivecards@0.1.2 - adaptivecards-templating@0.1.0-alpha.0 - adaptivecards-visualizer@1.2.2 - adaptivecards@1.3.0-alpha1 - spec-generator@0.5.1 - typed-schema@0.5.1 * dts not working, revert tnhis commit * Add comment * Update example.html * Turn off preview features * Comment update * site fixes, sample updates, and designer package fixes * remove unused files * fix script * updating packages and fixing a merge issue * add helper test scripts * Code review fixes into templating branch * readme fixes and package fix * Resolve merge from master problems * [TS] Turn on built in input validation (#3129) * Remove action type from style (#3138) * [UWP] Fix debug build (#3153) * [UWP] Set 'DebugInformationFormat' to 'ProgramDatabase' to avoid conflicts between the '/ZI' and '/guard:cf' options * Fix warnings treated as errors * [UWP][TestApp] Update test results due to sample changes (#3149) * Update spec generator script Have it also install so that it works on new computers * update site with latest designer, setup Open Sample button, fix some … (#3160) * update site with latest designer, setup Open Sample button, fix some styling * formatting * formatting * replace missing scripts from site pacakge.json * Publish fabric (#3133) * refactored fabric extension interface * added a readme * cleaning up fabric file names and package output structure * API polish, minor renames, webpack tweaks, example page * Made folders lowercase, matches the conventions in the rest of the repo * Renamed `usedFabricComponents` to `useFabricControls` * Changed README function call to `ACFabric.useFabricControls()` since it makes the use consistent when using either Browser/ESM usage. Devs who prefer to import just the function can do so if they choose * Added minified version with `npm run release` * Added example page that loads nicely! * renamed back to `useFabricComponents` after more research Fabric is still not externalized in webpack since I can't get the reference right. Will keep looking * bring fabric back into buncle * added styling to sample page * add gif to readme, make fabric external, update peer dependency version * fix readme and update package.json * publish 1.0.1 * updated exports * updated the way how ReactInputElement overrides value; upated test snapshots * reverted snapshots * defaultValue initialization * rename folders to be lower case * publish adaptivecards-fabric 1.0.2 * addressed cr comments * added tests * addressed CR comments * Added inline action support * update fabric readme * typo in payload * Publish - adaptivecards-controls@0.3.1 - adaptivecards-designer-app@0.2.2 - adaptivecards-designer@0.7.0 - adaptivecards-fabric@1.0.3 - adaptivecards-site@0.4.2 - hexo-theme-adaptivecards@0.1.1 - adaptivecards-templating@0.1.0-alpha.1 - adaptivecards-visualizer@1.2.3 - adaptivecards@1.3.0-alpha.2 - spec-generator@0.5.2 - typed-schema@0.5.2 * fix designer dependencies * Publish - adaptivecards-designer-app@0.2.3 - adaptivecards-designer@0.7.1 - adaptivecards-site@0.4.3 * enable local debugging of the fabric lib with npm start (#3161) * [Security] Bump lodash.template from 4.4.0 to 4.5.0 in /source/nodejs (#3179) Bumps [lodash.template](https://github.com/lodash/lodash) from 4.4.0 to 4.5.0. **This update includes security fixes.** - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.4.0...4.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Security] Bump lodash in /source/nodejs/adaptivecards-visualizer (#3191) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. **This update includes security fixes.** - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.14) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Security] Bump lodash in /source/tools/hostConfig/scss-to-json (#3185) * [Security] Bump lodash in /source/nodejs/adaptivecards-designer-app (#3188) * [Security] Bump lodash in /source/nodejs/adaptivecards (#3190) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. **This update includes security fixes.** - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.14) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Security] Bump lodash in /source/nodejs/adaptivecards-controls (#3189) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. **This update includes security fixes.** - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.14) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Security] Bump lodash from 4.17.11 to 4.17.14 in /source/nodejs (#3187) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. **This update includes security fixes.** - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.14) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Security] Bump lodash in /source/nodejs/adaptivecards-designer (#3186) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. **This update includes security fixes.** - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.14) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [TS] Update dependencies for security * [UWP] Add handling for column fallback (#3197) * [UWP] Add handling for column fallback * Fix shared model x64 build * [Shared] Remove isRequired property serialization (#3131) * Remove isRequired property serialization * Fix test json * Add validation for serialization * Update test results * Fix UWP unit tests * Fix toggle input default values for valueOn and valueOff (#3227) * Fix input values for toggle input * Fix serialization * [Android] Updated Android Daily Feed (#3229) * updating user name * updated build script * updated package dest * testing * updated version * update * testing * update * build update * updating version * build number * replaced sdk version * Fixes issue #3159 (#3195) * first commit * need to fix hidden constraints * fixed issue * CR comments update * [.NET] Fix separator location for elements (#3157) * Fix separators * Fix separator again for making one element * Fix los res images not growing (#3162) * [TS] Node package updates (#3236) * [.NET] Updates to dotnet dependencies (#3231) Switch to public version of MarkedNet Verified by running tests as well as HTML sample app * [Android] Add support for links in FactSets (#3235) * Add listener for links in fact sets * Add test file * Add tests results * [Android] Fix column fallback (#3233) * Fix column fallback and removal of extra spacings * Rename method for clarity * Fix spacing * Fix text wrap (#3240) * implements column fallback (#3238) * implements column fallback * added new test file * Remove backgroundImage from ColumnSet (#3250) The property wasn't supposed to be on there and it was an accidental addition to the schema which none of the renderers support * Removed the `backgroundImage` property from the schema * Updated the `Input.Toggle.value` description since it had a new typo and was also worded very confusingly * Generated the new `1.2.1` schema * Jwoo/ios auto priority update (#3232) * first commit * need to fix hidden constraints * fixed issue * adjust hugging priority to mimic behaviors of other renderers * [UWP] Update AdaptiveCards.Rendering.Uwp.idl to modern idl (#3258) * [UWP] Add ExpectedVisibility flag to tag to avoid hiding separator (#3264) * Add expected visibility flag to avoid auto size images issue * Update tests results * Fix comments * [.NET] Add manual versioned references to System.Net.Http 4.3.1 (#3268) * [TS] Update npm packages (#3266) * [.NET] Across-the-board nuget package updates (#3276) * [.NET] Update Microsoft.AspNetCore.Server.IIS to 2.2.6 for security (#3275) * [UWP] Update C# project references for security (#3279) * Update package.json and npm audit changes (#3282) * [.NET] Update CopySignFiles.cmd for build changes (#3284) * [Shared Model][UWP] Add input validation to the object model (#3226) * [Android] Add android unit tests for all elements (#3067) * Add base for unit tests * Add unit tests for TextBlock, Image, Media, Container and CollectionTypeElement * Add more tests * Adds all actions to tests * Add tests for base element properties * Add tests for almost all elements * Add missing readonly elements tests * Add warning for test that fails * [Android] Add unit tests for inpu elements (#3094) * Add text input tests * Add numberInputTests * Add Date and Time input tests * Add toggle visibility and choiceset input tests * Fix togggle input tests * Add RichTextBlock tests * Fix another merge error * Fix input values for toggle input * Fix serialization * Update react native readme (#3307) * Update to HyperLink Behavior (#3304) * fixed issue 2837 (#3245) * [Android] Add options page for setting custom elements (#3292) * Add options page for setting custom elements * Fix tabs * Reactnative/yarn update - update jest version to remove vulnerabilites (#3319) * Updated yarn lock with latest package.json * Jest version updated to 24.0.0 * [Shared][UWP] Add underline support to TextRun (#3308) * Add underline to TextBlock and * Refactor text run styling being passed around in TextHelper functions * Fix renderer version to 1.3 * Add shared model unit test * Add UWP unit tests * [Shared] Reflect changes between width and pixel width (#3317) Fixes #3228 * [Android] Add underline support to RichTextBlock (#3313) * Add underline to TextBlock and * Refactor text run styling being passed around in TextHelper functions * Fix renderer version to 1.3 * Add underline support for androis * Add shared model unit test * Add UWP unit tests * Add android unit tests * [iOS] Add underline support to TextRun (#3314) * Add underline to TextBlock and * Refactor text run styling being passed around in TextHelper functions * Fix renderer version to 1.3 * Add shared model unit test * Add UWP unit tests * Add ios support for underlien * Removing auto-generated example test cases (#2683) * [UWP][.NET] Update SignConfig.xml to use stronger signing regime (#3158) * Move inline action rendering to its own function (#3257) * [.NET] Get .Net Standard 1.3 back in the build (#3325) * [.NET] Get .Net Standard 1.3 back in the build Fixes #3323. This reverts commit 3c63421. This reverts commit 1974570. * Remove unnecessary `Debugger.Break();` call * add ability to inject custom typefaces into TextRendererUtil.java (#3137) * [.NET + WPF + HTML] Add underline support (#3316) * Add underline support to WPF * Add underline to html * [.NET WPF] Add a checkbox to visualizer to toggle usage of Xceed renderers (#3326) * [.NET WPF] Add a checkbox to visualizer to toggle usage of Xceed renderers * PR Feedback * enforces type check on textrun type (#3321) * Fixes AutoSize for Portrait Mode (#3318) * fixes auto for portrait mode * addressing review comments * adds new file browser and remove direct references to files (#3329) * adds new file browser and remove direct references to files * adding missing file * revamped user interface for sample app * fixes review comment and updated UI * updated UI * [UWP] Fix AdaptiveColumn width (#3340) With change fee0c03, pixel width and string width in the shared model are now last-writer-wins. Update `AdaptiveColumn::GetSharedModel()` to account for that. Fixes #3339. * [UWP] Update test cert for UWPUnitTests package (#3346) * [UWP] Fix issue with nested show cards (#3336) * [UWP] Test file updates (#3345) * [UWP] Test file updates * Delete TextBlock.Underline.json * [Shared][UWP] Markdown support for non-latin chars (>0x80) (#3342) * [Shared] Markdown support for non-latin chars (>0x80) Fixes #2992 Fixes #3337 * PR feedback * Add requested tests * [UWP] Fix link underlining (#3347) Fixes #3341 Originally regressed by #3308 * [JavaScript] Fix check in getStringValue (#3350) * [JavaScript] Fix check in getStringValue * revert package-lock change * Update ISSUE_TEMPLATE.md * Update issue templates to include a new Feature Request template (#3352) - New specific template for feature requests - Allows for adding default labels/assignees * Create a new issue template for Bug Reports (#3351) - Follows the newer template workflow which allows for separate templates for bugs and tasks - Allows for automatically labeling the issues as "Bugs" to kick off the internal fabric bot github workflow to get this visible on our project boards * Created a pull request template file (#3353) Attempt at trying to standardize PR descriptions - both for maintainability/documentation purposes and also ensure consistency for some of the fabric bot policies that kick in for PRs specifically. * [UWP] Build unit tests without .NET Native (#3147) * [UWP] Build unit tests without .NET Native Saves on build times * Do the same with perfapp * [Shared] Fix DateTimePreparser perf (#3379) Fixes #3378 * [UWP] Fix bugs in custom warnings (#3375) * [UWP] Fix bugs in custom warnings * Swig * Update Warning and Error classes to require parameters to their constructors * [UWP] Add implementations of factory classes for warnings and errors (#3385) * [Android] Add validation for empty data in submit actions (#3193) * Add validation for empty data in submit actions * Change JSONObject initialization * [Android] Fix fallback again in master (#3280) * Fix issue introduced by column fallback * Add test for feature registration * Fixes compact ChoiceSet with wrap to dynamically update cell height (#3355) * fixes #3299 * update spacing * Update layout as selected HostContainer changes (#3392) * Add counter to auto hide buttons (#3359) * [Security] Bump mixin-deep in /source/nodejs/adaptivecards-designer-app (#3395) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. **This update includes a security fix.** - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Change declaration of static readonly fields (#3407) * [Security] Bump mixin-deep in /source/nodejs/adaptivecards-designer (#3397) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. **This update includes a security fix.** - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [Security] Bump mixin-deep in /source/nodejs/adaptivecards-visualizer (#3396) Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. **This update includes a security fix.** - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [UWP] Use platform character conversion functions instead of codecvt (#3400) * [UWP] Use platform character conversion functions instead of codecvt Fixes #3398 * Use [w]string_view instead of [w]string * Move HRESULT-returning methods to noexcept * More designer fixes (#3169) * Inject TS source from js/template-engine * Post build changes * Cleanup * Fix compilation issues (WIP) * Fixes packaging problems * Update README * Publish - adaptivecards-controls@0.3.0 - adaptivecards-data@0.1.0-alpha1 - adaptivecards-designer-app@0.2.1 - adaptivecards-designer@0.7.0 - adaptivecards-site@0.4.1 - hexo-theme-adaptivecards@0.1.1 - adaptivecards-visualizer@1.2.1 - adaptivecards@1.3.0-alpha1 * adaptivecards-data --> adaptivecards-templating * Update README for adaptivecards-templating * Fix a couple typos in README * Significant designer code simplification (WIP) Opportunistic small bug fixes * More designer code simplification * Finalize designer code simplification * Fix minHeight serialization regression * [Designer] Basic versioning support [Designer] Basic property categorization in property sheet * [JS] Hotfix bleed regression in ColumnSet * cleaning up sample payloads, fixing some site bugs * [Designer] Hide more preview features * Update package-lock.json * Publish - adaptivecards-controls@0.3.0 - adaptivecards-designer-app@0.2.1 - adaptivecards-designer@0.7.0 - adaptivecards-site@0.4.1 - hexo-theme-adaptivecards@0.1.2 - adaptivecards-templating@0.1.0-alpha.0 - adaptivecards-visualizer@1.2.2 - adaptivecards@1.3.0-alpha1 - spec-generator@0.5.1 - typed-schema@0.5.1 * dts not working, revert tnhis commit * Add comment * Update example.html * Turn off preview features * Comment update * site fixes, sample updates, and designer package fixes * remove unused files * fix script * updating packages and fixing a merge issue * add helper test scripts * Code review fixes into templating branch * readme fixes and package fix * Resolve merge from master problems * Fix double "Maximum value" mistake * [Designer] Fix inlineAction and selectAction * Fix Input.Number min/max serialized as strings Add missing maxLength property for Input.Text in designer * Remove duplicate valueOn in designer * Designer bug fixes * Fix incorrect action button size in IE11 * Address code review comments * added support for inner show cards depth > 1 (#3390) * added support for inner show cards depth > 1 * adds null check * added warnings for null objects * add new row only if inlline is enabled * updated commnets * updated comments * addressed comments * Wrap image views in an extra layout if stretch is needed (#3404) * Fix first element changing place with background image (#3393) * Implemented min and max value range test for Input.Date (#3403) * Implemented min and max value range test for Input.Date * update * enum update * updated android for enum changes * adds tool for ios feed (#3291) * update * updated before creating PR * adds publishing tool adds framework in progress feed update adding the tool changed secure token pass from env variable to file updadted ios feed updated ios feed ios feedback update updated the feed iOSFeedBack updated feed ios feed update update complete * CR comment * addressed CR comments * addressing CR comments * CR comments * updated to address for review comments * Adding Security.md per Microsoft OSS guidelines (#3417) * [UWP] Fix leak in IsBackgroundImageValid (#3380) * [UWP] Fix leak in IsBackgroundImageValid Fixes #3372 * RETURN_IF_FAILED instead of THROW_IF_FAILED * [UWP] Change MeetsRequirements method to Requirements property (#3421) * [UWP] Change MeetsRequirements method to Requirements property * Add missing sal * Fixes TextInput InlineAction with show card crashes (#3354) * fixes #3295 * refactored target building prcess * Added UnitTest and updated Util.h header name to UtiliOS.h * minor update * fixed spelling * addressed review comments * CR comments addressed * project updated * Added visual cue for rich text submit action (#3430) * [UWP] Ensure correct parser registrations are passed to custom parsers (#3429) * [UWP] Ensure correct parser registrations are passed to custom parsers * Code Review Feedback * Remove unneeded warnings definition from test * updated to apple style guideline (#3433) * [.NET] Relax Newtonsoft.Json version requirements (#3438) * Fix string/boolean parsing regression with null (#3437) * Fix string/boolean parsing regression with null * Add test card to samples folder * Remove new sample card as it breaks .NET * [UWP] Test result updates (#3450) * Add two events to designer (#3459) * [UWP][.NET][Shared] Update to VS 2019 (#3426) * fix xml serialization (#3455) * * update xml serialization tests to use all of the scenario folders * Fix XmlSerialization breaks which crept in because serialization test was pinned to v1.0 scenario files * Fixed xml serialization of nullable types * fix truly strange implementation of AdaptiveHeight "struct" * add copyright * Added inner card support for ActionSet (#3449) * added inner card support for ActionSet * fixed for review comments * Fixed the issue of image not being vertically stretched (#3446) * [.NET] Add new OnDeserializingMissingVersion callback (#3462) * [.NET] Add new OnDeserializingMissingVersion callback Fixes #3376 * PR feedback * fix UHF header CSS (#3469) The Microsoft standard header CSS link changed and is currently broken on adaptivecards.io this fixes it * Accidentally removed file * fix typo * Jwoo/wpf showcard style (#3452) * implemented styles for showcard and set default style to be emphasis * clean-up * [UWP] Clean up XamlBuilder (#3457) * Add validation for properly rendered columns (#3471) * [SharedModel] Make requirements case insensitive (#3434) * Remove case sensitiveness from the requirements * Update naming for structs * Add ability to customize toolbox titles (#3488) * updated exception handling (#3491) * [Android] Fix image not growing (#3415) * Fix images not growing in Android * Fix height behaviour for images and add tests * Add test results * [UWP] Fix cirucular reference in element tag (#3496) * Updates to website and blog (#3261) * experiment with a separate hexo blog * fix bad merge * blog polished, added rss, styling, improved editing. had to rename `typed-schema` to `ac-typed-schema` since the pervious name conflicts with an already published npm package * remove unusued files, style tweaks, fixing highlighting * homepage coming together nicely * site mostly working in subdir, hashing cleanup, lots of home content * fixed blog relative links * designer fix and generate schema explorer * add build-model back to git * testing * fix env var * tweaking github author generator * fix images, links, favicon * fix filename * small tweaks * added copy to clipboard button * add Copy Code button, better feedback button, blog code snippets * lots of polish * changing blog to use subtitle instead of excerpt * added site footer and polished blog styling * blog and samples page fully working in desktop and mobile * schema explorer styled * added community call blog content * update package lock * made some of the site config driven, updated blog posts, cleanup * fixed blog videos, added footer link * fix designer open sample * update quote * update quotes * cant async load highlightjs * schema fix, blog fix, trying to fix fabric random build failures * Updated specs * fixed ac-typed-schema to return case-sensitive file names for examples * forgot a file * updated some docs and starting to bundle remote assets * Updated blogging docs, tweaking home page copy based on feedback Fixes #3432 * updated releases tags * copy and styling * update ufh header * designer cdn: added CSS and updated unpkg references to be less fragile * Bundling all third-party assets locally * addressing accessibility color contrast requirements * make homepage videos pause when not in viewport * fixing small compliance issues * remove old .net website hasn't been used in ages * make homepage video autoplay * visual tweaks to homepage * typo in aria attribute * accessibility fixes * september blog post * improving script load performance and improving accessibility - selectively loaded scripts based on the page to delay uneeded downloads - move scripts to the footer where possible to improve page load speed - minor accessibility improvements to the roles of elements * hardened script if other files couldn't load * small fixes * improving twitter share cards * twitter meta fixes * [UWP] Update PerfApp cert (#3504) * Aligned UWP showcard margin with the rest of renderers (#3494) * Fix homepage videos in Safari (#3499) * fixing homepage videos in Safari * change video source markup * [Android] Add GetRemoteResourceInformation API test (#3486) * Add API test file * Complete test implementation * [iOS] allows default text renderers to be used in their custom versio… (#3498) * [iOS] allows default text renderers to be used in their custom versions of renderer * adding missing files * fixed project file removal by tools (xcode, git, and etc) * CR comments feedback reflection * CR comments fix * [Designer] Bug fixes and minor enhancements (#3510) * Designer bug fixes and minor enhancements * Address review feedback * [UWP] Fix circular reference in ImageOpened lambda for Auto sized image handling (#3507) * Update website README to reflect the most recent changes * [.NET] Port WPF renderer to work for .NETCore3.0 (#3156) * Add .net core project * Remove generated images * Add reference for handling fonts * Add global.json * Update global.json * Change globals location * Go back in time to use a previous 3.0 version * Change global.json version * Retry v 3.0.100 * Go gack in version before contacting support * Change version to last for 16.2 * Fix version * Try to fix test file * Try to not add extra file * Revert "Try to not add extra file" This reverts commit 456ee6a. * Fix tabs * Create Community-Call-October.md (#3524) * [Shared] Introduce clang-cl build support (#3520) * [Shared] Introduce clang-cl build support * Reswig with new changes * User/almedina ms/update net core version (#3530) * Make changes for easy transition for .NETCore 3.0 * Fix NET Core version * [UWP] Add accessible names to all action buttons (#3528) Fixes #3527 * [.NET] Updated obsolete messages (#3529) * [iOS] Added Custom Parsing and allowed signal to be passed to host app from… (#3526) * Added Custom Parsing and allowed signal to be passed to host app from custom action in SelectAction * updated with CR fixes * fixed for CR comments * addresssing CR comments * [iOS][Sample App]Updated custom image renderer to handle toggle visibility (#3514) * [iOS][Sample App]Updated custom image renderer to handle toggle visiblity * toggle visibilty delegate will call action delegate to notify view frame changes * Site compliance fixes (#3540) * Add X-Content-Type-Options header * update sample payloads to use HTTPS for Action.OpenUrl and Images * find-replace accidently caught this one, reverting * updated url * Parse Context Update (#3548) * made parse context not static; need to fix the internal id being null when showcard is parsed * adding missing file * add parse context for property parsing * work in progress * fixes concurrency issue during parsing * minor fix * updated PR per CR comments * [UWP] Update expected testapp results (#3557) * [.NET][Core3.0] Split NETCore 3.0 to another solution (#3558) * Split NETCore 3.0 to another solution * Remove global.json * Fix tests * .Net Concurrency (#3556) * addressed the review comments * review comments fixes * [UWP] Use custom button to show OpenUrl actions as links (#3555) * [Tools] Update scss-to-json dependencies (#3539) Update to latest node-sass package to pick up downstream dependency updates * [TS] Regression fixes (#3571) * Update website with templating enabled by default (#3505) * fixing homepage videos in Safari * change video source markup * update designer with feedback button and ability to toggle preview features during build * changing designer preview env variable to string * code cleanup * fix docs and templating packing * Fix issue where we were throwing errors in dev console when editing JSON * update monaco to latest * fix typo in our docs and samples * templating support enabled by default in designer; big updates to Samples page with templates * fix json copy button * small cleanup * add html content to blog RSS feed * update app insights * tweaking home page verbiage * updating catch phrase * testing * updated the file name * change default designer payload to use/explain templating * remove sample data from catalog for now * adding missing file * adding templates for CalendarReminder * Weather Compact Added * fixed stock to show latest stock price * updated stock to display number properly and add WeatherLarge Card * added SportingEvent sampe template data * adding Image Gallery template / data * updated Input Form templates * updated spacing and added product Vide templates * added templates for Flight Detail * add templates for FlightUpdate * added FlightItinerary templates * added FoodOrder templates * added Inputs * added Solitaire * added templates for SimpleFallback * added templates for agenda/expenserepot * updated Inputs template * [TS] Fix weighted column width regression (#3586) * remove arrow functions to support legacy browsers (#3590) * update web.config to serve static font files (#3597) * update web.config to fix serving static font files * remove redundant json entry * add .eot font file support * Remove symbols nuget package signing reference (#3596) The UWP renderer is native code which is unsupported by the nuget symbol server. If you nuget pack without the -Symbols flag then the pdb's will be bundled into the regular package, so consumers can still get the pdbs. However, the symbols.nupkg will never be generated. This config is used as input after the symbols package is created so shouldn't reference a package that won't exist. * [UWP] OpenUrl selectActions appear as links to accessibility (#3593) Fixes #3591 Note -- original code in XamlBuilder moved to ActionHelpers (since master is post-refactor) * Toggle Input and ChoiceSet Input support foreground color based parental (#3552) style * Adding /profile linker option (#3607) For this issue: #3606 This flag is needed for mandatory static analysis as part of our process. * [Android] Fix action icon being shown outside the rendered button (#3547) * Make changes for easy transition for .NETCore 3.0 * Fix icon image padding to the right * Add calls to support multiple device resolutions * [Android] Fix spacing in ChoiceSets with wrappjng (#3594) * Hotfix for padding * Fix Spacing by changing lines to maxLiens * Add Teams test fikes * [Android] Add support for new lines in TextBlock (#3599) * Add support for new lines in TextBlock * Add unit test * Add Teams test file * Second revision for \r * [Android] Add empty options support for ChoiceSet (#3615) * Add solution 1 for default value * Make a good fix for combo box * Add teams test file * Remove unnecessary extra class * [Security] Bump https-proxy-agent from 2.2.2 to 2.2.4 in /source/nodejs (#3622) Bumps [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) from 2.2.2 to 2.2.4. **This update includes security fixes.** - [Release notes](https://github.com/TooTallNate/node-https-proxy-agent/releases) - [Commits](TooTallNate/proxy-agents@2.2.2...2.2.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * [TS] Fix column fallback regression (#3601) * [TS] Fix collapsed ShowCard losing input values (#3621) * Fixes Vertical Alignment Issue on iOS (#3630) * Fixes vertical alignment issue & horizontal stretch * updated changes for release/1.2 * updated * clang-formatted * updating test files * Updated json spaces with tabs * [TS] Fix RichTextBlock rendering bug (#3645) * Implemented the minheight property for the container (#3641) * Implemented the minheight property for the container * Addde the method to convert string to number to handle the minheight value * Resolved review comment - updated the conatiner style assignment * Reactnative/bug fixes (#3648) * Added properties for light and dark colors * Updated the styles for containers to match with ios native * Added the Container.Style json in the payload * Updating adaptivecards.io homepage's roadmap links to point to the updated productboard portal (#3659) * Input Labels Spec Documents (#3618) * Input Labels Spec Documents * Updated with some feedback from design discussion meeting * More review feedback upates * Update schema and spec to have label on all inputs * Update test app results for new sample * Makes sure to use InvariantCulture when rendering colors and line-height. (#3657) * improve designer docs to not hard code cdn versions (#3256) * improve designer docs to not hard code cdn versions * add docs to show modifying the Element toolbar and Actions flyout * Website fixes (#3661) * remove arrow functions to support legacy browsers * app insights not firing custom events, update homepage * removed extra quote, changed product name * moving "addtoany" script to local copy, remove unneeded fontawesome reference * added blog posts and tweaked post styling * fix Try it Yourself buttons with templating disabled * fix designer path for PR builds * fix adaptive cards in blog posts * change designer default payload back to original (#3665) And made the site load the templated default card. I should have done it this way in the first place, whoops. * added package.json version to make component governance happy * for some reason this file is "unable to parse" in the build server (#3667) Seeing if this change fixes it * Reactnative/release 1.2.2 (#3666) * Added properties for light and dark colors * Updated the styles for containers to match with ios native * Added the Container.Style json in the payload * Updated the version to 1.2.2 * bump package versions for publish * adds debug symbols to ios framework (#3652) * updated the project to include dSYM * updated project file * Jwoo/ios certificate (#3662) * updated it for code signing * sign update * sign * sigin update * updated project file to include app icon * fix malformed package-lock.json * Jwoo/ios update autoversioning tool (#3676) * verstion updated * updated ios app version * updated versioning scheme for AdaptiveCards framework * Minor formatting change Updated the "Start the documentation site" heading to be at the same level as the rest of the headings * Removing instructions around explicit hexo install * [Security] Bump handlebars in /source/nodejs/adaptivecards (#3692) * Bump handlebars from 4.1.2 to 4.5.3 in /source/community/reactnative (#3694) * [UWP] Fix null dereference in Media code path (#3669) [UWP] Fix null dereference in Media code path * [UWP] Fix RendererRegistration error handling and fix inheritance issue with WholeItemsPanel (#3710) * updated the doc (#3706) * updated the doc * Updated specs * updated the description * Updated specs * updated the doc to correct wrong info * Updated specs * [Accessibility] Fixing some color contrast issues in the website (#3698) * Updating adaptivecards.io homepage's roadmap links to point to the updated productboard portal * Fixes #3577 ; Fixes #3576: * Fixing outlook.css since that is the style sheet that is being picked up by default when you hit the explorer page * automatic package.json changes * Fixing color syntax * Site readme updates (#3699) 1. Including PreRequisite section around repo bootstrap linking to root readme 2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps * added test to parse and render all sample cards (#3679) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [UWP] Remove image comparison from unit tests (#3724) * [UWP] Remove image comparison from unit tests * Code review feedback * Added MaxActions Limit Check (#3696) * Added MaxActions limit check and replaced multiple of GetActions() call That returns a structure by value * added UnitTesting and Warning * added UnitTesting and Warning fixed comments Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Jwoo/ios telephony update (#3680) * updating telephony detection for markdown link * undo uneccesary changes * updated RichTextBlockRenderer to detect Telephony link * updated sample card Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * [Android] Fix scrolling behaviour in multiline Input.Text (#3714) * Fix scrolling behaviour in multiline text input * Add test files Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Fix vertical content alignment for elements in root (#3716) * [SharedModel] Skip date/time tests outside of Pacific TZ (#3611) * [SharedModel] Skip date/time tests outside of Pacific TZ Fixes #3609 * Rename TEST_MODULE_INITIALIZE method * Remove TEST_MODULE_INITIALIZE altogether * Update macro name Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Create cortana-beta-light.json (#3729) New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light * Create cortana-beta-dark.json (#3730) Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> * [Android] Fix to have HH:mm in Input.Time elements (#3713) * Fix to have short time format * Change helper function * Add unit tets * Add sample test json * Remove unnecessary test file * Fixed #3741 (#3743) * Updated Cover FillMode Behavior (#3725) * Updated Cover FillMode Behavior * Revew Comments Addresssed * adding testing card * Updated file * Updated Handling of Preprocessed Text (#3727) * Updated preprocessed text handling * updated formatting * Added Accesibility Tags * updated accessibility Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated project file to expose media rendere (#3726) * iOS new layout scheme (#3687) * Updated iOS layout * removed wrapper on TextBlock and RichTextBlock renderers * updated layout views to use intrinsic contentsize * updated property value for layout vies * Added key value observation for hidden property to allow toggle visibility and the new layout change to work together * Updated views with toggle visibility to update its contentsize based on their visibility changes Updated padding priority for bleeding * restores to working project file * updated project file for xcode * updated for CR comments * Fixed for CR comments Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * updated the gradle property to handle error token (#3742) Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Add harder test to sample app * Revive UWP and Android with merged master Co-authored-by: Balaji Rajendran <Balaji.Rajendran01@gmail.com> Co-authored-by: Murali Krishnan <muralikrish91@users.noreply.github.com> Co-authored-by: Corina <14900841+corinagum@users.noreply.github.com> Co-authored-by: RebeccaAnne <rebecch@microsoft.com> Co-authored-by: Andrew Leader <aleader@microsoft.com> Co-authored-by: David Claux <dclaux@users.noreply.github.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Denis Fisenko <10715904+dfisenko@users.noreply.github.com> Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Henry <th.saravana@gmail.com> Co-authored-by: Patrick Goley <patrick.goley@gmail.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: Tom Laird-McConnell <tomlm@microsoft.com> Co-authored-by: nimercer <48482128+nimercer@users.noreply.github.com> Co-authored-by: IbrahimSulai <33604125+IbrahimSulai@users.noreply.github.com> Co-authored-by: Mikael Koskinen <mikael.koskinen@adafy.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt at trying to standardize PR descriptions via a template for guidance- both for maintainability/documentation purposes and ease of code review for reviewers. Also ensures any requirements w.r.t PR's are enforced esp. for some of the fabric bot policies that kick in for PR's.
Microsoft Reviewers: Open in CodeFlow