Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude bower.json from npm package #553

Closed
simonua opened this issue Dec 5, 2017 · 1 comment
Closed

Exclude bower.json from npm package #553

simonua opened this issue Dec 5, 2017 · 1 comment
Labels
bug
Milestone
1.0.15

Comments

@simonua
Copy link
Contributor

simonua commented Dec 5, 2017

bower.json is typically not needed in npm packages. Looking at the file, it doesn't seem to provide anything pertinent here either. Seeing that it's explicitly whitelisted in .npmignore, could you please allude to why it was included? If there's no good reason, I suggest to not include it.

https://github.com/Microsoft/ApplicationInsights-JS/blob/bc50233c00c3b3dc31c79abcae930ef5bf35e586/.npmignore#L8
@simonua simonua changed the title Exclude bower.json Exclude bower.json from npm package Dec 5, 2017
@KamilSzostak KamilSzostak added this to the 1.0.15 milestone Dec 6, 2017
KamilSzostak pushed a commit that referenced this issue Dec 6, 2017
Merge pull request #554 from simonua/master
9ae5496 
Exclude bower.json from being packaged #553
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0.15
Development

No branches or pull requests
2 participants
@simonua @KamilSzostak