Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude bower.json from npm package #553

Closed
simonua opened this issue Dec 5, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@simonua
Copy link
Contributor

commented Dec 5, 2017

bower.json is typically not needed in npm packages. Looking at the file, it doesn't seem to provide anything pertinent here either. Seeing that it's explicitly whitelisted in .npmignore, could you please allude to why it was included? If there's no good reason, I suggest to not include it.

https://github.com/Microsoft/ApplicationInsights-JS/blob/bc50233c00c3b3dc31c79abcae930ef5bf35e586/.npmignore#L8

@simonua simonua changed the title Exclude bower.json Exclude bower.json from npm package Dec 5, 2017

simonua added a commit to simonua/ApplicationInsights-JS that referenced this issue Dec 5, 2017

@KamilSzostak KamilSzostak added this to the 1.0.15 milestone Dec 6, 2017

@KamilSzostak KamilSzostak added the bug label Dec 6, 2017

KamilSzostak pushed a commit that referenced this issue Dec 6, 2017

Kamil Szostak
Merge pull request #554 from simonua/master
Exclude bower.json from being packaged #553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.