Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second environment variable to configure ikey #413

Merged
merged 3 commits into from Aug 21, 2017

Conversation

Projects
None yet
4 participants
@c-w
Copy link
Member

commented Aug 21, 2017

None of the other SDKs use the APPLICATION_INSIGHTS_IKEY environment variable to configure the instrumentation key for Application Insights and instead use APPINSIGHTS_INSTRUMENTATIONKEY.

For consistency with the other SDKs (e.g. Dot-Net or Node) this Java SDK should also support the more common environment variable name to avoid confusion for developers who have experience with the non-Java SDKs.

Add second environment variable to configure ikey
None of the other SDKs use the `APPLICATION_INSIGHTS_IKEY` environment
variable to configure the instrumentation key for Application Insights
and instead use `APPINSIGHTS_INSTRUMENTATIONKEY`.

For consistency with the other SDKs (e.g. Dot-Net https://aka.ms/n2ruy1
or Node https://aka.ms/v8r0pk) this Java SDK should also support the
more common environment variable name to avoid confusion for developers
who have experience with the non-Java SDKs.
@msftclas

This comment has been minimized.

Copy link

commented Aug 21, 2017

@c-w,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@SergeyKanzhelev
Copy link
Member

left a comment

Thank you!

@SergeyKanzhelev

This comment has been minimized.

Copy link
Member

commented Aug 21, 2017

BTW, can you please add an entry in CHANGELOG.md before merging?

@c-w

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2017

@SergeyKanzhelev and @Dmitry-Matveev Thanks for the super quick review.

As requested, I updated the changelog (see 83bb635).

NB: I don't have write access to this repo, so someone on your side will have to hit the merge button.

@Dmitry-Matveev Dmitry-Matveev merged commit 28dec6f into microsoft:master Aug 21, 2017

@c-w c-w deleted the c-w:feature/second-ikey-envvar branch Aug 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.