Add second environment variable to configure ikey#413
Merged
Dmitry-Matveev merged 3 commits intomicrosoft:masterfrom Aug 21, 2017
c-w:feature/second-ikey-envvar
Merged
Add second environment variable to configure ikey#413Dmitry-Matveev merged 3 commits intomicrosoft:masterfrom c-w:feature/second-ikey-envvar
Dmitry-Matveev merged 3 commits intomicrosoft:masterfrom
c-w:feature/second-ikey-envvar
Conversation
None of the other SDKs use the `APPLICATION_INSIGHTS_IKEY` environment variable to configure the instrumentation key for Application Insights and instead use `APPINSIGHTS_INSTRUMENTATIONKEY`. For consistency with the other SDKs (e.g. Dot-Net https://aka.ms/n2ruy1 or Node https://aka.ms/v8r0pk) this Java SDK should also support the more common environment variable name to avoid confusion for developers who have experience with the non-Java SDKs.
|
@c-w, |
Dmitry-Matveev
approved these changes
Aug 21, 2017
Contributor
|
BTW, can you please add an entry in |
Contributor
Author
|
@SergeyKanzhelev and @Dmitry-Matveev Thanks for the super quick review. As requested, I updated the changelog (see 83bb635). NB: I don't have write access to this repo, so someone on your side will have to hit the merge button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the other SDKs use the
APPLICATION_INSIGHTS_IKEYenvironment variable to configure the instrumentation key for Application Insights and instead useAPPINSIGHTS_INSTRUMENTATIONKEY.For consistency with the other SDKs (e.g. Dot-Net or Node) this Java SDK should also support the more common environment variable name to avoid confusion for developers who have experience with the non-Java SDKs.