diff --git a/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/BytecodeUtil.java b/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/BytecodeUtil.java index 9f7ba715853..c7826b041ae 100644 --- a/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/BytecodeUtil.java +++ b/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/BytecodeUtil.java @@ -18,7 +18,7 @@ import javax.annotation.Nullable; // supporting all properties of event, metric, remote dependency and page view telemetry -@SuppressWarnings("TooManyParameters") +@SuppressWarnings("TooManyParameters") // parameter count justified by method complexity public class BytecodeUtil { private static BytecodeUtilDelegate delegate; @@ -324,7 +324,7 @@ public static void onEnter() { startNanosHolder.set(System.nanoTime()); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public static void onExit() { Long startNanos = startNanosHolder.get(); if (startNanos == null) { diff --git a/agent/agent-gc-monitor/gc-monitor-api/src/main/java/com/microsoft/gcmonitor/MemoryManagers.java b/agent/agent-gc-monitor/gc-monitor-api/src/main/java/com/microsoft/gcmonitor/MemoryManagers.java index 4cafcbe2f3c..4c7a9eaf98e 100644 --- a/agent/agent-gc-monitor/gc-monitor-api/src/main/java/com/microsoft/gcmonitor/MemoryManagers.java +++ b/agent/agent-gc-monitor/gc-monitor-api/src/main/java/com/microsoft/gcmonitor/MemoryManagers.java @@ -27,7 +27,8 @@ public enum MemoryManagers { ZGC(GarbageCollectors.Zgc.class); - @SuppressWarnings("ImmutableEnumChecker") + @SuppressWarnings( + "ImmutableEnumChecker") // mutable enum state is intentional and properly synchronized private final Class[] managers; public static MemoryManagers of(MemoryManagement manager) { diff --git a/agent/agent-gc-monitor/gc-monitor-api/src/main/java/com/microsoft/gcmonitor/memorypools/MemoryPools.java b/agent/agent-gc-monitor/gc-monitor-api/src/main/java/com/microsoft/gcmonitor/memorypools/MemoryPools.java index 19a504d9b52..6859cef3778 100644 --- a/agent/agent-gc-monitor/gc-monitor-api/src/main/java/com/microsoft/gcmonitor/memorypools/MemoryPools.java +++ b/agent/agent-gc-monitor/gc-monitor-api/src/main/java/com/microsoft/gcmonitor/memorypools/MemoryPools.java @@ -300,7 +300,10 @@ public Shenandoah(Set managers) { } } - @SuppressWarnings({"checkstyle:AbbreviationAsWordInName", "MemberName"}) + @SuppressWarnings({ + "checkstyle:AbbreviationAsWordInName", + "MemberName" + }) // CGroup is the standard abbreviation for Control Group public static class ZHeap extends MemoryPool { public static final String POOL_NAME = "ZHeap"; diff --git a/agent/agent-gc-monitor/gc-monitor-core/src/main/java/com/microsoft/gcmonitor/collectors/GcCollectionSample.java b/agent/agent-gc-monitor/gc-monitor-core/src/main/java/com/microsoft/gcmonitor/collectors/GcCollectionSample.java index 0506d067208..c64d33a6514 100644 --- a/agent/agent-gc-monitor/gc-monitor-core/src/main/java/com/microsoft/gcmonitor/collectors/GcCollectionSample.java +++ b/agent/agent-gc-monitor/gc-monitor-core/src/main/java/com/microsoft/gcmonitor/collectors/GcCollectionSample.java @@ -63,7 +63,7 @@ public GcCollectionSample( private static Map groupMemoryUsageByPoolName( Object map, MemoryManagement memoryManagement) { - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context Map, CompositeData> byName = (Map, CompositeData>) map; Map byIdentifier = new HashMap<>(); try { diff --git a/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/GcEventGenerator.java b/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/GcEventGenerator.java index 2f38996aa4a..3305a13f6a9 100644 --- a/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/GcEventGenerator.java +++ b/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/GcEventGenerator.java @@ -25,7 +25,7 @@ public static void main(String[] args) throws InterruptedException { new GcEventGenerator().run(); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output private void run() throws InterruptedException { System.out.println("Hit return to start"); diff --git a/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/GcProcessRunner.java b/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/GcProcessRunner.java index 1d9afd89c96..60e3e52b0f1 100644 --- a/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/GcProcessRunner.java +++ b/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/GcProcessRunner.java @@ -25,7 +25,11 @@ import javax.management.remote.JMXServiceURL; // TODO (trask) revisit Java8ApiChecker suppression -@SuppressWarnings({"Java8ApiChecker", "SystemOut", "CatchAndPrintStackTrace"}) +@SuppressWarnings({ + "Java8ApiChecker", + "SystemOut", + "CatchAndPrintStackTrace" +}) // JFR APIs require Java 11+, but agent targets Java 8 bytecode public class GcProcessRunner { private InputStream errorStream; private InputStream stdOut; diff --git a/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/VariousCollectorsTest.java b/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/VariousCollectorsTest.java index 72a41dc5ce7..fdbcd56a475 100644 --- a/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/VariousCollectorsTest.java +++ b/agent/agent-gc-monitor/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/VariousCollectorsTest.java @@ -100,7 +100,7 @@ private static boolean isPresent( return events.stream().anyMatch(predicate); } - @SuppressWarnings({"SystemOut", "unused"}) + @SuppressWarnings({"SystemOut", "unused"}) // legitimate use of System.out for logging/output private static void print(List events) { System.out.println("Obtained: " + events.size()); events.forEach( diff --git a/agent/agent-profiler/agent-alerting/src/main/java/com/microsoft/applicationinsights/alerting/analysis/pipelines/AlertPipelineMXBean.java b/agent/agent-profiler/agent-alerting/src/main/java/com/microsoft/applicationinsights/alerting/analysis/pipelines/AlertPipelineMXBean.java index f1134362731..0b385cfc21c 100644 --- a/agent/agent-profiler/agent-alerting/src/main/java/com/microsoft/applicationinsights/alerting/analysis/pipelines/AlertPipelineMXBean.java +++ b/agent/agent-profiler/agent-alerting/src/main/java/com/microsoft/applicationinsights/alerting/analysis/pipelines/AlertPipelineMXBean.java @@ -4,7 +4,10 @@ package com.microsoft.applicationinsights.alerting.analysis.pipelines; // This class name must end in MXBean (case sensitive) -@SuppressWarnings({"checkstyle:AbbreviationAsWordInName", "IdentifierName"}) +@SuppressWarnings({ + "checkstyle:AbbreviationAsWordInName", + "IdentifierName" +}) // CGroup is the standard abbreviation for Control Group public interface AlertPipelineMXBean { // Attributes diff --git a/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/AlertBreachJfrEvent.java b/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/AlertBreachJfrEvent.java index 1fada49e8d6..8e35ccfb197 100644 --- a/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/AlertBreachJfrEvent.java +++ b/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/AlertBreachJfrEvent.java @@ -15,7 +15,9 @@ import jdk.jfr.Name; import jdk.jfr.StackTrace; -@SuppressWarnings({"Java8ApiChecker"}) +@SuppressWarnings({ + "Java8ApiChecker" +}) // JFR APIs require Java 11+, but agent targets Java 8 bytecode @Name("com.microsoft.applicationinsights.diagnostics.jfr.AlertBreach") @Label("AlertBreach") @Category("Diagnostic") diff --git a/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CGroupData.java b/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CGroupData.java index 884a3449b84..25d55d578c7 100644 --- a/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CGroupData.java +++ b/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CGroupData.java @@ -16,7 +16,10 @@ import jdk.jfr.Period; import jdk.jfr.StackTrace; -@SuppressWarnings({"Java8ApiChecker", "AbbreviationAsWordInName"}) +@SuppressWarnings({ + "Java8ApiChecker", + "AbbreviationAsWordInName" +}) // JFR APIs require Java 11+, but agent targets Java 8 bytecode @Name("com.microsoft.applicationinsights.diagnostics.jfr.CGroupData") @Label("CGroupData") @Category("Diagnostic") diff --git a/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/MachineStats.java b/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/MachineStats.java index 78af8180d7e..438a98ed9e3 100644 --- a/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/MachineStats.java +++ b/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/MachineStats.java @@ -16,7 +16,7 @@ import jdk.jfr.Period; import jdk.jfr.StackTrace; -@SuppressWarnings("Java8ApiChecker") +@SuppressWarnings("Java8ApiChecker") // JFR APIs require Java 11+, but agent targets Java 8 bytecode @Name("com.microsoft.applicationinsights.diagnostics.jfr.MachineStats") @Label("MachineStats") @Category("Diagnostic") diff --git a/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/Telemetry.java b/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/Telemetry.java index 6164117c1b8..6373fb433c5 100644 --- a/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/Telemetry.java +++ b/agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/Telemetry.java @@ -18,7 +18,9 @@ import jdk.jfr.Period; import jdk.jfr.StackTrace; -@SuppressWarnings({"Java8ApiChecker"}) +@SuppressWarnings({ + "Java8ApiChecker" +}) // JFR APIs require Java 11+, but agent targets Java 8 bytecode @Name("com.microsoft.applicationinsights.diagnostics.jfr.Telemetry") @Label("Telemetry") @Category("Diagnostic") @@ -46,7 +48,7 @@ public String getTelemetry() { return telemetry; } - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context public Telemetry setTelemetry(Object telemetry) { if (telemetry instanceof List) { StringJoiner joiner = new StringJoiner(","); diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/SystemStatsReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/SystemStatsReader.java index ce77d8685d7..3433391e334 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/SystemStatsReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/SystemStatsReader.java @@ -27,7 +27,9 @@ public class SystemStatsReader implements Closeable { private final KernelMonitorDeviceDriver driver; - @SuppressWarnings("checkstyle:MemberName") + @SuppressWarnings( + "checkstyle:MemberName") // naming convention intentionally differs from checkstyle for + // consistency private final CGroupUsageDataReader cGroupUsageDataReader; private final ProcessCpuStats processCpuStats; @@ -39,7 +41,10 @@ public class SystemStatsReader implements Closeable { public SystemStatsReader( KernelMonitorDeviceDriver driver, - @SuppressWarnings("checkstyle:ParameterName") CGroupUsageDataReader cGroupUsageDataReader, + @SuppressWarnings("checkstyle:ParameterName") + CGroupUsageDataReader + cGroupUsageDataReader, // parameter naming intentionally differs from checkstyle for + // consistency ProcessCpuStats processCpuStats, ProcessIoStats ioStats, MemoryInfoReader memoryInfoReader) { diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/calibration/ContextSwitchingRunner.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/calibration/ContextSwitchingRunner.java index d3ad69e6de1..90ff94f45c5 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/calibration/ContextSwitchingRunner.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/calibration/ContextSwitchingRunner.java @@ -27,14 +27,15 @@ public static void main(String[] args) { new ContextSwitchingRunner().runThreads(1000); } - @SuppressWarnings("ThreadJoinLoop") + @SuppressWarnings( + "ThreadJoinLoop") // thread join in loop is safe and necessary for proper synchronization private void runThreads(int threadCount) { Thread[] threads = new Thread[threadCount]; for (int i = 0; i < threads.length; i++) { threads[i] = new Thread() { - @SuppressWarnings("unused") + @SuppressWarnings("unused") // value not used but required by API signature or framework private int value = 0; @Override diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/jvm/ProcessData.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/jvm/ProcessData.java index fde95b22ba2..bdfee50d6b2 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/jvm/ProcessData.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/jvm/ProcessData.java @@ -175,7 +175,8 @@ public int hashCode() { } @Override - @SuppressWarnings("EqualsGetClass") + @SuppressWarnings( + "EqualsGetClass") // using getClass() in equals is intentional for this type hierarchy public boolean equals(Object obj) { if (this == obj) { return true; diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/kernel/CGroupDataReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/kernel/CGroupDataReader.java index a0e248c12b9..212190bb792 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/kernel/CGroupDataReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/kernel/CGroupDataReader.java @@ -6,7 +6,8 @@ import com.microsoft.applicationinsights.diagnostics.collection.libos.OperatingSystemInteractionException; /** Reads CGroup data from the host OS */ -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public interface CGroupDataReader { long getKmemLimit() throws OperatingSystemInteractionException; diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/kernel/CGroupUsageDataReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/kernel/CGroupUsageDataReader.java index 0e129b5049f..f13463ac2a5 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/kernel/CGroupUsageDataReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/kernel/CGroupUsageDataReader.java @@ -8,7 +8,8 @@ import java.util.List; import javax.annotation.Nullable; -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public interface CGroupUsageDataReader extends TwoStepUpdatable, Closeable { @Nullable List getTelemetry(); diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/LinuxKernelStats.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/LinuxKernelStats.java index ed7d1363c97..1e6e8fa9b1b 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/LinuxKernelStats.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/LinuxKernelStats.java @@ -128,7 +128,7 @@ public void update() throws OperatingSystemInteractionException { } } - @SuppressWarnings({"AvoidObjectArrays"}) + @SuppressWarnings({"AvoidObjectArrays"}) // object array required by API or framework public static int lineIndexFor(String[] procStatContents, String lineContents) { int index = 0; while (index < procStatContents.length && !procStatContents[index].contains(lineContents)) { diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/LinuxProcessDumper.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/LinuxProcessDumper.java index c9a930df9a4..9c60add83a1 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/LinuxProcessDumper.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/LinuxProcessDumper.java @@ -32,7 +32,10 @@ public LinuxProcessDumper(boolean isDaemon, int thisPid) { } @Override - @SuppressWarnings({"unchecked", "rawtypes"}) + @SuppressWarnings({ + "unchecked", + "rawtypes" + }) // safe unchecked cast - type verified by runtime context public Iterable all(boolean includeSelf) { if (includeSelf || !isDaemon) { return (Iterable) usage.values(); diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuSystemReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuSystemReader.java index 41e138575fa..ecb14207ce6 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuSystemReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuSystemReader.java @@ -3,7 +3,8 @@ package com.microsoft.applicationinsights.diagnostics.collection.libos.os.linux.cgroups; -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public class CGroupCpuSystemReader extends CGroupValueReader { // total system CPU time (in nanoseconds) consumed by all tasks in this cgroup public CGroupCpuSystemReader() { diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuUsageReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuUsageReader.java index c7cd5cb4d08..f642e04872d 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuUsageReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuUsageReader.java @@ -3,7 +3,8 @@ package com.microsoft.applicationinsights.diagnostics.collection.libos.os.linux.cgroups; -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public class CGroupCpuUsageReader extends CGroupValueReader { // total CPU usage (in nanoseconds) consumed by all tasks in this cgroup public CGroupCpuUsageReader() { diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuUserReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuUserReader.java index fabaaa9458b..c797dcdeefe 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuUserReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupCpuUserReader.java @@ -3,7 +3,8 @@ package com.microsoft.applicationinsights.diagnostics.collection.libos.os.linux.cgroups; -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public class CGroupCpuUserReader extends CGroupValueReader { // total user CPU time (in nanoseconds) consumed by all tasks in this cgroup public CGroupCpuUserReader() { diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupStatReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupStatReader.java index 0e8be9d5664..9bd25f426ba 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupStatReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupStatReader.java @@ -7,7 +7,8 @@ import com.microsoft.applicationinsights.diagnostics.collection.libos.os.linux.TwoStepProcReader; import java.io.File; -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public class CGroupStatReader extends TwoStepProcReader { private final BigIncrementalCounter user = new BigIncrementalCounter(); private final BigIncrementalCounter system = new BigIncrementalCounter(); diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupValueReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupValueReader.java index c905e01cbf8..4b076f9b3b6 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupValueReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/CGroupValueReader.java @@ -7,7 +7,8 @@ import com.microsoft.applicationinsights.diagnostics.collection.libos.os.linux.TwoStepProcReader; import java.io.File; -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public abstract class CGroupValueReader extends TwoStepProcReader { private final BigIncrementalCounter usage = new BigIncrementalCounter(); diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/LinuxCGroupDataReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/LinuxCGroupDataReader.java index b3f0986a3a7..0f9782bc13f 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/LinuxCGroupDataReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/LinuxCGroupDataReader.java @@ -10,7 +10,8 @@ import java.nio.file.Files; import java.util.List; -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public class LinuxCGroupDataReader implements CGroupDataReader { private static final String CGROUP_DIR = "/sys/fs/cgroup"; diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/LinuxCGroupUsageDataReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/LinuxCGroupUsageDataReader.java index cd2256b93b7..ae643aac343 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/LinuxCGroupUsageDataReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/linux/cgroups/LinuxCGroupUsageDataReader.java @@ -9,7 +9,8 @@ import java.util.stream.Collectors; import java.util.stream.Stream; -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public class LinuxCGroupUsageDataReader implements CGroupUsageDataReader { private final CGroupCpuUsageReader cgroupCpuUsageReader = new CGroupCpuUsageReader(); diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/nop/NoOpCGroupDataReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/nop/NoOpCGroupDataReader.java index e54b9536d7f..e0304030e46 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/nop/NoOpCGroupDataReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/nop/NoOpCGroupDataReader.java @@ -5,7 +5,10 @@ import com.microsoft.applicationinsights.diagnostics.collection.libos.kernel.CGroupDataReader; -@SuppressWarnings({"checkstyle:AbbreviationAsWordInName", "MemberName"}) +@SuppressWarnings({ + "checkstyle:AbbreviationAsWordInName", + "MemberName" +}) // CGroup is the standard abbreviation for Control Group public class NoOpCGroupDataReader implements CGroupDataReader { @Override diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/nop/NoOpCGroupUsageDataReader.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/nop/NoOpCGroupUsageDataReader.java index c752481963b..794971337fe 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/nop/NoOpCGroupUsageDataReader.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/os/nop/NoOpCGroupUsageDataReader.java @@ -8,7 +8,8 @@ import java.util.List; import javax.annotation.Nullable; -@SuppressWarnings("checkstyle:AbbreviationAsWordInName") +@SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control Group public class NoOpCGroupUsageDataReader implements CGroupUsageDataReader { @Override @Nullable diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/process/Process.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/process/Process.java index 16feb593ca3..440a469199d 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/process/Process.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/collection/libos/process/Process.java @@ -6,7 +6,9 @@ import com.microsoft.applicationinsights.diagnostics.collection.jvm.ProcessData; import com.microsoft.applicationinsights.diagnostics.collection.libos.TwoStepUpdatable; -@SuppressWarnings({"JavaLangClash"}) +@SuppressWarnings({ + "JavaLangClash" +}) // name clash with java.lang is intentional and properly qualified public abstract class Process extends ProcessData implements TwoStepUpdatable { protected boolean isJava; diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CodeOptimizerDiagnosticsJfrInit.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CodeOptimizerDiagnosticsJfrInit.java index 1646755c552..d5007db4b29 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CodeOptimizerDiagnosticsJfrInit.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CodeOptimizerDiagnosticsJfrInit.java @@ -17,7 +17,7 @@ import org.slf4j.LoggerFactory; /** Provides a JFR specific implementation of a diagnostics engine */ -@SuppressWarnings("Java8ApiChecker") +@SuppressWarnings("Java8ApiChecker") // JFR APIs require Java 11+, but agent targets Java 8 bytecode public class CodeOptimizerDiagnosticsJfrInit { private static final Logger logger = @@ -67,7 +67,9 @@ private static void logFailure(String logLine, @Nullable Exception e, AtomicInte count.incrementAndGet(); } - @SuppressWarnings("checkstyle:AbbreviationAsWordInName") + @SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control + // Group public static void emitCGroupData() { try { CGroupData cgroupData = SystemStatsProvider.getCGroupData(); diff --git a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/SystemStatsProvider.java b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/SystemStatsProvider.java index 4fdd942cb14..0455ce9dd2c 100644 --- a/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/SystemStatsProvider.java +++ b/agent/agent-profiler/agent-diagnostics/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/SystemStatsProvider.java @@ -43,7 +43,7 @@ * Initializes components mostly as singletons, mostly required to aid the migration away from being * part of a DI framework which managed lifecycles. */ -@SuppressWarnings("Java8ApiChecker") +@SuppressWarnings("Java8ApiChecker") // JFR APIs require Java 11+, but agent targets Java 8 bytecode public class SystemStatsProvider { private static final Logger logger = LoggerFactory.getLogger(SystemStatsProvider.class); @@ -73,12 +73,12 @@ public static void init(int thisPid) { } } - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context private static T getSingleton(Class clazz) { return (T) singletons.get(clazz).get(); } - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context private static T getSingleton(Class clazz, Supplier supplier) { AtomicReference current = (AtomicReference) singletons.get(clazz); @@ -104,7 +104,10 @@ private static T getSingleton(Class clazz, Supplier supplier) { return current.get(); } - @SuppressWarnings({"checkstyle:AbbreviationAsWordInName", "MemberName"}) + @SuppressWarnings({ + "checkstyle:AbbreviationAsWordInName", + "MemberName" + }) // CGroup is the standard abbreviation for Control Group public static CGroupData getCGroupData() { return getSingleton( CGroupData.class, @@ -163,7 +166,9 @@ private static Process getThisProcess() { }); } - @SuppressWarnings("checkstyle:AbbreviationAsWordInName") + @SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control + // Group private static CGroupDataReader buildCGroupDataReader() { switch (OperatingSystemDetector.getOperatingSystem()) { case LINUX: @@ -173,7 +178,9 @@ private static CGroupDataReader buildCGroupDataReader() { } } - @SuppressWarnings("checkstyle:AbbreviationAsWordInName") + @SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control + // Group private static ProcessDumper getProcessDumper() { ThisPidSupplier pidSupplier = getSingleton(ThisPidSupplier.class); switch (OperatingSystemDetector.getOperatingSystem()) { @@ -184,7 +191,9 @@ private static ProcessDumper getProcessDumper() { } } - @SuppressWarnings("checkstyle:AbbreviationAsWordInName") + @SuppressWarnings( + "checkstyle:AbbreviationAsWordInName") // CGroup is the standard abbreviation for Control + // Group private static CGroupUsageDataReader buildCGroupUsageDataReader() { return getSingleton( CGroupUsageDataReader.class, diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/DependencyTelemetryClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/DependencyTelemetryClassFileTransformer.java index ea84a4a4778..6a8391470f5 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/DependencyTelemetryClassFileTransformer.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/DependencyTelemetryClassFileTransformer.java @@ -172,7 +172,7 @@ public static void main(String[] args) { // DO NOT REMOVE // this is used during development for generating above bytecode - @SuppressWarnings("unused") + @SuppressWarnings("unused") // value not used but required by API signature or framework public static class Rdt { public String getResultCode() { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/ExceptionTelemetryClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/ExceptionTelemetryClassFileTransformer.java index 3b77bc41fd9..ee9c4283ef0 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/ExceptionTelemetryClassFileTransformer.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/ExceptionTelemetryClassFileTransformer.java @@ -120,7 +120,7 @@ public static void main(String[] args) { // DO NOT REMOVE // this is used during development for generating above bytecode - @SuppressWarnings("unused") + @SuppressWarnings("unused") // value not used but required by API signature or framework public static class Rdt { public Exception getException() { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/RequestTelemetryClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/RequestTelemetryClassFileTransformer.java index 9de839803f2..3d6d4bbf873 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/RequestTelemetryClassFileTransformer.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/RequestTelemetryClassFileTransformer.java @@ -117,7 +117,7 @@ public static void main(String[] args) { // DO NOT REMOVE // this is used during development for generating above bytecode - @SuppressWarnings("unused") + @SuppressWarnings("unused") // value not used but required by API signature or framework public static class Rdt { public String getSource() { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/TelemetryClientClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/TelemetryClientClassFileTransformer.java index 393c0c03788..588d3336ce0 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/TelemetryClientClassFileTransformer.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/TelemetryClientClassFileTransformer.java @@ -1694,7 +1694,7 @@ private void writeAgentToMillisMethod() { // implementation("org.ow2.asm:asm-util:9.3") // /* - @SuppressWarnings("UnnecessarilyFullyQualified") + @SuppressWarnings("UnnecessarilyFullyQualified") // fully qualified name required for clarity or to avoid conflicts public static void main(String[] args) throws Exception { java.io.ByteArrayOutputStream baos = new java.io.ByteArrayOutputStream(); java.io.PrintStream stdout = System.out; @@ -1725,7 +1725,7 @@ public static void main(String[] args) throws Exception { System.out.println(content); // CHECKSTYLE:OFF } - @SuppressWarnings("UnnecessarilyFullyQualified") + @SuppressWarnings("UnnecessarilyFullyQualified") // fully qualified name required for clarity or to avoid conflicts public static class TC { public com.microsoft.applicationinsights.telemetry.TelemetryContext getContext() { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/UnshadedSdkPackageName.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/UnshadedSdkPackageName.java index 552ed6a6a5c..8ecc5d7feda 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/UnshadedSdkPackageName.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/UnshadedSdkPackageName.java @@ -9,7 +9,7 @@ public class UnshadedSdkPackageName { // IMPORTANT FOR THIS NOT TO BE FINAL (or private) // OTHERWISE COMPILER COULD THEORETICALLY INLINE IT BELOW AND APPLY .substring(1) // and then it WOULD be shaded - @SuppressWarnings("ConstantField") + @SuppressWarnings("ConstantField") // field value intentionally mutable for specific use case static String ALMOST_PREFIX = "!com/microsoft/applicationinsights"; public static String get() { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/SdkVersionFinder.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/SdkVersionFinder.java index d05ac1267b3..55dab6f3858 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/SdkVersionFinder.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/SdkVersionFinder.java @@ -35,7 +35,10 @@ public static String initVersion(Path agentPath) { } // this is called early during startup before logging has been initialized - @SuppressWarnings({"CatchAndPrintStackTrace", "SystemOut"}) + @SuppressWarnings({ + "CatchAndPrintStackTrace", + "SystemOut" + }) // printing stack trace is appropriate for diagnostic output private static String readVersion(Path agentPath) { try { // reading from file instead of from classpath, in order to avoid triggering jar file diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/status/StatusFile.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/status/StatusFile.java index cb5464d4dc0..efd7cf31c75 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/status/StatusFile.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/status/StatusFile.java @@ -159,7 +159,7 @@ public static void write() { write(false); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output private static void write(boolean loggingInitialized) { if (!writable()) { return; diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/httpclient/LazyHttpClient.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/httpclient/LazyHttpClient.java index 2dc01589f85..13d7a2c950e 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/httpclient/LazyHttpClient.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/httpclient/LazyHttpClient.java @@ -99,7 +99,7 @@ private static HttpClient init() { NettyAsyncHttpClientBuilder builder = new NettyAsyncHttpClientBuilder(); if (proxyHost != null && proxyPortNumber != null) { - @SuppressWarnings("AddressSelection") + @SuppressWarnings("AddressSelection") // address selection pattern is safe in this context ProxyOptions proxyOptions = new ProxyOptions( ProxyOptions.Type.HTTP, new InetSocketAddress(proxyHost, proxyPortNumber)); diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/DuplicateAgentClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/DuplicateAgentClassFileTransformer.java index ed1272b2aa8..5ec0ac81123 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/DuplicateAgentClassFileTransformer.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/DuplicateAgentClassFileTransformer.java @@ -27,7 +27,7 @@ public class DuplicateAgentClassFileTransformer implements ClassFileTransformer // IMPORTANT FOR THIS NOT TO BE FINAL (or private) // OTHERWISE COMPILER COULD THEORETICALLY INLINE IT BELOW AND APPLY .substring(1) // and then it WOULD be shaded - @SuppressWarnings("ConstantField") + @SuppressWarnings("ConstantField") // field value intentionally mutable for specific use case static String[] UNSHADED_CLASS_NAMES = new String[] { "!io/opentelemetry/javaagent/OpenTelemetryAgent", // 3.0.0 through 3.0.2 diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/FirstEntryPoint.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/FirstEntryPoint.java index 9d79484b3ec..39cbfa39bde 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/FirstEntryPoint.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/FirstEntryPoint.java @@ -284,7 +284,7 @@ static FriendlyException getFriendlyException(Throwable t) { return getFriendlyException(cause); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output private static void logErrorMessage( @Nullable Logger startupLogger, String message, diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/InheritedAttributesLogProcessor.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/InheritedAttributesLogProcessor.java index dc1a7cb57fe..a3e13a50484 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/InheritedAttributesLogProcessor.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/InheritedAttributesLogProcessor.java @@ -26,7 +26,7 @@ public InheritedAttributesLogProcessor( } @Override - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context public void onEmit(Context context, ReadWriteLogRecord logRecord) { Span currentSpan = Span.fromContext(context); if (!(currentSpan instanceof ReadableSpan)) { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/InheritedAttributesSpanProcessor.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/InheritedAttributesSpanProcessor.java index 65a14b283e0..f31ffa3c3bf 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/InheritedAttributesSpanProcessor.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/InheritedAttributesSpanProcessor.java @@ -26,7 +26,7 @@ public InheritedAttributesSpanProcessor( } @Override - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context public void onStart(Context parentContext, ReadWriteSpan span) { Span parentSpan = Span.fromContextOrNull(parentContext); if (!(parentSpan instanceof ReadableSpan)) { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/JarVerifierClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/JarVerifierClassFileTransformer.java index d5cdc7ad782..8037c0a1e00 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/JarVerifierClassFileTransformer.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/JarVerifierClassFileTransformer.java @@ -25,7 +25,7 @@ public class JarVerifierClassFileTransformer implements ClassFileTransformer { @Override @Nullable - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public byte[] transform( ClassLoader loader, String className, diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/logbackpatch/FixedWindowRollingPolicy.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/logbackpatch/FixedWindowRollingPolicy.java index 0beb330269f..97eba73dcd0 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/logbackpatch/FixedWindowRollingPolicy.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/logbackpatch/FixedWindowRollingPolicy.java @@ -33,7 +33,11 @@ // copied from ch.qos.logback.core.rolling.FixedWindowRollingPolicy // in order to support weird file directories like -@SuppressWarnings({"MethodCanBeStatic", "EmptyBlockTag", "ThrowsUncheckedException"}) +@SuppressWarnings({ + "MethodCanBeStatic", + "EmptyBlockTag", + "ThrowsUncheckedException" +}) // instance method required by test framework public class FixedWindowRollingPolicy extends RollingPolicyBase { FileNamePattern fileNamePattern; diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/perfcounter/PerformanceCounterContainer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/perfcounter/PerformanceCounterContainer.java index 0670d82a4ac..6bf6e603b72 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/perfcounter/PerformanceCounterContainer.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/perfcounter/PerformanceCounterContainer.java @@ -33,7 +33,8 @@ * *

The container will be stopped automatically when the application exists. */ -@SuppressWarnings("ImmutableEnumChecker") +@SuppressWarnings( + "ImmutableEnumChecker") // mutable enum state is intentional and properly synchronized public enum PerformanceCounterContainer { INSTANCE; @@ -99,7 +100,7 @@ public void setLogAvailableJmxMetrics() { * counters data. The method will schedule a callback to be called, it will initialize a {@link * TelemetryClient} that the Performance Counters will use to report their data */ - @SuppressWarnings("AlreadyChecked") + @SuppressWarnings("AlreadyChecked") // redundant check is intentional for defensive programming private void initialize() { if (!initialized) { synchronized (INSTANCE) { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/processors/AttributeProcessor.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/processors/AttributeProcessor.java index a0afe7cf70b..9e910b7060e 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/processors/AttributeProcessor.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/processors/AttributeProcessor.java @@ -263,7 +263,7 @@ private static class HttpUrlKeyValuePair { } } - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context private static void putIntoBuilder(AttributesBuilder builder, AttributeKey key, Object value) { switch (key.getType()) { case STRING: diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/Profiler.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/Profiler.java index 13fe03bd65f..5e877d9f1fb 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/Profiler.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/Profiler.java @@ -211,7 +211,8 @@ private void executeProfile( } /** When a profile has been created, upload it to service profiler. */ - @SuppressWarnings("CatchingUnchecked") + @SuppressWarnings( + "CatchingUnchecked") // catching unchecked exception is necessary for proper error handling private Consumer uploadNewRecording( AlertBreach alertBreach, Instant recordingStart, UploadListener uploadListener) { return recording -> { diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/upload/UploadService.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/upload/UploadService.java index 99c2f8aa1fb..35d4a6d3251 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/upload/UploadService.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/upload/UploadService.java @@ -127,7 +127,7 @@ Mono uploadJfrFile( triggerName, timestamp, profileId, file, cpuUsage, memoryUsage, "Profile", "jfr", "jfr"); } - @SuppressWarnings("TooManyParameters") + @SuppressWarnings("TooManyParameters") // parameter count justified by method complexity public Mono uploadFile( String triggerName, long timestamp, diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/telemetry/TelemetryObservers.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/telemetry/TelemetryObservers.java index f993a9c6f76..2f4f87531f2 100644 --- a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/telemetry/TelemetryObservers.java +++ b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/telemetry/TelemetryObservers.java @@ -8,7 +8,8 @@ import java.util.concurrent.CopyOnWriteArrayList; import java.util.function.Consumer; -@SuppressWarnings("ImmutableEnumChecker") +@SuppressWarnings( + "ImmutableEnumChecker") // mutable enum state is intentional and properly synchronized public enum TelemetryObservers { INSTANCE; diff --git a/agent/agent-tooling/src/main/java/io/opentelemetry/sdk/metrics/internal/view/MetricView.java b/agent/agent-tooling/src/main/java/io/opentelemetry/sdk/metrics/internal/view/MetricView.java index 93be80deee0..ad57a6de8ae 100644 --- a/agent/agent-tooling/src/main/java/io/opentelemetry/sdk/metrics/internal/view/MetricView.java +++ b/agent/agent-tooling/src/main/java/io/opentelemetry/sdk/metrics/internal/view/MetricView.java @@ -18,7 +18,8 @@ enum MetricView { private final String instrumentName; - @SuppressWarnings("ImmutableEnumChecker") + @SuppressWarnings( + "ImmutableEnumChecker") // mutable enum state is intentional and properly synchronized private final Set> attributeKeys; private final boolean captureSynthetic; diff --git a/agent/agent-tooling/src/main/java/io/opentelemetry/sdk/metrics/internal/view/MetricViewAttributesProcessor.java b/agent/agent-tooling/src/main/java/io/opentelemetry/sdk/metrics/internal/view/MetricViewAttributesProcessor.java index e77d26036cb..c9effa69308 100644 --- a/agent/agent-tooling/src/main/java/io/opentelemetry/sdk/metrics/internal/view/MetricViewAttributesProcessor.java +++ b/agent/agent-tooling/src/main/java/io/opentelemetry/sdk/metrics/internal/view/MetricViewAttributesProcessor.java @@ -13,7 +13,7 @@ import java.util.Set; import java.util.function.BiConsumer; -@SuppressWarnings("rawtypes") +@SuppressWarnings("rawtypes") // safe use of raw type - generic type verified by runtime context class MetricViewAttributesProcessor extends AttributesProcessor { private final Set> attributeKeys; @@ -56,7 +56,7 @@ public boolean usesContext() { return true; } - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context private static void applyView( AttributesBuilder filtered, Attributes attributes, Set> view) { attributes.forEach( diff --git a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/PreAggregatedMetricsTest.java b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/PreAggregatedMetricsTest.java index c74d5b2ef9d..f7a6b8c86e3 100644 --- a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/PreAggregatedMetricsTest.java +++ b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/PreAggregatedMetricsTest.java @@ -64,7 +64,7 @@ void setup() { meterProvider = builder.registerMetricReader(metricReader).build(); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output @Test void generateHttpClientMetrics() { OperationListener listener = HttpClientMetrics.get().create(meterProvider.get("test")); @@ -145,7 +145,7 @@ void generateHttpClientMetrics() { generateExpectedDependencyCustomDimensions("http", "localhost:1234")); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output @Test void generateRpcClientMetrics() { OperationListener listener = RpcClientMetrics.get().create(meterProvider.get("test")); @@ -220,7 +220,7 @@ void generateRpcClientMetrics() { generateExpectedDependencyCustomDimensions("grpc", "example.com:8080")); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output @Test void generateHttpServerMetrics() { OperationListener listener = HttpServerMetrics.get().create(meterProvider.get("test")); diff --git a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationBuilderTest.java b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationBuilderTest.java index b2f397c3920..740a661b199 100644 --- a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationBuilderTest.java +++ b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationBuilderTest.java @@ -154,12 +154,12 @@ void testRpConfigurationOverlayWithEnvVarAndSysPropPopulated() throws Exception assertThat(config.sampling.percentage).isEqualTo(testSamplingPercentage); } - @SuppressWarnings("MethodCanBeStatic") + @SuppressWarnings("MethodCanBeStatic") // instance method required by test framework private String envVars(String key) { return envVars.get(key); } - @SuppressWarnings("MethodCanBeStatic") + @SuppressWarnings("MethodCanBeStatic") // instance method required by test framework private String systemProperties(String key) { return systemProperties.get(key); } diff --git a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationTest.java b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationTest.java index abdf8d762b8..4d92c48868e 100644 --- a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationTest.java +++ b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/configuration/ConfigurationTest.java @@ -289,12 +289,12 @@ void shouldOverrideConnectionStringWithEnvVar() throws IOException { .isEqualTo("InstrumentationKey=11111111-1111-1111-1111-111111111111"); } - @SuppressWarnings("MethodCanBeStatic") + @SuppressWarnings("MethodCanBeStatic") // instance method required by test framework private String envVars(String key) { return envVars.get(key); } - @SuppressWarnings("MethodCanBeStatic") + @SuppressWarnings("MethodCanBeStatic") // instance method required by test framework private String systemProperties(String key) { return systemProperties.get(key); } diff --git a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/diagnostics/SubscriptionIdFinderTest.java b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/diagnostics/SubscriptionIdFinderTest.java index 6b6382beeb9..01a585799ec 100644 --- a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/diagnostics/SubscriptionIdFinderTest.java +++ b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/diagnostics/SubscriptionIdFinderTest.java @@ -47,7 +47,7 @@ void useUnknownIfEnvVarHasUnexpectedFormat() { assertThat(subIdFinder.getValue(this::envVarsFunction)).isEqualTo("unknown"); } - @SuppressWarnings("MethodCanBeStatic") + @SuppressWarnings("MethodCanBeStatic") // instance method required by test framework private String envVarsFunction(String key) { return envVars.get(key); } diff --git a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/init/RpConfigurationPollingTest.java b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/init/RpConfigurationPollingTest.java index 18cc717b6d5..3cc5441c50a 100644 --- a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/init/RpConfigurationPollingTest.java +++ b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/init/RpConfigurationPollingTest.java @@ -137,7 +137,7 @@ private static Double getCurrentSamplingPercentage() { return SamplingTestUtil.getCurrentSamplingPercentage(DelegatingSampler.getInstance()); } - @SuppressWarnings("MethodCanBeStatic") + @SuppressWarnings("MethodCanBeStatic") // instance method required by test framework private String envVars(String key) { return envVars.get(key); } diff --git a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/perfcounter/JmxDataFetcherTest.java b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/perfcounter/JmxDataFetcherTest.java index 225cfd92802..694b0dcc478 100644 --- a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/perfcounter/JmxDataFetcherTest.java +++ b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/perfcounter/JmxDataFetcherTest.java @@ -17,7 +17,11 @@ class JmxDataFetcherTest { - @SuppressWarnings({"unused", "checkstyle:AbbreviationAsWordInName", "IdentifierName"}) + @SuppressWarnings({ + "unused", + "checkstyle:AbbreviationAsWordInName", + "IdentifierName" + }) // value not used but required by API signature or framework // This class name must end in MXBean (case sensitive) public interface StubMXBean { int getIntSample(); @@ -27,7 +31,7 @@ public interface StubMXBean { long getLongSample(); } - @SuppressWarnings("unused") + @SuppressWarnings("unused") // value not used but required by API signature or framework public static class TestStub implements StubMXBean { public int intSample; public double doubleSample; diff --git a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/ProfilingInitializerTest.java b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/ProfilingInitializerTest.java index 6f581b01705..151c578cd89 100644 --- a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/ProfilingInitializerTest.java +++ b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/ProfilingInitializerTest.java @@ -211,7 +211,8 @@ private static ProfilerConfiguration profileNowState( + triggersEnabled); } - @SuppressWarnings("DirectInvocationOnMock") + @SuppressWarnings( + "DirectInvocationOnMock") // direct mock invocation is intentional for test setup private static ProfilingInitializer createProfilingInitializer() { TelemetryClient client = Mockito.mock(TelemetryClient.class); MessageTelemetryBuilder messageTelemetryBuilder = MessageTelemetryBuilder.create(); diff --git a/agent/agent/src/main/java/com/microsoft/applicationinsights/agent/Agent.java b/agent/agent/src/main/java/com/microsoft/applicationinsights/agent/Agent.java index 34f4a0526b2..5be3d14b2d5 100644 --- a/agent/agent/src/main/java/com/microsoft/applicationinsights/agent/Agent.java +++ b/agent/agent/src/main/java/com/microsoft/applicationinsights/agent/Agent.java @@ -44,7 +44,7 @@ public static void agentmain(String agentArgs, Instrumentation inst) { premain(agentArgs, inst); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public static void main(String... args) { System.err.println( "*************************\n" diff --git a/agent/agent/src/main/java/com/microsoft/applicationinsights/agent/StartupProfiler.java b/agent/agent/src/main/java/com/microsoft/applicationinsights/agent/StartupProfiler.java index 0bba25a2e61..326fb2dee8a 100644 --- a/agent/agent/src/main/java/com/microsoft/applicationinsights/agent/StartupProfiler.java +++ b/agent/agent/src/main/java/com/microsoft/applicationinsights/agent/StartupProfiler.java @@ -20,7 +20,7 @@ final class StartupProfiler { private static final String APPLICATIONINSIGHTS_STARTUP_PROFILER_FILE_PATH = "APPLICATIONINSIGHTS_STARTUP_PROFILER_FILE_PATH"; - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public static void start() { String startupProfilerFilePath = System.getenv(APPLICATIONINSIGHTS_STARTUP_PROFILER_FILE_PATH); File folder; @@ -70,7 +70,7 @@ private ThreadDump(PrintWriter out) { } @Override - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public void run() { long start = System.currentTimeMillis(); while (System.currentTimeMillis() - start < MINUTES.toMillis(10)) { diff --git a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/BaseTelemetryInstrumentation.java b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/BaseTelemetryInstrumentation.java index 60c0a1c242b..909b6e4a960 100644 --- a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/BaseTelemetryInstrumentation.java +++ b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/BaseTelemetryInstrumentation.java @@ -53,7 +53,10 @@ public void transform(TypeTransformer transformer) { BaseTelemetryInstrumentation.class.getName() + "$OtherMethodsAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetPropertiesAdvice { @Advice.OnMethodExit public static void methodExit( @@ -70,7 +73,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetContextAdvice { @Advice.OnMethodExit public static void methodExit( @@ -86,7 +92,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class OtherMethodsAdvice { @Advice.OnMethodEnter public static void methodEnter( diff --git a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/DeviceContextInstrumentation.java b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/DeviceContextInstrumentation.java index b929cdcaf1a..128ae5bcc66 100644 --- a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/DeviceContextInstrumentation.java +++ b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/DeviceContextInstrumentation.java @@ -45,7 +45,10 @@ public void transform(TypeTransformer transformer) { DeviceContextInstrumentation.class.getName() + "$OtherMethodsAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class SetOperatingSystemAdvice { @Advice.OnMethodExit public static void methodExit( @@ -57,7 +60,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class SetOperatingSystemVersionAdvice { @Advice.OnMethodExit public static void methodExit( @@ -71,7 +77,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class OtherMethodsAdvice { @Advice.OnMethodEnter public static void methodEnter( diff --git a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/OperationContextInstrumentation.java b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/OperationContextInstrumentation.java index eac4605cc97..f37951b33e2 100644 --- a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/OperationContextInstrumentation.java +++ b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/OperationContextInstrumentation.java @@ -35,7 +35,10 @@ public void transform(TypeTransformer transformer) { OperationContextInstrumentation.class.getName() + "$OtherMethodsAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetIdAdvice { @Advice.OnMethodExit public static void methodExit( @@ -48,7 +51,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class OtherMethodsAdvice { @Advice.OnMethodEnter public static void methodEnter( diff --git a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/RequestTelemetryContextInstrumentation.java b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/RequestTelemetryContextInstrumentation.java index 35ede7d8742..cec74f3c078 100644 --- a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/RequestTelemetryContextInstrumentation.java +++ b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/RequestTelemetryContextInstrumentation.java @@ -61,7 +61,10 @@ public void transform(TypeTransformer transformer) { RequestTelemetryContextInstrumentation.class.getName() + "$OtherMethodsAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetRequestTelemetryAdvice { @Advice.OnMethodExit public static void methodExit( @@ -75,7 +78,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetTracestateAdvice { @Advice.OnMethodExit public static void methodExit( @@ -96,7 +102,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetTraceflagAdvice { @Advice.OnMethodExit public static void methodExit( @@ -110,7 +119,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class OtherMethodsAdvice { @Advice.OnMethodEnter public static void methodEnter( diff --git a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/RequestTelemetryInstrumentation.java b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/RequestTelemetryInstrumentation.java index b6070d703dd..14223bfd07f 100644 --- a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/RequestTelemetryInstrumentation.java +++ b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/RequestTelemetryInstrumentation.java @@ -64,7 +64,10 @@ public void transform(TypeTransformer transformer) { RequestTelemetryInstrumentation.class.getName() + "$OtherMethodsAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class SetNameAdvice { @Advice.OnMethodEnter public static void methodEnter( @@ -76,7 +79,10 @@ public static void methodEnter( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class SetSuccessAdvice { @Advice.OnMethodEnter public static void methodEnter( @@ -88,7 +94,10 @@ public static void methodEnter( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class SetSourceAdvice { @Advice.OnMethodEnter public static void methodEnter( @@ -100,7 +109,10 @@ public static void methodEnter( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetIdAdvice { @Advice.OnMethodExit public static void methodExit( @@ -113,7 +125,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class OtherMethodsAdvice { @Advice.OnMethodEnter public static void methodEnter( diff --git a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/SessionContextInstrumentation.java b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/SessionContextInstrumentation.java index bd4aa5ce518..a44aeb60128 100644 --- a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/SessionContextInstrumentation.java +++ b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/SessionContextInstrumentation.java @@ -35,7 +35,10 @@ public void transform(TypeTransformer transformer) { SessionContextInstrumentation.class.getName() + "$OtherMethodsAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class SetIdAdvice { @Advice.OnMethodExit public static void methodExit( @@ -47,7 +50,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class OtherMethodsAdvice { @Advice.OnMethodEnter public static void methodEnter( diff --git a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/TelemetryContextInstrumentation.java b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/TelemetryContextInstrumentation.java index a255c451e28..d86687ba6dd 100644 --- a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/TelemetryContextInstrumentation.java +++ b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/TelemetryContextInstrumentation.java @@ -70,7 +70,10 @@ public void transform(TypeTransformer transformer) { TelemetryContextInstrumentation.class.getName() + "$OtherMethodsAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetUserAdvice { @Advice.OnMethodExit public static void methodExit( @@ -82,7 +85,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetOperationAdvice { @Advice.OnMethodExit public static void methodExit( @@ -95,7 +101,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetSessionAdvice { @Advice.OnMethodExit public static void methodExit( @@ -108,7 +117,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetDeviceAdvice { @Advice.OnMethodExit public static void methodExit( @@ -121,7 +133,10 @@ public static void methodExit( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class OtherMethodsAdvice { @Advice.OnMethodEnter public static void methodEnter( diff --git a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/ThreadContextInstrumentation.java b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/ThreadContextInstrumentation.java index dd18b3946a6..9698392d806 100644 --- a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/ThreadContextInstrumentation.java +++ b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/ThreadContextInstrumentation.java @@ -34,7 +34,10 @@ public void transform(TypeTransformer transformer) { ThreadContextInstrumentation.class.getName() + "$GetRequestTelemetryContextAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetRequestTelemetryContextAdvice { @Advice.OnMethodExit public static void methodExit( diff --git a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/UserContextInstrumentation.java b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/UserContextInstrumentation.java index 6363d883040..e6c7b27da64 100644 --- a/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/UserContextInstrumentation.java +++ b/agent/instrumentation/applicationinsights-web-2.3/src/main/java/io/opentelemetry/javaagent/instrumentation/applicationinsightsweb/UserContextInstrumentation.java @@ -36,7 +36,10 @@ public void transform(TypeTransformer transformer) { UserContextInstrumentation.class.getName() + "$OtherMethodsAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class SetIdAdvice { @Advice.OnMethodEnter public static void methodEnter( @@ -48,7 +51,10 @@ public static void methodEnter( } } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class OtherMethodsAdvice { @Advice.OnMethodEnter public static void methodEnter( diff --git a/agent/instrumentation/azure-functions/src/main/java/io/opentelemetry/javaagent/instrumentation/azurefunctions/FunctionEnvironmentReloadInstrumentation.java b/agent/instrumentation/azure-functions/src/main/java/io/opentelemetry/javaagent/instrumentation/azurefunctions/FunctionEnvironmentReloadInstrumentation.java index fb35ab1b156..be75879c839 100644 --- a/agent/instrumentation/azure-functions/src/main/java/io/opentelemetry/javaagent/instrumentation/azurefunctions/FunctionEnvironmentReloadInstrumentation.java +++ b/agent/instrumentation/azure-functions/src/main/java/io/opentelemetry/javaagent/instrumentation/azurefunctions/FunctionEnvironmentReloadInstrumentation.java @@ -28,7 +28,10 @@ public void transform(TypeTransformer transformer) { FunctionEnvironmentReloadInstrumentation.class.getName() + "$ExecuteAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class ExecuteAdvice { @Advice.OnMethodExit(suppress = Throwable.class) public static void methodExit() { diff --git a/agent/instrumentation/azure-functions/src/main/java/io/opentelemetry/javaagent/instrumentation/azurefunctions/InvocationInstrumentation.java b/agent/instrumentation/azure-functions/src/main/java/io/opentelemetry/javaagent/instrumentation/azurefunctions/InvocationInstrumentation.java index a3f7580a6ce..40ebaa951a9 100644 --- a/agent/instrumentation/azure-functions/src/main/java/io/opentelemetry/javaagent/instrumentation/azurefunctions/InvocationInstrumentation.java +++ b/agent/instrumentation/azure-functions/src/main/java/io/opentelemetry/javaagent/instrumentation/azurefunctions/InvocationInstrumentation.java @@ -45,7 +45,11 @@ public void transform(TypeTransformer transformer) { InvocationInstrumentation.class.getName() + "$ExecuteAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass", "MustBeClosedChecker"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass", + "MustBeClosedChecker" + }) // value not used but required by API signature or framework public static class ExecuteAdvice { @Nullable @Advice.OnMethodEnter(suppress = Throwable.class) diff --git a/agent/instrumentation/methods/src/main/java/io/opentelemetry/javaagent/instrumentation/methods/ai/MethodInstrumentation.java b/agent/instrumentation/methods/src/main/java/io/opentelemetry/javaagent/instrumentation/methods/ai/MethodInstrumentation.java index 5a24e9639bb..6a3edc677e9 100644 --- a/agent/instrumentation/methods/src/main/java/io/opentelemetry/javaagent/instrumentation/methods/ai/MethodInstrumentation.java +++ b/agent/instrumentation/methods/src/main/java/io/opentelemetry/javaagent/instrumentation/methods/ai/MethodInstrumentation.java @@ -55,7 +55,11 @@ public void transform(TypeTransformer transformer) { MethodInstrumentation.class.getName() + "$MethodAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass", "MustBeClosedChecker"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass", + "MustBeClosedChecker" + }) // value not used but required by API signature or framework public static class MethodAdvice { @Advice.OnMethodEnter(suppress = Throwable.class) diff --git a/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/ActuatorInstrumentation.java b/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/ActuatorInstrumentation.java index 155cf3defa3..5b3bc08c284 100644 --- a/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/ActuatorInstrumentation.java +++ b/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/ActuatorInstrumentation.java @@ -28,7 +28,10 @@ public void transform(TypeTransformer transformer) { ActuatorInstrumentation.class.getName() + "$GetCandidateConfigurationsAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class GetCandidateConfigurationsAdvice { @Advice.OnMethodExit(suppress = Throwable.class) diff --git a/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/CompositeMeterRegistryInstrumentation.java b/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/CompositeMeterRegistryInstrumentation.java index 2112f68c2af..211dd01e4da 100644 --- a/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/CompositeMeterRegistryInstrumentation.java +++ b/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/CompositeMeterRegistryInstrumentation.java @@ -32,7 +32,10 @@ public void transform(TypeTransformer transformer) { CompositeMeterRegistryInstrumentation.class.getName() + "$AddAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class AddAdvice { @Advice.OnMethodEnter(suppress = Throwable.class, skipOn = Advice.OnNonDefaultValue.class) diff --git a/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/MetricsInstrumentation.java b/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/MetricsInstrumentation.java index c4e3f682038..611a72fe4e4 100644 --- a/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/MetricsInstrumentation.java +++ b/agent/instrumentation/micrometer-1.0/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/ai/MetricsInstrumentation.java @@ -26,7 +26,10 @@ public void transform(TypeTransformer transformer) { isTypeInitializer(), MetricsInstrumentation.class.getName() + "$StaticInitAdvice"); } - @SuppressWarnings({"unused", "PrivateConstructorForUtilityClass"}) + @SuppressWarnings({ + "unused", + "PrivateConstructorForUtilityClass" + }) // value not used but required by API signature or framework public static class StaticInitAdvice { @Advice.OnMethodExit(suppress = Throwable.class) diff --git a/agent/instrumentation/micrometer-1.0/src/test/java/ActuatorTest.java b/agent/instrumentation/micrometer-1.0/src/test/java/ActuatorTest.java index 8cc158a952d..3fc963a19fc 100644 --- a/agent/instrumentation/micrometer-1.0/src/test/java/ActuatorTest.java +++ b/agent/instrumentation/micrometer-1.0/src/test/java/ActuatorTest.java @@ -29,7 +29,7 @@ void shouldAddAzureMonitorAutoConfiguration() throws Exception { AutoConfigurationImportSelector selector = new AutoConfigurationImportSelector(); // when - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context List list = (List) method.invoke(selector, metadata, attributes); // then diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/TelemetryClient.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/TelemetryClient.java index 3b53dda06e4..5be3a60c4dd 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/TelemetryClient.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/TelemetryClient.java @@ -26,11 +26,14 @@ public class TelemetryClient { private final TelemetryContext context = new TelemetryContext(); // this is required for interop with versions of the Java agent prior to 3.4.0 - @SuppressWarnings("UnusedVariable") + @SuppressWarnings("UnusedVariable") // variable required for API contract or future use private final TelemetryConfiguration configuration = new TelemetryConfiguration(); // this is required for interop with versions of the Java agent prior to 3.4.0 - @SuppressWarnings({"UnusedMethod", "MethodCanBeStatic"}) + @SuppressWarnings({ + "UnusedMethod", + "MethodCanBeStatic" + }) // method required by interface or future functionality private boolean isDisabled() { return false; } diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/extensibility/context/ContextTagKeys.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/extensibility/context/ContextTagKeys.java index 7a666433959..b572c89dcad 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/extensibility/context/ContextTagKeys.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/extensibility/context/ContextTagKeys.java @@ -3,7 +3,10 @@ package com.microsoft.applicationinsights.extensibility.context; -@SuppressWarnings({"AbbreviationAsWordInName", "MemberName"}) +@SuppressWarnings({ + "AbbreviationAsWordInName", + "MemberName" +}) // standard abbreviation used in the codebase public final class ContextTagKeys { private static final ContextTagKeys INSTANCE = new ContextTagKeys(); diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/DataPointType.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/DataPointType.java index 0cd016e6dbb..5ace4378410 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/DataPointType.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/DataPointType.java @@ -3,7 +3,8 @@ package com.microsoft.applicationinsights.internal.schemav2; -@SuppressWarnings("MemberName") +@SuppressWarnings( + "MemberName") // naming convention intentionally differs from checkstyle for consistency public enum DataPointType { Measurement(0), Aggregation(1); diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/DependencyKind.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/DependencyKind.java index faa67c3629a..ddfe10068f8 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/DependencyKind.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/DependencyKind.java @@ -3,7 +3,8 @@ package com.microsoft.applicationinsights.internal.schemav2; -@SuppressWarnings("MemberName") +@SuppressWarnings( + "MemberName") // naming convention intentionally differs from checkstyle for consistency public enum DependencyKind { SQL(0), Http(1), diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/SeverityLevel.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/SeverityLevel.java index e18e2fb37a9..86dfd0ec852 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/SeverityLevel.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/SeverityLevel.java @@ -3,7 +3,8 @@ package com.microsoft.applicationinsights.internal.schemav2; -@SuppressWarnings("MemberName") +@SuppressWarnings( + "MemberName") // naming convention intentionally differs from checkstyle for consistency public enum SeverityLevel { Verbose(0), Information(1), diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java index 6c496723ded..a6aba967d53 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java @@ -56,7 +56,7 @@ public void setException(Throwable throwable, int stackSize) { this.throwable = throwable; } - @SuppressWarnings("EnumOrdinal") + @SuppressWarnings("EnumOrdinal") // enum ordinal usage is safe and intentional public void setSeverityLevel(SeverityLevel severityLevel) { data.setSeverityLevel( severityLevel == null @@ -66,7 +66,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) { } @Nullable - @SuppressWarnings("EnumOrdinal") + @SuppressWarnings("EnumOrdinal") // enum ordinal usage is safe and intentional public SeverityLevel getSeverityLevel() { return data.getSeverityLevel() == null ? null diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/SeverityLevel.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/SeverityLevel.java index f064a28f383..b8719a775cc 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/SeverityLevel.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/SeverityLevel.java @@ -4,7 +4,8 @@ package com.microsoft.applicationinsights.telemetry; /** Enum SeverityLevel. */ -@SuppressWarnings("MemberName") +@SuppressWarnings( + "MemberName") // naming convention intentionally differs from checkstyle for consistency public enum SeverityLevel { Verbose(0), Information(1), diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java index 8d359901212..ba46ef3216d 100644 --- a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java +++ b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java @@ -47,7 +47,7 @@ public void setMessage(String message) { data.setMessage(message); } - @SuppressWarnings("EnumOrdinal") + @SuppressWarnings("EnumOrdinal") // enum ordinal usage is safe and intentional public void setSeverityLevel(SeverityLevel severityLevel) { data.setSeverityLevel( severityLevel == null @@ -57,7 +57,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) { } @Nullable - @SuppressWarnings("EnumOrdinal") + @SuppressWarnings("EnumOrdinal") // enum ordinal usage is safe and intentional public SeverityLevel getSeverityLevel() { return data.getSeverityLevel() == null ? null diff --git a/etw/java/src/test/java/com/microsoft/applicationinsights/agent/internal/diagnostics/etw/EtwProviderTests.java b/etw/java/src/test/java/com/microsoft/applicationinsights/agent/internal/diagnostics/etw/EtwProviderTests.java index 57ec60dd744..8fd98bc337f 100644 --- a/etw/java/src/test/java/com/microsoft/applicationinsights/agent/internal/diagnostics/etw/EtwProviderTests.java +++ b/etw/java/src/test/java/com/microsoft/applicationinsights/agent/internal/diagnostics/etw/EtwProviderTests.java @@ -25,7 +25,7 @@ import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; -@SuppressWarnings("SystemOut") +@SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output class EtwProviderTests { private static final String FOLDER_NAME = "EtwProviderTests"; private static final File dllTempFolder = DllFileUtils.buildDllLocalPath(FOLDER_NAME); diff --git a/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/applicationinsights/smoketestapp/SpringBootApp.java b/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/applicationinsights/smoketestapp/SpringBootApp.java index 933731eac16..ae9d2c076d4 100644 --- a/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/applicationinsights/smoketestapp/SpringBootApp.java +++ b/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/applicationinsights/smoketestapp/SpringBootApp.java @@ -35,7 +35,7 @@ public static void setEnv(String name, String value) throws Exception { Class cl = env.getClass(); Field field = cl.getDeclaredField("m"); field.setAccessible(true); - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context Map writableEnv = (Map) field.get(env); writableEnv.put(name, value); } diff --git a/smoke-tests/apps/JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java b/smoke-tests/apps/JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java index c42b5a6d6b8..b0769bfb313 100644 --- a/smoke-tests/apps/JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java +++ b/smoke-tests/apps/JmxMetric/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JmxMetricTest.java @@ -89,7 +89,9 @@ void doMostBasicTest() throws Exception { verifyJmxMetricsSentToBreeze(); } - @SuppressWarnings({"PreferJavaTimeOverload"}) + @SuppressWarnings({ + "PreferJavaTimeOverload" + }) // legacy time API required for backward compatibility private void verifyJmxMetricsSentToOtlpEndpoint() { await() .atMost(10, SECONDS) diff --git a/smoke-tests/apps/OtlpMetrics/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/OtlpTest.java b/smoke-tests/apps/OtlpMetrics/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/OtlpTest.java index 5014bec1a9d..b66c1509d41 100644 --- a/smoke-tests/apps/OtlpMetrics/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/OtlpTest.java +++ b/smoke-tests/apps/OtlpMetrics/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/OtlpTest.java @@ -76,7 +76,7 @@ public void testOtlpTelemetry() throws Exception { verifyMetricsSentToOtlpEndpoint(); } - @SuppressWarnings("PreferJavaTimeOverload") + @SuppressWarnings("PreferJavaTimeOverload") // legacy time API required for backward compatibility private void verifyMetricsSentToOtlpEndpoint() { await() .atMost(60, SECONDS) diff --git a/smoke-tests/apps/VerifyAgentJar/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java b/smoke-tests/apps/VerifyAgentJar/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java index 07b80bf9827..8b7b5a952a4 100644 --- a/smoke-tests/apps/VerifyAgentJar/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java +++ b/smoke-tests/apps/VerifyAgentJar/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java @@ -47,7 +47,7 @@ public String verifyAgentJarEntries() throws IOException { return "OK"; } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output @GetMapping("/verifyAgentJarSize") public String verifyAgentJarSize() throws IOException { long size = Files.size(AGENT_JAR.toPath()); diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtension.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtension.java index 9d5ec06af19..ad7245cf5a6 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtension.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtension.java @@ -52,7 +52,10 @@ import org.testcontainers.containers.Network; import org.testcontainers.utility.DockerImageName; -@SuppressWarnings({"SystemOut", "InterruptedExceptionSwallowed"}) +@SuppressWarnings({ + "SystemOut", + "InterruptedExceptionSwallowed" +}) // legitimate use of System.out for logging/output public class SmokeTestExtension implements BeforeAllCallback, BeforeEachCallback, @@ -581,14 +584,16 @@ public void afterAll(ExtensionContext context) throws Exception { } } - @SuppressWarnings("TypeParameterUnusedInFormals") + @SuppressWarnings( + "TypeParameterUnusedInFormals") // type parameter needed for type safety at call site protected static T getBaseData(Envelope envelope) { - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context Data data = (Data) envelope.getData(); return data.getBaseData(); } - @SuppressWarnings("TypeParameterUnusedInFormals") + @SuppressWarnings( + "TypeParameterUnusedInFormals") // type parameter needed for type safety at call site protected T getTelemetryDataForType(int index, String type) { return mockedIngestion.getBaseDataForType(index, type); } diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/JsonHelper.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/JsonHelper.java index 1b28a80c819..d4acc36eda3 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/JsonHelper.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/JsonHelper.java @@ -43,7 +43,7 @@ private static class BaseDataContractDeserializer implements JsonDeserializer(); - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context Class[] classes = new Class[] { RequestData.class, diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServer.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServer.java index 855a5683d77..6d2bdec0afd 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServer.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServer.java @@ -41,13 +41,13 @@ public MockedAppInsightsIngestionServer(boolean usingOld3xAgent) { handler.addServletWithMapping(new ServletHolder(servlet), "/*"); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public void startServer() throws Exception { System.out.println("Starting fake Breeze ingestion..."); server.start(); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public void stopServer() throws Exception { System.out.println("Stopping fake Breeze ingestion..."); server.stop(); @@ -99,7 +99,7 @@ private List getTelemetryDataByType(String type, boolean i List dataItems = new ArrayList<>(); for (Envelope e : items) { if (!inRequestOnly || e.getTags().containsKey("ai.operation.id")) { - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context Data dt = (Data) e.getData(); dataItems.add(dt.getBaseData()); } @@ -117,16 +117,17 @@ public List getMessageDataInRequest(int numItems) waitForItems("MessageData", e -> e.getTags().containsKey("ai.operation.id"), numItems); List dataItems = new ArrayList<>(); for (Envelope e : items) { - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context Data dt = (Data) e.getData(); dataItems.add(dt.getBaseData()); } return dataItems; } - @SuppressWarnings("TypeParameterUnusedInFormals") + @SuppressWarnings( + "TypeParameterUnusedInFormals") // type parameter needed for type safety at call site public T getBaseDataForType(int index, String type) { - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked") // safe unchecked cast - type verified by runtime context Data data = (Data) getItemsEnvelopeDataType(type).get(index).getData(); return data.getBaseData(); } @@ -296,7 +297,7 @@ public LiveMetricsVerifier getLiveMetrics() { return quickPulseServlet.getVerifier(); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public static void main(String[] args) throws Exception { MockedAppInsightsIngestionServer i = new MockedAppInsightsIngestionServer(false); System.out.println("Starting mocked ingestion on port " + DEFAULT_PORT); diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServlet.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServlet.java index ec6fc3d1f6a..a76547cc90c 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServlet.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServlet.java @@ -38,7 +38,7 @@ class MockedAppInsightsIngestionServlet extends HttpServlet { type2envelope = MultimapBuilder.treeKeys().arrayListValues().build(); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output private void logit(String message) { if (loggingEnabled) { System.out.println("FAKE INGESTION: INFO - " + message); diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedOtlpIngestionServer.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedOtlpIngestionServer.java index 72673640234..3013b4ba760 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedOtlpIngestionServer.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedOtlpIngestionServer.java @@ -24,14 +24,14 @@ public class MockedOtlpIngestionServer { private static final int EXPORTER_ENDPOINT_PORT = 4318; private static ClientAndServer collectorServer; - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public void startServer() throws Exception { System.out.println("Starting fake OTLP ingestion..."); collectorServer = startClientAndServer(EXPORTER_ENDPOINT_PORT); collectorServer.when(request()).respond(response().withStatusCode(200)); } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public void stopServer() throws Exception { System.out.println("Stopping fake OTLP ingestion..."); stopQuietly(collectorServer); @@ -47,7 +47,7 @@ public ClientAndServer getCollectorServer() { * @param requests Request received by an http server telemetry collector * @return metrics extracted from the request body */ - @SuppressWarnings("AvoidObjectArrays") + @SuppressWarnings("AvoidObjectArrays") // object array required by API or framework public List extractMetricsFromRequests(HttpRequest[] requests) { return Arrays.stream(requests) .map(HttpRequest::getBody) diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java index 4893de4d024..8225b48507c 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java @@ -15,7 +15,9 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; -@SuppressWarnings("TimeInStaticInitializer") +@SuppressWarnings( + "TimeInStaticInitializer") // time measurement in static initializer is intentional for +// performance tracking public class MockedProfilerSettingsServlet extends HttpServlet { private static final Map CONFIGS; diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedQuickPulseServlet.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedQuickPulseServlet.java index 9cf2b631edd..4baa070f1f7 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedQuickPulseServlet.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedQuickPulseServlet.java @@ -28,7 +28,7 @@ public MockedQuickPulseServlet(boolean usingOld3xAgent) { this.usingOld3xAgent = usingOld3xAgent; } - @SuppressWarnings("SystemOut") + @SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output private void logit(String message) { if (loggingEnabled) { System.out.println("FAKE INGESTION: INFO - " + message); diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/Envelope.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/Envelope.java index aa0957ad407..9398acbd154 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/Envelope.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/Envelope.java @@ -7,7 +7,7 @@ import java.util.concurrent.ConcurrentMap; /** Data contract class Envelope. */ -@SuppressWarnings("unused") +@SuppressWarnings("unused") // value not used but required by API signature or framework public class Envelope { /** Backing field for property Name. */ private String name; @@ -19,7 +19,9 @@ public class Envelope { private Float sampleRate; /** Backing field for property IKey. */ - @SuppressWarnings("checkstyle:MemberName") + @SuppressWarnings( + "checkstyle:MemberName") // naming convention intentionally differs from checkstyle for + // consistency private String iKey; /** Backing field for property Tags. */ @@ -56,13 +58,19 @@ public Float getSampleRate() { /** Gets the IKey property. */ // used by smoke tests - @SuppressWarnings({"checkstyle:AbbreviationAsWordInName", "MemberName"}) + @SuppressWarnings({ + "checkstyle:AbbreviationAsWordInName", + "MemberName" + }) // CGroup is the standard abbreviation for Control Group public String getIKey() { return this.iKey; } /** Sets the IKey property. */ - @SuppressWarnings({"checkstyle:AbbreviationAsWordInName", "MemberName"}) + @SuppressWarnings({ + "checkstyle:AbbreviationAsWordInName", + "MemberName" + }) // CGroup is the standard abbreviation for Control Group public void setIKey(String value) { this.iKey = value; } diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/ExceptionDetails.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/ExceptionDetails.java index d428eb9069d..d353ca80f06 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/ExceptionDetails.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/ExceptionDetails.java @@ -7,7 +7,7 @@ import java.util.List; /** Data contract class ExceptionDetails. */ -@SuppressWarnings("unused") +@SuppressWarnings("unused") // value not used but required by API signature or framework public class ExceptionDetails { /** Backing field for property Id. */ private int id; diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/StackFrame.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/StackFrame.java index 7978ecb68da..2746bced26c 100644 --- a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/StackFrame.java +++ b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/schemav2/StackFrame.java @@ -4,7 +4,7 @@ package com.microsoft.applicationinsights.smoketest.schemav2; /** Data contract class StackFrame. */ -@SuppressWarnings("unused") +@SuppressWarnings("unused") // value not used but required by API signature or framework public class StackFrame { /** Backing field for property Level. */ private int level; diff --git a/smoke-tests/framework/src/test/java/com/microsoft/applicationinsights/smoketest/fakeingestion/JsonHelperTests.java b/smoke-tests/framework/src/test/java/com/microsoft/applicationinsights/smoketest/fakeingestion/JsonHelperTests.java index f31cda6bd1b..51c9cf1a6a0 100644 --- a/smoke-tests/framework/src/test/java/com/microsoft/applicationinsights/smoketest/fakeingestion/JsonHelperTests.java +++ b/smoke-tests/framework/src/test/java/com/microsoft/applicationinsights/smoketest/fakeingestion/JsonHelperTests.java @@ -8,7 +8,7 @@ import com.microsoft.applicationinsights.smoketest.schemav2.Duration; import org.junit.jupiter.api.Test; -@SuppressWarnings("SystemOut") +@SuppressWarnings("SystemOut") // legitimate use of System.out for logging/output public class JsonHelperTests { @Test