Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging from Flask more explicit #117

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Jul 23, 2018

We got some user feedback that their logs weren't being sent to
Application Insights from the Flask integration. This was due to a
confusion between the Python rooter logger logging.debug(...) and the
Flask loggers app.logger.debug(...). The Flask integration only sends
the latter logs to Application Insights since mutating the root logger
from a third party package would be surprising behavior.

This change makes it explicit in the documentation how the logger has to
be used so that the messages to end up in Application Insights.

Make logging from Flask more explicit
We got some user feedback that their logs weren't being sent to
Application Insights from the Flask integration. This was due to a
confusion between the Python rooter logger `logging.debug(...)` and the
Flask loggers `app.logger.debug(...)`. The Flask integration only sends
the latter logs to Application Insights since mutating the root logger
from a third party package would be surprising behavior.

This change makes it explicit in the documentation how the logger has to
be used so that the messages to end up in Application Insights.

@SergeyKanzhelev SergeyKanzhelev merged commit 805f158 into microsoft:develop Jul 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.