Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to customize log level in enable #150

Merged
merged 2 commits into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Mar 1, 2019

This removes an assumption that the log level should always be INFO by enabling users to call the function like so:

import logging
from applicationinsights.logging import enable

enable('my-instrumentation-key', level=logging.DEBUG)

It could be argued the the same can be achieved via: enable('key').setLevel(logging.DEBUG), but this somewhat leaks the logging handler implementation detail and leaves the current implicit INFO level undocumented.

@c-w c-w force-pushed the CatalystCode:log-level-in-enable branch 2 times, most recently from 2d9d432 to 00e69c1 Mar 1, 2019

Add option to customize log level in enable
This removes an assumption that the log level should always be INFO by
enabling users to call the function like so:

```py
import logging
from applicationinsights.logging import enable

enable('my-instrumentation-key', level=logging.DEBUG)
```

@c-w c-w force-pushed the CatalystCode:log-level-in-enable branch from 00e69c1 to 552562b Mar 1, 2019

@SergeyKanzhelev SergeyKanzhelev merged commit af804ce into microsoft:develop Mar 18, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.