Add option to customize log level in enable #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an assumption that the log level should always be INFO by
enabling users to call the function like so:
```py
import logging
from applicationinsights.logging import enable
enable('my-instrumentation-key', level=logging.DEBUG)
```
SergeyKanzhelev
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an assumption that the log level should always be INFO by enabling users to call the function like so:
It could be argued the the same can be achieved via:
enable('key').setLevel(logging.DEBUG), but this somewhat leaks the logging handler implementation detail and leaves the current implicitINFOlevel undocumented.