Skip to content
This repository has been archived by the owner. It is now read-only.

Fix bug when NullSender is used with Async Queue #155

Merged
merged 1 commit into from Mar 18, 2019
Merged

Fix bug when NullSender is used with Async Queue #155

merged 1 commit into from Mar 18, 2019

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Mar 7, 2019

Currently the NullSender crashes when used in conjunction with AsynchronousQueue since the AsynchronousQueue relies on some methods that are not part of the SenderBase interface.

This limitation leads to unexpected behavior when for example using the NullSender to avoid sending telemetry in an application when the instrumentation key isn't configured in the environment.

This change makes the NullSender work with the AsynchronousQueue so that the class can be used with both queues included in the SDK.

Currently the NullSender crashes when used in conjunction with
AsynchronousQueue since the AsynchronousQueue relies on some methods
that are not part of the SenderBase interface.

This limitation leads to unexpected behavior when for example using the
NullSender to avoid sending telemetry in an application when the
instrumentation key isn't configured in the environment.

This change makes the NullSender work with the AsynchronousQueue so that
the class can be used with both queues included in the SDK.
@SergeyKanzhelev SergeyKanzhelev merged commit d7b5fdf into microsoft:develop Mar 18, 2019
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants