Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when NullSender is used with Async Queue #155

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Mar 7, 2019

Currently the NullSender crashes when used in conjunction with AsynchronousQueue since the AsynchronousQueue relies on some methods that are not part of the SenderBase interface.

This limitation leads to unexpected behavior when for example using the NullSender to avoid sending telemetry in an application when the instrumentation key isn't configured in the environment.

This change makes the NullSender work with the AsynchronousQueue so that the class can be used with both queues included in the SDK.

Fix bug when NullSender is used with Async Queue
Currently the NullSender crashes when used in conjunction with
AsynchronousQueue since the AsynchronousQueue relies on some methods
that are not part of the SenderBase interface.

This limitation leads to unexpected behavior when for example using the
NullSender to avoid sending telemetry in an application when the
instrumentation key isn't configured in the environment.

This change makes the NullSender work with the AsynchronousQueue so that
the class can be used with both queues included in the SDK.

@SergeyKanzhelev SergeyKanzhelev merged commit d7b5fdf into microsoft:develop Mar 18, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.