Repository navigation
Fix bug when NullSender is used with Async Queue - #155
Merged
Sergey Kanzhelev (SergeyKanzhelev) merged 1 commit intoMar 18, 2019
Merged
Sergey Kanzhelev (SergeyKanzhelev) merged 1 commit into
Sergey Kanzhelev (SergeyKanzhelev) merged 1 commit into
Conversation
Currently the NullSender crashes when used in conjunction with AsynchronousQueue since the AsynchronousQueue relies on some methods that are not part of the SenderBase interface. This limitation leads to unexpected behavior when for example using the NullSender to avoid sending telemetry in an application when the instrumentation key isn't configured in the environment. This change makes the NullSender work with the AsynchronousQueue so that the class can be used with both queues included in the SDK.
Shawn Cicoria (cicorias)
approved these changes
Mar 8, 2019
Sergey Kanzhelev (SergeyKanzhelev)
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the NullSender crashes when used in conjunction with AsynchronousQueue since the AsynchronousQueue relies on some methods that are not part of the SenderBase interface.
This limitation leads to unexpected behavior when for example using the NullSender to avoid sending telemetry in an application when the instrumentation key isn't configured in the environment.
This change makes the NullSender work with the AsynchronousQueue so that the class can be used with both queues included in the SDK.