Avoid swallowing flask control-flow exceptions#158
Merged
SergeyKanzhelev merged 2 commits intomicrosoft:developfrom Mar 18, 2019
CatalystCode:fix-flask-exception-logger
Merged
Avoid swallowing flask control-flow exceptions#158SergeyKanzhelev merged 2 commits intomicrosoft:developfrom CatalystCode:fix-flask-exception-logger
SergeyKanzhelev merged 2 commits intomicrosoft:developfrom
CatalystCode:fix-flask-exception-logger
Conversation
The Flask 1.0 release changed the semantics of `@app.errorhandler(Exception)`. Previously, this feature would catch application internal exceptions only. Since the Flask 1.0 release, this now catches all exceptions, including werkzeug's HTTPException which is used internally by Flask for control flow, e.g. 404 not found, 403 forbidden, etc. The side-effect of this change is that the AppInsights exception handler now translated these control flow exceptions into uncaught exceptions, i.e. HTTP 500 errors.
SergeyKanzhelev
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flask 1.0 release changed the semantics of
@app.errorhandler(Exception).Previously, this feature would catch application internal exceptions only. Since the Flask 1.0 release, this now catches all exceptions, including werkzeug's HTTPException which is used internally by Flask for control flow, e.g. 404 not found, 403 forbidden, etc. The side-effect of this change is that the AppInsights exception handler now translated these control flow exceptions into uncaught exceptions, i.e. HTTP 500 errors.
This change makes the AppInsights exception handler more robust to no longer swallow the control-flow exceptions.
Resolves #124