Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CodeAnalysis Nuget #2059

Merged
merged 5 commits into from Sep 23, 2020
Merged

Updating CodeAnalysis Nuget #2059

merged 5 commits into from Sep 23, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Sep 16, 2020

Fix #2053

Changes

(Please provide a brief description of the changes here.)

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

fixing fxcop errors

fixing fxcop errors adding ignore to ca1805 and ca1834

disabling ca1829 as well

Revert "fixing fxcop errors"

This reverts commit f070a0b.

merge

merge

updating ruleset
@eddynaka eddynaka self-assigned this Sep 19, 2020
@eddynaka eddynaka marked this pull request as ready for review September 19, 2020 15:30
@TimothyMothra
Copy link
Member

Add those two TODOs to the original Issue. We can work those in a follow up PR, and get this merged today

@eddynaka
Copy link
Contributor Author

Add those two TODOs to the original Issue. We can work those in a follow up PR, and get this merged today

I solved the major ones and added the TODOs where I couldn't do it. We are good to go

@TimothyMothra
Copy link
Member

I mean add the file name and line number to the original issue so we can circle back and address them

@eddynaka
Copy link
Contributor Author

I mean add the file name and line number to the original issue so we can circle back and address them

Just updated the main issue. thank you.

@eddynaka eddynaka merged commit 004dbd7 into develop Sep 23, 2020
@eddynaka eddynaka deleted the users/ednakamu/updating-cops branch September 23, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Error: StandardPerformanceCounter IDisposable
2 participants