Merge pull request #68 from microsoft/ConfMisc

Conf misc
microsoft · Jan 15, 2020 · b6e3e26 · b6e3e26
2 parents b77c082 + f4b5a0d
commit b6e3e26
Showing 1 changed file with 26 additions and 10 deletions.
diff --git a/AppInspector/rules/default/os/file_io.json b/AppInspector/rules/default/os/file_io.json
@@ -18,6 +18,7 @@
         "scopes": [
           "code"
         ],
+        "confidence": "high",
         "_comment": ""
       }
     ]
@@ -40,6 +41,7 @@
         "scopes": [
           "code"
         ],
+        "confidence": "high",
         "_comment": ""
       },
       {
@@ -48,6 +50,7 @@
         "scopes": [
           "code"
         ],
+        "confidence": "high",
         "_comment": ""
       },
       {
@@ -56,6 +59,7 @@
         "scopes": [
           "code"
         ],
+        "confidence": "high",
         "_comment": ""
       }
     ]
@@ -73,11 +77,29 @@
     "severity": "moderate",
     "patterns": [
       {
-        "pattern": "open[(][\"']",
+        "pattern": "open\\(.*,.*r.*\\);",
         "type": "regex",
         "scopes": [
           "code"
         ],
+        "confidence": "high",
+        "_comment": ""
+      },
+      {
+        "pattern": ".readlines(",
+        "type": "string",
+        "scopes": [
+          "code"
+        ],
+        "confidence": "high",
+        "_comment": ""
+      },
+      {
+        "pattern": ".read(",
+        "type": "string",
+        "scopes": [
+          "code"
+        ],
         "_comment": ""
       }
     ]
@@ -108,6 +130,7 @@
         "scopes": [
           "code"
         ],
+        "confidence": "high",
         "_comment": ""
       },
       {
@@ -138,6 +161,7 @@
         "scopes": [
           "code"
         ],
+        "confidence": "high",
         "_comment": ""
       },
       {
@@ -146,6 +170,7 @@
         "scopes": [
           "code"
         ],
+        "confidence": "high",
         "_comment": ""
       }
     ]
@@ -263,15 +288,6 @@
     ],
     "severity": "moderate",
     "patterns": [
-      {
-        "pattern": ".deleteDirectory(",
-        "type": "string",
-        "scopes": [
-          "code"
-        ],
-        "confidence": "high",
-        "_comment": ""
-      },
       {
         "pattern": "file.delete(",
         "type": "string",