NuGet library failing with "Invalid -v argument value"

[scovetta]

Describe the bug
The AnalyzeCommand throws an OpException when used.

To Reproduce

        static void Main(string[] args)
        {
            AnalyzeCommandOptions options = new AnalyzeCommandOptions();
            AnalyzeCommand command = new AnalyzeCommand(options);
            options.SourcePath = ".";

            string result = command.GetResult(); //process results as desired
            Console.WriteLine(result);
        }

Exception trace:

 	ApplicationInspector.Commands.dll!Microsoft.ApplicationInspector.Commands.Utils.SetupLogging()	Unknown
 	ApplicationInspector.Commands.dll!Microsoft.ApplicationInspector.Commands.WriteOnce.SafeLog(string message, NLog.LogLevel logLevel)	Unknown
 	ApplicationInspector.Commands.dll!Microsoft.ApplicationInspector.Commands.AnalyzeCommand.ConfigOutput()	Unknown
 	ApplicationInspector.Commands.dll!Microsoft.ApplicationInspector.Commands.AnalyzeCommand.AnalyzeCommand(Microsoft.ApplicationInspector.Commands.AnalyzeCommandOptions opt)	Unknown
>	TestAI1.dll!TestAI1.Program.Main(string[] args) Line 11	C#

I believe this might be due to the LogFileLevel not being assigned in AnalyzeCommand.cs

Additional context
Using the NuGet version 1.1.21 on .NET Core 3.1

[guyacosta]

investigating

[guyacosta]

The first issue is the call order above does not set the source path in the options object before passing it to the analyzecommand constructor :).

        AnalyzeCommandOptions options = new AnalyzeCommandOptions();
        options.SourcePath = "."; //all values should be initialized before passing to the command
        AnalyzeCommand command = new AnalyzeCommand(options);
        
        string result = command.GetResult(); //process results as desired
        Console.WriteLine(result);

So as it was used, it will throw an exception on the directory or file being invalid which is correct but I can clarify the log error since there will be no file name to report to help. In addition I did find the log level was not set by default which could cause an issue. The logging setup path changed recently. High priority on next fix after this is missing unit tests to avoid missing a test path.

[scovetta]

Thanks! If you send me over a .nupkg I can test it locally to make sure we're good.

[guyacosta]

Will do. Just improving the error msg on null source file for clarify in log -2 minutes.