From ee91e3fd0fd242069a7013fddf62e0704ad1495f Mon Sep 17 00:00:00 2001 From: Dusan Jakovljevic <134404137+JakovljevicDusan@users.noreply.github.com> Date: Mon, 23 Mar 2026 13:27:17 +0100 Subject: [PATCH 1/2] [Quality Management] Standardize 'QltyMngmnt' to 'QltyMgmt' across permission sets and related code --- .../src/QltyInspectionUtility.Codeunit.al | 2 +- .../src/AccessControl/QltyPermissionMgmt.Codeunit.al | 2 +- .../AdministratorQltyMngmnt.PermissionSetExt.al | 2 +- .../D365BasicIsvQltyMngmnt.PermissionSetExt.al | 2 +- .../D365BusFullAccessQltyMngmnt.PermissionSetExt.al | 2 +- .../D365ReadQltyMngmnt.PermissionSetExt.al | 2 +- ...ermissionSet.al => QltyMgmtAdmin.PermissionSet.al} | 6 +++--- ...ssionSet.al => QltyMgmtInspector.PermissionSet.al} | 11 +++++++---- ...missionSet.al => QltyMgmtObjects.PermissionSet.al} | 8 ++++++-- ...PermissionSet.al => QltyMgmtRead.PermissionSet.al} | 10 +++++++--- .../test/src/QltyTestsPermissionMgmt.Codeunit.al | 2 +- 11 files changed, 30 insertions(+), 19 deletions(-) rename src/Apps/W1/Quality Management/app/src/Permissions/{QltyMngmntAdmin.PermissionSet.al => QltyMgmtAdmin.PermissionSet.al} (93%) rename src/Apps/W1/Quality Management/app/src/Permissions/{QltyMngmntInspector.PermissionSet.al => QltyMgmtInspector.PermissionSet.al} (87%) rename src/Apps/W1/Quality Management/app/src/Permissions/{QltyMngmntObjects.PermissionSet.al => QltyMgmtObjects.PermissionSet.al} (97%) rename src/Apps/W1/Quality Management/app/src/Permissions/{QltyMngmntRead.PermissionSet.al => QltyMgmtRead.PermissionSet.al} (88%) diff --git a/src/Apps/W1/Quality Management/Test Library/src/QltyInspectionUtility.Codeunit.al b/src/Apps/W1/Quality Management/Test Library/src/QltyInspectionUtility.Codeunit.al index ba9108338e..86a3051844 100644 --- a/src/Apps/W1/Quality Management/Test Library/src/QltyInspectionUtility.Codeunit.al +++ b/src/Apps/W1/Quality Management/Test Library/src/QltyInspectionUtility.Codeunit.al @@ -54,7 +54,7 @@ codeunit 139940 "Qlty. Inspection Utility" LibraryUtility: Codeunit "Library - Utility"; NoSeriesCodeunit: Codeunit "No. Series"; DefaultResult2PassCodeLbl: Label 'PASS', Locked = true; - AdminSupervisorRoleIDTok: Label 'QltyMngmnt - Admin', Locked = true; + AdminSupervisorRoleIDTok: Label 'QltyMgmt - Admin', Locked = true; internal procedure EnsureSetupExists() var diff --git a/src/Apps/W1/Quality Management/app/src/AccessControl/QltyPermissionMgmt.Codeunit.al b/src/Apps/W1/Quality Management/app/src/AccessControl/QltyPermissionMgmt.Codeunit.al index 2b98729574..14f0978e9c 100644 --- a/src/Apps/W1/Quality Management/app/src/AccessControl/QltyPermissionMgmt.Codeunit.al +++ b/src/Apps/W1/Quality Management/app/src/AccessControl/QltyPermissionMgmt.Codeunit.al @@ -28,7 +28,7 @@ codeunit 20406 "Qlty. Permission Mgmt." ActionChangeItemTrackingLbl: Label 'change item tracking'; ActionChangeSourceQuantityLbl: Label 'change source quantity'; ActionEditLineCommentLbl: Label 'edit line note/comment'; - AdminSupervisorRoleIDTxt: Label 'QltyMngmnt - Admin', Locked = true; + AdminSupervisorRoleIDTxt: Label 'QltyMgmt - Admin', Locked = true; UserDoesNotHavePermissionToErr: Label 'The user [%1] does not have permission to [%2].', Comment = '%1=User id, %2=permission being attempted'; /// diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMngmnt.PermissionSetExt.al b/src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMngmnt.PermissionSetExt.al index b7cc2e33d7..854629a3c6 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMngmnt.PermissionSetExt.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMngmnt.PermissionSetExt.al @@ -8,5 +8,5 @@ using System.Security.AccessControl; permissionsetextension 20402 "Administrator - QltyMngmnt" extends "Administrator" { - IncludedPermissionSets = "QltyMngmnt - Admin"; + IncludedPermissionSets = "QltyMgmt - Admin"; } \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMngmnt.PermissionSetExt.al b/src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMngmnt.PermissionSetExt.al index 286d959a7b..0e5fc8e238 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMngmnt.PermissionSetExt.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMngmnt.PermissionSetExt.al @@ -8,5 +8,5 @@ using System.Security.AccessControl; permissionsetextension 20400 "D365 BASIC ISV - QltyMngmnt" extends "D365 BASIC ISV" { - IncludedPermissionSets = "QltyMngmnt - Admin"; + IncludedPermissionSets = "QltyMgmt - Admin"; } \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMngmnt.PermissionSetExt.al b/src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMngmnt.PermissionSetExt.al index 5473539e2e..481cadc988 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMngmnt.PermissionSetExt.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMngmnt.PermissionSetExt.al @@ -8,5 +8,5 @@ using System.Security.AccessControl; permissionsetextension 20401 "D365 BUS FULL ACCESS - QltyMngmnt" extends "D365 BUS FULL ACCESS" { - IncludedPermissionSets = "QltyMngmnt - Admin"; + IncludedPermissionSets = "QltyMgmt - Admin"; } \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMngmnt.PermissionSetExt.al b/src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMngmnt.PermissionSetExt.al index 6271133f8b..6783507b27 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMngmnt.PermissionSetExt.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMngmnt.PermissionSetExt.al @@ -8,5 +8,5 @@ using System.Security.AccessControl; permissionsetextension 20403 "D365 READ - QltyMngmnt" extends "D365 READ" { - IncludedPermissionSets = "QltyMngmnt - Read"; + IncludedPermissionSets = "QltyMgmt - Read"; } \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntAdmin.PermissionSet.al b/src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtAdmin.PermissionSet.al similarity index 93% rename from src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntAdmin.PermissionSet.al rename to src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtAdmin.PermissionSet.al index df03b08d51..920d325e95 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntAdmin.PermissionSet.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtAdmin.PermissionSet.al @@ -20,13 +20,13 @@ using Microsoft.QualityManagement.Workflow; /// #pragma warning disable AS0125 #pragma warning disable AS0090 -permissionset 20405 "QltyMngmnt - Admin" +permissionset 20405 "QltyMgmt - Admin" { - Caption = 'Quality Management - Administrator'; + Caption = 'Quality Admin & Supervisor'; Access = Public; Assignable = true; - IncludedPermissionSets = "QltyMngmnt - Objects"; + IncludedPermissionSets = "QltyMgmt - Objects"; Permissions = tabledata "Qlty. Management Setup" = RIMD, diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntInspector.PermissionSet.al b/src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtInspector.PermissionSet.al similarity index 87% rename from src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntInspector.PermissionSet.al rename to src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtInspector.PermissionSet.al index d648645ef5..cfd02d529a 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntInspector.PermissionSet.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtInspector.PermissionSet.al @@ -17,13 +17,15 @@ using Microsoft.QualityManagement.Workflow; /// /// Used for working with Quality Inspections. /// -permissionset 20404 QltyMngmntInspector +#pragma warning disable AS0125 +#pragma warning disable AS0090 +permissionset 20404 "QltyMgmt - Inspector" { - Caption = 'Quality Management - Quality Inspector'; + Caption = 'Quality Inspector'; Access = Public; Assignable = true; - IncludedPermissionSets = "QltyMngmnt - Objects"; + IncludedPermissionSets = "QltyMgmt - Objects"; Permissions = tabledata "Qlty. Workflow Config. Value" = Rim, @@ -41,4 +43,5 @@ permissionset 20404 QltyMngmntInspector tabledata "Qlty. Inspection Header" = RIMd, tabledata "Qlty. Test" = R; } - +#pragma warning restore AS0090 +#pragma warning restore AS0125 \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntObjects.PermissionSet.al b/src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtObjects.PermissionSet.al similarity index 97% rename from src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntObjects.PermissionSet.al rename to src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtObjects.PermissionSet.al index e50387bcf0..cf72167458 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntObjects.PermissionSet.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtObjects.PermissionSet.al @@ -41,11 +41,13 @@ using Microsoft.QualityManagement.Setup.SetupGuide; using Microsoft.QualityManagement.Utilities; using Microsoft.QualityManagement.Workflow; -permissionset 20406 "QltyMngmnt - Objects" +#pragma warning disable AS0125 +#pragma warning disable AS0090 +permissionset 20406 "QltyMgmt - Objects" { Caption = 'Quality Management - Objects'; Access = Internal; - Assignable = true; + Assignable = false; Permissions = // Codeunits @@ -165,3 +167,5 @@ permissionset 20406 "QltyMngmnt - Objects" table "Qlty. Inspection Header" = X, table "Qlty. Test" = X; } +#pragma warning restore AS0090 +#pragma warning restore AS0125 \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntRead.PermissionSet.al b/src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtRead.PermissionSet.al similarity index 88% rename from src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntRead.PermissionSet.al rename to src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtRead.PermissionSet.al index ba280e8fe4..0ee415ac45 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/QltyMngmntRead.PermissionSet.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/QltyMgmtRead.PermissionSet.al @@ -18,13 +18,15 @@ using Microsoft.QualityManagement.Workflow; /// /// Used for full read-only access to Quality Management. /// -permissionset 20401 "QltyMngmnt - Read" +#pragma warning disable AS0125 +#pragma warning disable AS0090 +permissionset 20401 "QltyMgmt - Read" { - Caption = 'Quality Management - Read access'; + Caption = 'Quality Auditor'; Access = Public; Assignable = true; - IncludedPermissionSets = "QltyMngmnt - Objects"; + IncludedPermissionSets = "QltyMgmt - Objects"; Permissions = tabledata "Qlty. Management Setup" = R, @@ -43,3 +45,5 @@ permissionset 20401 "QltyMngmnt - Read" tabledata "Qlty. Inspection Header" = R, tabledata "Qlty. Inspection Line" = R; } +#pragma warning restore AS0090 +#pragma warning restore AS0125 \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/test/src/QltyTestsPermissionMgmt.Codeunit.al b/src/Apps/W1/Quality Management/test/src/QltyTestsPermissionMgmt.Codeunit.al index 35badc1eb9..3cd140bea6 100644 --- a/src/Apps/W1/Quality Management/test/src/QltyTestsPermissionMgmt.Codeunit.al +++ b/src/Apps/W1/Quality Management/test/src/QltyTestsPermissionMgmt.Codeunit.al @@ -19,7 +19,7 @@ codeunit 139957 "Qlty. Tests - Permission Mgmt." QltyInspectionUtility: Codeunit "Qlty. Inspection Utility"; LibraryAssert: Codeunit "Library Assert"; UserDoesNotHavePermissionToErr: Label 'The user [%1] does not have permission to [%2].', Comment = '%1=User id, %2=permission being attempted'; - AdminSupervisorRoleIDTok: Label 'QltyMngmnt - Admin', Locked = true; + AdminSupervisorRoleIDTok: Label 'QltyMgmt - Admin', Locked = true; [Test] procedure VerifyCanCreateManualInspection_ShouldError() From 8848cbefaf707b388e2dcd9398b8b46d621b08cd Mon Sep 17 00:00:00 2001 From: Dusan Jakovljevic <134404137+JakovljevicDusan@users.noreply.github.com> Date: Mon, 23 Mar 2026 16:11:13 +0100 Subject: [PATCH 2/2] Include permissionsetextension --- ...nSetExt.al => AdministratorQltyMgmt.PermissionSetExt.al} | 6 ++++-- ...onSetExt.al => D365BasicIsvQltyMgmt.PermissionSetExt.al} | 6 ++++-- ...Ext.al => D365BusFullAccessQltyMgmt.PermissionSetExt.al} | 6 ++++-- ...issionSetExt.al => D365ReadQltyMgmt.PermissionSetExt.al} | 6 ++++-- 4 files changed, 16 insertions(+), 8 deletions(-) rename src/Apps/W1/Quality Management/app/src/Permissions/{AdministratorQltyMngmnt.PermissionSetExt.al => AdministratorQltyMgmt.PermissionSetExt.al} (77%) rename src/Apps/W1/Quality Management/app/src/Permissions/{D365BasicIsvQltyMngmnt.PermissionSetExt.al => D365BasicIsvQltyMgmt.PermissionSetExt.al} (77%) rename src/Apps/W1/Quality Management/app/src/Permissions/{D365BusFullAccessQltyMngmnt.PermissionSetExt.al => D365BusFullAccessQltyMgmt.PermissionSetExt.al} (76%) rename src/Apps/W1/Quality Management/app/src/Permissions/{D365ReadQltyMngmnt.PermissionSetExt.al => D365ReadQltyMgmt.PermissionSetExt.al} (78%) diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMngmnt.PermissionSetExt.al b/src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMgmt.PermissionSetExt.al similarity index 77% rename from src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMngmnt.PermissionSetExt.al rename to src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMgmt.PermissionSetExt.al index 854629a3c6..f7a3426735 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMngmnt.PermissionSetExt.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/AdministratorQltyMgmt.PermissionSetExt.al @@ -6,7 +6,9 @@ namespace Microsoft.QualityManagement.Permissions; using System.Security.AccessControl; -permissionsetextension 20402 "Administrator - QltyMngmnt" extends "Administrator" +#pragma warning disable AS0090 +permissionsetextension 20402 "Administrator - QltyMgmt" extends "Administrator" { IncludedPermissionSets = "QltyMgmt - Admin"; -} \ No newline at end of file +} +#pragma warning restore AS0090 \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMngmnt.PermissionSetExt.al b/src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMgmt.PermissionSetExt.al similarity index 77% rename from src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMngmnt.PermissionSetExt.al rename to src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMgmt.PermissionSetExt.al index 0e5fc8e238..134cb9f53b 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMngmnt.PermissionSetExt.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/D365BasicIsvQltyMgmt.PermissionSetExt.al @@ -6,7 +6,9 @@ namespace Microsoft.QualityManagement.Permissions; using System.Security.AccessControl; -permissionsetextension 20400 "D365 BASIC ISV - QltyMngmnt" extends "D365 BASIC ISV" +#pragma warning disable AS0090 +permissionsetextension 20400 "D365 BASIC ISV - QltyMgmt" extends "D365 BASIC ISV" { IncludedPermissionSets = "QltyMgmt - Admin"; -} \ No newline at end of file +} +#pragma warning restore AS0090 \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMngmnt.PermissionSetExt.al b/src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMgmt.PermissionSetExt.al similarity index 76% rename from src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMngmnt.PermissionSetExt.al rename to src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMgmt.PermissionSetExt.al index 481cadc988..73077e94a3 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMngmnt.PermissionSetExt.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/D365BusFullAccessQltyMgmt.PermissionSetExt.al @@ -6,7 +6,9 @@ namespace Microsoft.QualityManagement.Permissions; using System.Security.AccessControl; -permissionsetextension 20401 "D365 BUS FULL ACCESS - QltyMngmnt" extends "D365 BUS FULL ACCESS" +#pragma warning disable AS0090 +permissionsetextension 20401 "D365 BUS FULL ACCESS - QltyMgmt" extends "D365 BUS FULL ACCESS" { IncludedPermissionSets = "QltyMgmt - Admin"; -} \ No newline at end of file +} +#pragma warning restore AS0090 \ No newline at end of file diff --git a/src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMngmnt.PermissionSetExt.al b/src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMgmt.PermissionSetExt.al similarity index 78% rename from src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMngmnt.PermissionSetExt.al rename to src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMgmt.PermissionSetExt.al index 6783507b27..4fb75a5ef0 100644 --- a/src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMngmnt.PermissionSetExt.al +++ b/src/Apps/W1/Quality Management/app/src/Permissions/D365ReadQltyMgmt.PermissionSetExt.al @@ -6,7 +6,9 @@ namespace Microsoft.QualityManagement.Permissions; using System.Security.AccessControl; -permissionsetextension 20403 "D365 READ - QltyMngmnt" extends "D365 READ" +#pragma warning disable AS0090 +permissionsetextension 20403 "D365 READ - QltyMgmt" extends "D365 READ" { IncludedPermissionSets = "QltyMgmt - Read"; -} \ No newline at end of file +} +#pragma warning restore AS0090 \ No newline at end of file