Bug 637527: Set DataClassification = SystemMetadata on PEPPOL 3.0 Setup table#8515
Merged
Merged
Conversation
Groenbech96
force-pushed
the
magnushar/637527-peppol-data-classification
branch
from
96d3248 to
51b5e18
Compare
Groenbech96
changed the title
…up table Move DataClassification to table level (SystemMetadata) since all fields are system metadata (primary key and enum format selectors). This avoids creating unclassified Data Sensitivity entries during evaluation data setup, which were causing the Data Classs Demo Data Tests.TestDataSensitivities test to fail.
Groenbech96
force-pushed
the
magnushar/637527-peppol-data-classification
branch
from
51b5e18 to
5f8c7e2
Compare
Groenbech96
changed the title
aholstrup1
approved these changes
Jun 8, 2026
onbuyuka
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
DataClassificationto the table level (SystemMetadata) on table 37202PEPPOL 3.0 Setup. All fields on this table are system metadata (the primary key and two enum format selectors), so the table-level classification is the correct semantic and removes the need for per-field overrides.Why
Data Classification Eval. Data.CreateEvaluationDataonly createsData Sensitivityentries for fields classified asCustomerContent,EndUserIdentifiableInformation, orEndUserPseudonymousIdentifiers. With the previousCustomerContenttable-level default inherited by fields 2 and 3, entries were created asUnclassified, causingData Classs Demo Data Tests.TestDataSensitivitiesto fail with:With
SystemMetadataat the table level, no entries are created for these fields and the test passes.Work item
AB#637527