Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples version update #1489

Merged
merged 2 commits into from Jun 28, 2019
Merged

Samples version update #1489

merged 2 commits into from Jun 28, 2019

Conversation

rokulka
Copy link
Contributor

@rokulka rokulka commented May 6, 2019

Samples version update to 4.4.0

@rokulka rokulka requested a review from johnataylor May 6, 2019 08:09
<PackageReference Include="Microsoft.Bot.Configuration" Version="4.2.0" />
<PackageReference Include="Microsoft.Bot.Connector" Version="4.2.0" />
<PackageReference Include="Microsoft.Bot.Schema" Version="4.2.0" />
<PackageReference Include="Microsoft.Bot.Builder" Version="4.4.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

<PackageReference Include="Microsoft.Bot.Configuration" Version="4.2.0" />
<PackageReference Include="Microsoft.Bot.Connector" Version="4.2.0" />
<PackageReference Include="Microsoft.Bot.Schema" Version="4.2.0" />
<PackageReference Include="Microsoft.Bot.Builder" Version="4.4.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment... in C# we're up to 4.4.3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Microsoft.Bot.* assemblies need to be updated to 4.4.3 please.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have been updated, this comments shows an outdated snapshot.

Copy link
Member

@sgellock sgellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rohan, can you update to 4.4.3 versions of bot framework please? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants