From 660373c2800582b4819520c1a21de7387ff625a4 Mon Sep 17 00:00:00 2001
From: Tony Anziano <tonyanziano@Tonys-MacBook-Pro.local>
Date: Wed, 20 Nov 2019 11:09:27 -0800
Subject: [PATCH] Fixed a11y issue with link descriptiveness.

---
 CHANGELOG.md                                                  | 1 +
 .../src/ui/dialogs/botSettingsEditor/botSettingsEditor.tsx    | 2 +-
 .../app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx | 2 +-
 .../src/ui/editor/emulator/parts/inspector/inspector.tsx      | 3 ++-
 .../endpointExplorer/endpointEditor/endpointEditor.tsx        | 2 +-
 .../servicesExplorer/connectedServiceEditor/kvPair.tsx        | 4 ++--
 6 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ca31fe080..696ab1766 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - [1992](https://github.com/microsoft/BotFramework-Emulator/pull/1992)
   - [1993](https://github.com/microsoft/BotFramework-Emulator/pull/1993)
   - [1994](https://github.com/microsoft/BotFramework-Emulator/pull/1994)
+  - [1997](https://github.com/microsoft/BotFramework-Emulator/pull/1997)
 
 ## Removed
 - [main] Removed unused `VersionManager` class in PR [1991](https://github.com/microsoft/BotFramework-Emulator/pull/1991)
diff --git a/packages/app/client/src/ui/dialogs/botSettingsEditor/botSettingsEditor.tsx b/packages/app/client/src/ui/dialogs/botSettingsEditor/botSettingsEditor.tsx
index 6ade8d2d0..6b537fd09 100644
--- a/packages/app/client/src/ui/dialogs/botSettingsEditor/botSettingsEditor.tsx
+++ b/packages/app/client/src/ui/dialogs/botSettingsEditor/botSettingsEditor.tsx
@@ -116,7 +116,7 @@ export class BotSettingsEditor extends React.Component<BotSettingsEditorProps, B
             onChange={this.onEncryptKeyChange}
           />
           <LinkButton
-            aria-label="Learn more about bot file encryption"
+            ariaLabel="Learn more about bot file encryption"
             className={styles.dialogLink}
             linkRole={true}
             onClick={this.onLearnMoreEncryptionClick}
diff --git a/packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx b/packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx
index 60ce491b4..5deceed6b 100644
--- a/packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx
+++ b/packages/app/client/src/ui/dialogs/openBotDialog/openBotDialog.tsx
@@ -176,7 +176,7 @@ export class OpenBotDialog extends Component<OpenBotDialogProps, OpenBotDialogSt
               onClick={this.onChannelServiceCheckboxClick}
             />
             <LinkButton
-              aria-label="Learn more about Azure for US Government"
+              ariaLabel="Learn more about Azure for US Government"
               linkRole={true}
               onClick={this.onEmulatorAzureGovDocsClick}
             >
diff --git a/packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx b/packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx
index 096568ec2..fd9374db9 100644
--- a/packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx
+++ b/packages/app/client/src/ui/editor/emulator/parts/inspector/inspector.tsx
@@ -239,7 +239,8 @@ export class Inspector extends React.Component<InspectorProps, InspectorState> {
                 }
                 <LinkButton
                   onClick={this.onDebugDocsClick}
-                  aria-label="Learn more about debugging your bot with the Emulator"
+                  ariaLabel="Learn more about debugging your bot with the Emulator"
+                  linkRole={true}
                 >
                   Learn More.
                 </LinkButton>
diff --git a/packages/app/client/src/ui/shell/explorer/endpointExplorer/endpointEditor/endpointEditor.tsx b/packages/app/client/src/ui/shell/explorer/endpointExplorer/endpointEditor/endpointEditor.tsx
index d4d468fa3..ebe2d0d2b 100644
--- a/packages/app/client/src/ui/shell/explorer/endpointExplorer/endpointEditor/endpointEditor.tsx
+++ b/packages/app/client/src/ui/shell/explorer/endpointExplorer/endpointEditor/endpointEditor.tsx
@@ -167,7 +167,7 @@ export class EndpointEditor extends Component<EndpointEditorProps, EndpointEdito
           <Checkbox label="Azure for US Government" checked={isUsGov} onChange={this.onChannelServiceChange} />
           &nbsp;
           <LinkButton
-            aria-label="Learn more about Azure for US Government"
+            ariaLabel="Learn more about Azure for US Government"
             className={styles.endpointLink}
             linkRole={true}
             onClick={this.onAzureGovDocClick}
diff --git a/packages/app/client/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/kvPair.tsx b/packages/app/client/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/kvPair.tsx
index 661b73168..5649cd585 100644
--- a/packages/app/client/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/kvPair.tsx
+++ b/packages/app/client/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/kvPair.tsx
@@ -72,14 +72,14 @@ export class KvPair extends Component<KvPairProps, KvPairState> {
           ))}
         </ul>
         <LinkButton
-          aria-label="Add key value pair"
+          ariaLabel="Add key value pair"
           className={`${styles.link} ${styles.kvSpacing}`}
           onClick={this.onAddKvPair}
         >
           + Add key value pair
         </LinkButton>
         <LinkButton
-          aria-label="Remove key value pair"
+          ariaLabel="Remove key value pair"
           className={styles.link}
           disabled={numRows === 1}
           onClick={this.onRemoveKvPair}