Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar window slider gets stuck in 'slide' mode #1513

Closed
corinagum opened this issue May 3, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@corinagum
Copy link
Member

commented May 3, 2019

Version

4.3.3-57771

Describe the bug

Adjusting the middle vertical slider can make Emulator stuck in the slide mode, and the mouse can't escape from unintentionally adjusting the slider.

To Reproduce

Steps to reproduce the behavior:

  1. Open sidecar mode
  2. Drag the middle vertical slider and let go
  3. Move the mouse around the screen, expecting only the cursor to move, but see the window adjust sizes
  4. Note that clicking away from window or pressing escape doesn't release slide mode.

Expected behavior

Slider should be released after user lets go of the slider.

Screenshots

ezgif-1-2a4dd83841af

[bug]

@tonyanziano

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

This is due to the upgrade to Electron 4 which uses a different version of Chromium in which the architecture of webviews (which house the inspectors) has changed. Now the webviews eat all mouse events and they do not bubble up back to the slider component.

This causes the slider to calculate an incorrect delta when dragging the mouse over the inspector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.