Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed NSIS installer to install on a per-user basis. #1562

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
2 participants
@tonyanziano
Copy link
Contributor

commented May 10, 2019

Fixes #1537

===

The issue was caused by the Emulator installer.exe requiring admin permissions to run because it installed on a per-machine (for all users) basis. I've changed the installer to be on a per-user basis, so it no longer requires admin permissions to run. So now the update will be installed after closing the emulator, regardless of whether it was running in an administrator context or not.

Top installer is with the new change, bottom is without:

image

@tonyanziano tonyanziano force-pushed the toanzian/update branch from cd50151 to a831940 May 10, 2019

@cwhitten cwhitten merged commit ff6c60f into master May 11, 2019

3 checks passed

Azure DevOps CI #59232 succeeded
Details
[experimental]Upload-package.json #59186 succeeded
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/update branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.