Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V dai/clear state #1596

Merged
merged 5 commits into from May 29, 2019

Conversation

Projects
None yet
3 participants
@ivanov-dan
Copy link
Contributor

commented May 28, 2019

No description provided.

@justinwilaby
Copy link
Contributor

left a comment

Some small items to tighten up. Otherwise, it looks good.

message: 'You have successfully cleared state.',
title: 'Success!',
});
const { session } = require('electron');

This comment has been minimized.

Copy link
@justinwilaby

justinwilaby May 28, 2019

Contributor

Although this is generally ok, we have established a pattern of placing requires at the top of the file using import. In this case it would be import * as electron from 'electron'; or import { session } from 'electron';

This comment has been minimized.

Copy link
@ivanov-dan

ivanov-dan May 28, 2019

Author Contributor

Fixed.

title: 'Success!',
});
const { session } = require('electron');
await new Promise(resolve => session.defaultSession.clearStorageData({}, resolve));

This comment has been minimized.

Copy link
@justinwilaby

justinwilaby May 28, 2019

Contributor

This should probably go in at line 299.

This comment has been minimized.

Copy link
@justinwilaby

justinwilaby May 29, 2019

Contributor

Is there a technical reason the user is notified before the storage data is cleared?

This comment has been minimized.

Copy link
@ivanov-dan

ivanov-dan May 29, 2019

Author Contributor

This is a scenario that @cwhitten requested.

ivanov-dan added some commits May 28, 2019

@tonyanziano tonyanziano merged commit b4cca95 into master May 29, 2019

3 checks passed

Emulator-CI-PR #61735 succeeded
Details
[experimental]Upload-package.json #61736 succeeded
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the v-dai/clearState branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.