Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of attachments sent from a bot. #1661

Merged
merged 1 commit into from Jun 27, 2019

Conversation

Projects
None yet
2 participants
@tonyanziano
Copy link
Contributor

commented Jun 26, 2019

Fixes #1362

===

The issue was that the attachment data sent from a bot is already an encoded base64 string, and is not a buffer that needs to be converted, whereas attachments uploaded via the Web Chat client's paperclip button arrive as a buffer that needs to be converted.

The latter case was fixed in #1364.

This will fix the former case.

Uploading image from bot code:

image

Uploading image from Web Chat client control:

image

@tonyanziano tonyanziano force-pushed the toanzian/#1362-attachments branch from fdd90b3 to 8a1d7c5 Jun 27, 2019

@tonyanziano tonyanziano merged commit 88bfc55 into master Jun 27, 2019

3 checks passed

Emulator-CI-PR #67679 succeeded
Details
[experimental]Upload-package.json #67680 succeeded
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/#1362-attachments branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.