Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where custom activity ids were being overwritten. #1665

Merged
merged 2 commits into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@tonyanziano
Copy link
Contributor

commented Jul 2, 2019

Fixes #1604

===

If we received an activity from the bot with a custom id already attached, the Emulator was throwing that value away and generating a new id.

Before fix:

fix_before

After fix:

fix_after

@tonyanziano tonyanziano force-pushed the toanzian/#1604-act-id branch from cb73857 to f89a7d4 Jul 2, 2019

@tonyanziano tonyanziano merged commit a07d4e2 into master Jul 3, 2019

2 checks passed

Emulator-CI-PR #68823 succeeded
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/#1604-act-id branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.