Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where adaptive card inputs were being reset. #1681

Merged
merged 1 commit into from Jul 13, 2019

Conversation

@tonyanziano
Copy link
Contributor

commented Jul 12, 2019

Fixes #1680

===

The root cause is that when an activity is clicked on, it fires off both highlight activity & set inspector objects actions that then modify the chat document in the store.

This change in the store causes the chat.tsx component to re-render and the entire Web Chat control with it, which wipes the state of input fields within adaptive cards.

Preventing that re-render from happening seems like a very hard problem, if not impossible, given our current DOM structure.

The fix here is to intercept clicks & keydown events within activities, check if they originated within an input field, and prevent the highlight and select activity actions from being fired.

@tonyanziano tonyanziano force-pushed the toanzian/#1680-card-input branch from 99dc3ea to 09107ec Jul 12, 2019

@cwhitten cwhitten merged commit 3cd7624 into master Jul 13, 2019

2 checks passed

Emulator-CI-PR #70536 succeeded
Details
license/cla All CLA requirements met.
Details

@cwhitten cwhitten deleted the toanzian/#1680-card-input branch Jul 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.