Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed click handling within all adaptive card inputs. #1690

Merged
merged 1 commit into from Jul 17, 2019

Conversation

@tonyanziano
Copy link
Contributor

commented Jul 16, 2019

Fixes #1680 & #1683

===

To ensure that all Adaptive Card inputs (in Web Chat) are handled properly, I took the sample card JSON found on the "Inputs" page in the Adaptive Cards docs, and added logic to handle all the inputs rendered from that JSON.

The following elements should now be handled as well as all other input tag elements (date pickers, number pickers, etc):

  • compact choice sets (dropdown lists)
  • multiline text inputs (textarea)
  • labels for choice sets and toggles (radio buttons / checkboxes)

cards-fix

NOTE: At points in the gif it looks like I'm interacting with invisible UI elements (when using the date picker / dropdown). That's because my screen recorder was unable to record floating UI elements for whatever reason.

@tonyanziano tonyanziano force-pushed the toanzian/cards-fix branch from 571f28e to 1bc5fab Jul 16, 2019

@tonyanziano tonyanziano force-pushed the toanzian/cards-fix branch from e662a03 to 9077400 Jul 17, 2019

@tonyanziano tonyanziano merged commit a190d54 into master Jul 17, 2019

2 checks passed

Emulator-CI-PR #71274 succeeded
Details
license/cla All CLA requirements met.
Details

@tonyanziano tonyanziano deleted the toanzian/cards-fix branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.