Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some minor styling issues with the JSON inspector. #1691

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@tonyanziano
Copy link
Contributor

commented Jul 16, 2019

List of changes:

  • swapped out previous & next diff icons with flat icons that don't have drop-shadows
    • (also got rid of left-arrow svg in favor of rotating the right-arrow)
  • changed header for JSON inspector from "Json" -> "JSON"
  • changed casing of "Show Diff" & "Hide Diff" -> "Show diff" & "Hide diff"
  • JSON header now always has "active" or "selected" styling so the blue underline doesn't go away when toggling the show / hide diff button
  • syntax highlighting should now work again for the JSON tree when in diff mode

Before:

image

After:

image

@tonyanziano tonyanziano force-pushed the toanzian/inspector-fixes branch from 90ad797 to 2cd1d11 Jul 16, 2019

@cwhitten cwhitten merged commit fc36309 into master Jul 17, 2019

2 checks passed

Emulator-CI-PR #71163 succeeded
Details
license/cla All CLA requirements met.
Details

@cwhitten cwhitten deleted the toanzian/inspector-fixes branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.