Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Conversation: send a single conversation update activity including bot and user as members added #1709

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@carlosscastro
Copy link
Member

carlosscastro commented Aug 7, 2019

No description provided.

…g bot and user as members added
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 7, 2019

Coverage Status

Coverage decreased (-0.02%) to 62.91% when pulling 83be3d3 on ccastro/aggregated-conversation-update into 35635ea on master.

Copy link
Contributor

tonyanziano left a comment

I think this same logic needs to be applied to the /v3/directline/conversations route as well.

Source can be found here.

===

I'm still not entirely sure which route gets hit when.

@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Aug 7, 2019

Needs a CHANGELOG.md entry as well.

@carlosscastro

This comment has been minimized.

Copy link
Member Author

carlosscastro commented Aug 7, 2019

Thanks @tonyanziano I'll make those updates

Copy link
Contributor

tonyanziano left a comment

Awesome! 👍

@tonyanziano tonyanziano merged commit 54e8cbe into master Aug 7, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #74393 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the ccastro/aggregated-conversation-update branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.