Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where opening a chat via url was sending two conversation u… #1735

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Aug 16, 2019

…pdates.

This was only happening when opening a bot via url for the first time. Any conversation restarts after that, or opening a livechat via .bot file were working as intended.

Addresses #1689

===

  • Reversed the order in which the members get added to the membersAdded array to be consistent with line 73 in the same file

Before the fix:

before_fix

After the fix:

after_fix

@tonyanziano tonyanziano force-pushed the toanzian/convo-update branch from 38a1654 to 67b2e8b Aug 16, 2019
Copy link
Member

stevengum left a comment

LGTM...

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 16, 2019

Coverage Status

Coverage decreased (-0.03%) to 62.881% when pulling 142391a on toanzian/convo-update into 54e8cbe on master.

Copy link
Contributor

compulim left a comment

Love the convergence between "add bot" and "add user" code.

CHANGELOG.md Outdated Show resolved Hide resolved
@tonyanziano tonyanziano dismissed stale reviews from compulim and stevengum via 142391a Aug 16, 2019
@tonyanziano tonyanziano force-pushed the toanzian/convo-update branch from 67b2e8b to 142391a Aug 16, 2019
@tonyanziano tonyanziano merged commit f8e7976 into master Aug 16, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #75749 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/convo-update branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.