Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with emulated oauth token. #1738

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Aug 16, 2019

There was an issue when the Emulator would fallback to sending an emulated oauth token (in the case that we couldn't generate a sign-in link for a genuine oauth token), where the conversation id was being sent as the token instead of a token with the following format:

emulatedToken_<GUID>

which was being passed along from this function call in hyperlinkHandler.ts

===

Before fix:

fix_before

After fix:

fix_after

@tonyanziano tonyanziano force-pushed the toanzian/emulated-token branch from 7583bca to f13fca5 Aug 16, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 16, 2019

Coverage Status

Coverage decreased (-0.04%) to 65.295% when pulling f13fca5 on toanzian/emulated-token into f8e7976 on master.

@cwhitten cwhitten merged commit 1f21dab into master Aug 16, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #75769 succeeded
Details
license/cla All CLA requirements met.
Details
@cwhitten cwhitten deleted the toanzian/emulated-token branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.