Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error logging to OAuth signin link generation flow. #1745

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Aug 19, 2019

Fixes #1728

===

Before, if the Emulator failed to spin up an ngrok instance for the OAuth signin flow (due to a misconfigured ngrok path, or some other ngrok related error), it would swallow the error and fall back to generating an emulated OAuth token.

This change will now log any errors from that flow to the log panel, and tell the user that it is falling back to generating an emulated OAuth token.

image

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 19, 2019

Coverage Status

Coverage increased (+0.05%) to 65.342% when pulling 56cbd07 on toanzian/oauth-logging into 508bd95 on master.

@tonyanziano tonyanziano marked this pull request as ready for review Aug 19, 2019
@cwhitten cwhitten merged commit 3b42aa7 into master Aug 20, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #75981 succeeded
Details
license/cla All CLA requirements met.
Details
@cwhitten cwhitten deleted the toanzian/oauth-logging branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.