Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1717] Fixed issue with tab state a11y. #1781

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Aug 26, 2019

#1717

===

Tab state is now correctly read by screen reader and number of tabs is enumerated.

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1717 branch from 3ffd612 to 40b9060 Aug 26, 2019
Copy link
Member

corinagum left a comment

LGTM - one nitpick comment

<div className={styles.tabFocusTarget} role="button" tabIndex={0} aria-label={`${label}, tab`}>
{this.props.dirty ? <span role="presentation">*</span> : null}
<div className={styles.tabSeparator} role="presentation" />
<div className={styles.tabFocusTarget} role="tab" tabIndex={0} aria-label={`${label}`} aria-selected={active}>

This comment has been minimized.

Copy link
@corinagum

corinagum Aug 26, 2019

Member

alphabetical sort? (feel free to ignore)

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 26, 2019

Coverage Status

Coverage remained the same at 65.342% when pulling 40b9060 on toanzian/acc-#1717 into 55f9db9 on master.

@tonyanziano tonyanziano merged commit 3dcbad5 into master Aug 26, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #76731 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1717 branch Aug 26, 2019
@corinagum corinagum changed the title Fixed issue with tab state a11y. [#1717] Fixed issue with tab state a11y. Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.