Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1742] Overflow visible on row to show focus borders #1790

Merged
merged 5 commits into from Sep 4, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Aug 28, 2019

#1742

Fix appearance of bot creation dialog anchors, which were previously not showing the entire boxed border on focus. This fix removes overflow:hidden from the Row component.

image

This is how the the dialog looks now:

corinagum added 2 commits Aug 28, 2019
@corinagum corinagum changed the title Overflow visible on row to show focus borders [#1742] Overflow visible on row to show focus borders Aug 28, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 28, 2019

Coverage Status

Coverage remained the same at 65.574% when pulling fb78b3c on corinagum/1742 into cc73e75 on master.

Copy link
Contributor

tonyanziano left a comment

I thought this might have some unforeseen consequences when resizing the app (horizontal scrollbars), but I messed around with it and I couldn't find anything.

The only other alternative fix other than overflow that I can think of would be to add a small padding inside of all the rows to accommodate any focus outlines, but that seems worse.

We'll just have to keep an eye out for any strange behavior where <Row />'s are involved.

@corinagum

This comment has been minimized.

Copy link
Member Author

corinagum commented Sep 4, 2019

@tonyanziano ping on this guy :)

@tonyanziano tonyanziano merged commit 1b9a3ad into master Sep 4, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #77781 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1742 branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.