Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1743 - Fix endpoint notify text color #1827

Merged
merged 8 commits into from Sep 4, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Sep 4, 2019

#1743

Previously the endpoint notification text for opening a bot was showing as a low-contrast yellow. I fixed the text to a dark grey per @DesignPolice. Since the openBotDialog and botCreationDialog components were displaying different colors for these texts, I made both of them dark grey.

image
image

High Contrast:
image
image

(And for sanity, Dark:)
image

@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Sep 4, 2019

Check this on High Contrast, I'm pretty sure it's going to be invisible because the HC dialog background is black.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 4, 2019

Coverage Status

Coverage remained the same at 65.588% when pulling f9dcda0 on corinagum/1743 into 5022eb3 on master.

@DesignPolice

This comment has been minimized.

Copy link
Member

DesignPolice commented Sep 4, 2019

Check this on High Contrast, I'm pretty sure it's going to be invisible because the HC dialog background is black.

:-( well in HC if it was black background it would need to switch to White... seems like it should go to a white background vs. black?

@corinagum corinagum changed the title #1743 - Fix endpiont notify text color #1743 - Fix endpoint notify text color Sep 4, 2019
corinagum added 3 commits Sep 4, 2019
@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Sep 4, 2019

@DesignPolice in HC we used to have light-themed dialogs with an #F4F4F4 background, but we switched away from that.

We could discuss going back to that model if it makes more sense from a design standpoint.

Copy link
Contributor

tonyanziano left a comment

👍

@tonyanziano tonyanziano merged commit f819ab8 into master Sep 4, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #77801 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1743 branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.