Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1819][MAS4.1.2] [Screen Reader-Debug] Screen reader is not reading the Name for “Previous and Next” arrow buttons #1841

Merged
merged 8 commits into from Sep 6, 2019

Conversation

@denscollo
Copy link
Collaborator

denscollo commented Sep 5, 2019

Solves #1819

Description

This pull request enables the proper reading of the “Previous and Next” arrow buttons

Changes made

  • Add aria-label to left and right arrows buttons
  • Update set Previous/Next instead of Left/Right
Bill7zz added 3 commits Sep 5, 2019
denscollo added 2 commits Sep 5, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage remained the same at 65.767% when pulling 0bc6ee8 on fix/screen-reader-arrow-buttons into de257ae on master.

denscollo added 2 commits Sep 6, 2019
Copy link
Contributor

tonyanziano left a comment

👍

@tonyanziano tonyanziano merged commit 57bf5b6 into master Sep 6, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78125 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the fix/screen-reader-arrow-buttons branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.