Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1817][MAS1.3.3] [Visual Requirements-Debug] Tool tips are not defined for “Previous, Next and Show diff” controls #1852

Merged
merged 6 commits into from Sep 11, 2019

Conversation

@denscollo
Copy link
Collaborator

denscollo commented Sep 9, 2019

Solves #1817

Description

The tooltips for arrows and hide-show buttons weren't showing.

Changes made

  • Tooltips for arrows and hide-show buttons

Testing

tooltips in previous, next and hide show diff

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 9, 2019

Coverage Status

Coverage remained the same at 65.787% when pulling ca3699c on fix/tooltips-for-arrows-and-hide-show-buttons into f034cbc on master.

@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Sep 9, 2019

I think a tooltip should be added to the "Copy json" button as well, just to preemptively knock out that accessibility issue.

denscollo added 3 commits Sep 11, 2019
Copy link
Contributor

tonyanziano left a comment

Great, thanks!

@tonyanziano tonyanziano merged commit 22f5958 into master Sep 11, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78545 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the fix/tooltips-for-arrows-and-hide-show-buttons branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.