Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1808, #1809, #1810] Fixed Bot Inspector docs page accessibility #1858

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Sep 10, 2019

#1808, #1809, #1810

===

Fixes:

  • Cutoff focus outline border on top-level links
  • Header semantics of generated Markdown page (h1's downgraded to h2's, h2's to h3's, now only one h1 on the page)
  • Using browse mode will no longer get stuck in the dialog host component and read "blank" repeatedly

image

image

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1808-10 branch from 08867ab to 846e284 Sep 10, 2019
@tonyanziano tonyanziano marked this pull request as ready for review Sep 10, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 10, 2019

Coverage Status

Coverage increased (+0.002%) to 65.787% when pulling 65bf397 on toanzian/acc-#1808-10 into 7c9e2bd on master.

Copy link
Member

corinagum left a comment

LGTM! :)

@tonyanziano tonyanziano force-pushed the toanzian/acc-#1808-10 branch from 846e284 to 65bf397 Sep 10, 2019
@tonyanziano tonyanziano merged commit d9ab68a into master Sep 10, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78443 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1808-10 branch Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.