Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-label to checkboxes to prevent doubling of text #1865

Merged
merged 4 commits into from Sep 13, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Sep 11, 2019

#1823

Checkboxes were previously reading the label twice. Adding aria-label prevents double reading of text.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 11, 2019

Coverage Status

Coverage decreased (-0.04%) to 65.742% when pulling 0db801d on corinagum/1823 into b979700 on master.

Copy link
Contributor

tonyanziano left a comment

Needs changelog entry

@tonyanziano tonyanziano merged commit 2743410 into master Sep 13, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #78853 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1823 branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.