Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1846] Fixed functionality and a11y issues with generic service editor dialog. #1871

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Sep 17, 2019

#1846

===

The <KvPair/> component was actually broken and did not work. Additionally, the accessibility was not satisfactory.

Before, the control would try to auto-add new rows as you started filling in the previous rows, but did not work properly. The new, simplified approach provides buttons to add or remove rows.

The component will now also focus the newest row after adding a row, as well as announce to the screen reader when the user deletes a row.

Before:
oldKv

After:
newKv

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 17, 2019

Coverage Status

Coverage decreased (-0.02%) to 65.74% when pulling 7144a14 on toanzian/acc-#1846 into 10efb67 on master.

Copy link
Member

corinagum left a comment

:) cool stuff

@@ -73,3 +73,20 @@ ul.kv-pair-container {
.no-border {
border: none;
}

.link-button {

This comment has been minimized.

Copy link
@corinagum

corinagum Sep 17, 2019

Member

just FYI I'll replace this with <LinkButton> when it's time to merge my PR :)

This comment has been minimized.

Copy link
@tonyanziano

tonyanziano Sep 17, 2019

Author Contributor

Sounds good!

@tonyanziano tonyanziano merged commit dc8cf55 into master Sep 17, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #79206 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/acc-#1846 branch Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.