Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all links/link-like-buttons to <LinkButton> #1877

Merged
merged 42 commits into from Sep 26, 2019

Conversation

@corinagum
Copy link
Member

corinagum commented Sep 20, 2019

#1712, #1806, #1825

image

This PR fixes the roles of all buttons and links that look like links (See above: blue text is our example)

There shouldn't be any visual changes, this is a semantics / tests update. Dialog/explorer links will be the darker blue, while pages will be the default blue.

@tonyanziano, sorry for the ginoromous PR.

@corinagum corinagum requested a review from tonyanziano as a code owner Sep 20, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 20, 2019

Coverage Status

Coverage increased (+0.02%) to 65.931% when pulling cc09000 on corinagum/1825 into 77c4d51 on master.

@tonyanziano

This comment has been minimized.

Copy link
Contributor

tonyanziano commented Sep 24, 2019

Coverage also dropped 0.4%. This needs tests, half a percent is pretty huge

corinagum added 8 commits Sep 24, 2019
@@ -102,4 +117,11 @@ describe('The ConnectServicePromptDialog component should', () => {
instance.props.addServiceManually();
expect(spy).toHaveBeenCalledWith(2);
});

it('should call the appropriate command when onAnchorClick is called', async () => {

This comment has been minimized.

Copy link
@tonyanziano

tonyanziano Sep 26, 2019

Contributor

async is unnecsesary

@@ -64,4 +71,11 @@ describe('<DataCollectionDialogContainer />', () => {

expect(hideDialogSpy).toHaveBeenCalledWith(true);
});

it('should call the appropriate command when onAnchorClick is called', async () => {

This comment has been minimized.

Copy link
@tonyanziano

tonyanziano Sep 26, 2019

Contributor

async is unnecessary

@@ -196,4 +200,18 @@ describe('The GetStartedWithCSDialog component should', () => {
const prompt = parent.find(GetStartedWithCSDialog);
expect(prompt.instance().content).toBeNull();
});

it('should call the appropriate command when onAnchorClick is called', async () => {

This comment has been minimized.

Copy link
@tonyanziano

tonyanziano Sep 26, 2019

Contributor

async is unnecessary

corinagum added 3 commits Sep 26, 2019
Copy link
Contributor

tonyanziano left a comment

Nice!

@tonyanziano tonyanziano merged commit 1c1c498 into master Sep 26, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #80722 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the corinagum/1825 branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.