Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with duplicate native browser functions. #1920

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Oct 8, 2019

In #1893 I implemented functionality for native browser functions (cut, copy, paste, etc.) that were already functional inside of Chrome.

The implemented functionality didn't eat or stop the original event's native behavior, so actions like cut, copy, paste, were being fired twice instead of a single time. This was problematic when pasting credentials into the Open Bot dialog because they were duplicated if pasted into inputs with Ctrl+V, and thus were wrong when sent to the server.

Ex: myPassword --> Ctrl + V --> myPasswordmyPassword

I removed my implementation and will just leave the functionality up to the browser.

@tonyanziano tonyanziano force-pushed the toanzian/shortcut-fix branch from 80c06c5 to 4147655 Oct 8, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 8, 2019

Coverage Status

Coverage decreased (-0.07%) to 66.892% when pulling 4147655 on toanzian/shortcut-fix into 3cd3fcf on master.

Copy link
Contributor

compulim left a comment

Wonder why we had these functions in-place. 😕

@tonyanziano tonyanziano merged commit 2a14fe6 into master Oct 9, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #82198 succeeded
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/shortcut-fix branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.