Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[ISSUE1897] [MAS4.2.11][Screen Reader- Create new bot configuration] After "Save and connect", the focus goes on the hidden element and announced as "secret copied to the clipboard #1934
This pull request fixes how the focus behaves after clicking the "Save and Connect" button, no longer sending the focus on the hidden element and announcing "secret copied to the clipboard"
The problem was caused by the button, when clicked it was creating a new tag with the role alert and adding it to the body, which can then be browsed with the keyboard.
Is there any way we can hide the alert from being focused by giving it a
If you look at the original PR in which this alert service was added, @corinagum and I had a discussion about whether or not to remove the alert from the DOM after a period of time.
It looks like the suggested model is to leave the alert until another is created to replace it.
Also, was the duration of 1 second tried out with long alert messages? If the alert is long enough, will the screen reader be cut off when the alert is removed from the DOM?
@tonyanziano we checked this using the
We just pushed the update with the aria-hidden attribute.