Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made e2e tests more reliable across different machines. #1944

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@tonyanziano
Copy link
Contributor

tonyanziano commented Oct 28, 2019

On Linux, and I believe what Andy encountered on Mac as well, the tests would sometimes be prevented from functioning correctly due to a modal being shown in the app on startup that would cover the entire screen.

This PR adds a utility function to dismiss any showing dialogs before proceeding with the tests.

I also noticed that on Linux, querying an element for its checked attribute was returning null instead of false, like it does on Windows. The check has been changed to check for falsiness instead of the value being === false.

Results:

image

Copy link
Member

corinagum left a comment

LGTM :)

@tonyanziano tonyanziano merged commit 913ac3d into master Oct 29, 2019
2 checks passed
2 checks passed
Emulator-CI-PR #86586 succeeded with issues
Details
license/cla All CLA requirements met.
Details
@tonyanziano tonyanziano deleted the toanzian/e2e-linux branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.